Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility

[Thomas Monjalon <thomas@monjalon.net>]

20/12/2018 15:52, Hunt, David:
> On 19/12/2018 8:31 PM, Thomas Monjalon wrote:
> > 19/12/2018 10:09, Hunt, David:
> >> On 19/12/2018 3:18 AM, Thomas Monjalon wrote:
> >>> 14/12/2018 14:11, Liang Ma:
> >>>> Previously, in order to use the power library, it was necessary
> >>>> for the user to disable the intel_pstate driver by adding
> >>>> “intel_pstate=disable” to the kernel command line for the system,
> >>>> which causes the acpi_cpufreq driver to be loaded in its place.
> >>>>
> >>>> This patch adds the ability for the power library use the intel-pstate
> >>>> driver.
> >>>>
> >>>> It adds a new suite of functions behind the current power library API,
> >>>> and will seamlessly set up the user facing API function pointers to
> >>>> the relevant functions depending on whether the system is running with
> >>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest,
> >>>> using kvm. The library API and ABI is unchanged.
> >>>>
> >>>> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> >>>>
> >>>> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>> ---
> >>> Please write a changelog when sending a new version.
> >>>
> >>> Dave, any comment on this patch?
> >>
> >> Looks good to me.
> >>
> >> Acked-by: David Hunt <david.hunt@intel.com>
> >>
> >>
> >>>> --- /dev/null
> >>>> +++ b/lib/librte_power/power_pstate_cpufreq.c
> >>>> @@ -0,0 +1,770 @@
> >>>> +/* SPDX-License-Identifier: BSD-3-Clause
> >>>> + * Copyright(c) 2018-2018 Intel Corporation
> >>> Something wrong here :)
> >> Yes, should simply be "Copyright(c) 2018 Intel Corporation"
> >
> > There is also a compilation error with meson:
> >
> > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error:
> > 	rte_timer.h: No such file or directory
> >
> > Clearly, some quality checks are missing.
> >
> > I'm afraid we won't have any patch for power library in 19.02.
> 
> 
> Hi Thomas,
> 
> We have just pushed a v4, and tested with make, meson/ninja, and several 
> different build environments. I believe this version should be 
> acceptable for 19.02.

I don't think so.
I will give more comments in v4 and will give up for 19.02.