From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>, Ding Zhi <zhi.ding@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix default RX/TX flow control values
Date: Mon, 15 Jun 2015 11:53:22 +0200 [thread overview]
Message-ID: <3444705.8u2oBuzF7f@xps13> (raw)
In-Reply-To: <1433160669-20810-1-git-send-email-david.marchand@6wind.com>
> This variable has undefined values in some cases.
>
> Fixes: 422a20a4e62d ("app/testpmd: fix uninitialized flow control variables")
> Signed-off-by: Ding Zhi <zhi.ding@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4743,7 +4743,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,
> struct cmd_link_flow_ctrl_set_result *res = parsed_result;
> cmdline_parse_inst_t *cmd = data;
> struct rte_eth_fc_conf fc_conf;
> - int rx_fc_en, tx_fc_en = 0;
> + int rx_fc_en = 0, tx_fc_en = 0;
> int ret;
Applied with lines split to conform with the coding rules:
http://dpdk.org/browse/dpdk/tree/doc/guides/guidelines/coding_style.rst#n461
prev parent reply other threads:[~2015-06-15 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:11 David Marchand
2015-06-15 9:53 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3444705.8u2oBuzF7f@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=zhi.ding@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).