From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 14A0B1288
 for <dev@dpdk.org>; Mon, 15 Jun 2015 11:54:20 +0200 (CEST)
Received: by wiwd19 with SMTP id d19so69508068wiw.0
 for <dev@dpdk.org>; Mon, 15 Jun 2015 02:54:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=yLpilH0uhzLo5ydGbAH9CiDvvhsXhOcu7Wxn1Gn6OUc=;
 b=Q6MD1X/Lfxsr4XIu8qAOKR4FfWkIGck0GLQbu97UCcsxkSWYxCkaZuRy01IsJQk5w6
 KzWfiQl17yI5buaXcaNmM8RVzCcs/cnndv0izm8sfHc3o0ryNWPodu+Flhb+YmDX+Smq
 D37zAF8N1jnIsEjHJ0ysIKDB8KtrOS/8SjF6kcK/jU4h0u5r1Qxd8Nl0iwTmXp3lRsD4
 p98SgdGEtFu8BuKfVmQidKn1gI1yHagyY4HOlN6fZe1KGnXQw9hpY34AmQTGFPLaCino
 qv8X9Z26R9K59yYUN3msCr6Xbt5wwfeXkt+ffImpUakER/BS9RulALVHOerBZASmOsoV
 9k6w==
X-Gm-Message-State: ALoCoQnPFMzNe/2oGjtc3n6mxpJeF1UNXG6bCIodDiEF95MVnW/w0Dtz6uVzQvniyqxLu1Sl21W7
X-Received: by 10.180.73.236 with SMTP id o12mr30041723wiv.56.1434362059901;
 Mon, 15 Jun 2015 02:54:19 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id d3sm18107579wjs.21.2015.06.15.02.54.18
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 15 Jun 2015 02:54:19 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>, Ding Zhi <zhi.ding@6wind.com>
Date: Mon, 15 Jun 2015 11:53:22 +0200
Message-ID: <3444705.8u2oBuzF7f@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1433160669-20810-1-git-send-email-david.marchand@6wind.com>
References: <1433160669-20810-1-git-send-email-david.marchand@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix default RX/TX flow control
	values
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2015 09:54:20 -0000

> This variable has undefined values in some cases.
> 
> Fixes: 422a20a4e62d ("app/testpmd: fix uninitialized flow control variables")
> Signed-off-by: Ding Zhi <zhi.ding@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4743,7 +4743,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,
>  	struct cmd_link_flow_ctrl_set_result *res = parsed_result;
>  	cmdline_parse_inst_t *cmd = data;
>  	struct rte_eth_fc_conf fc_conf;
> -	int rx_fc_en, tx_fc_en = 0;
> +	int rx_fc_en = 0, tx_fc_en = 0;
>  	int ret;

Applied with lines split to conform with the coding rules:
http://dpdk.org/browse/dpdk/tree/doc/guides/guidelines/coding_style.rst#n461