From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Dai, Wei" <wei.dai@intel.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Curran, Greg" <greg.curran@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix statistics description
Date: Mon, 07 Nov 2016 21:37:02 +0100 [thread overview]
Message-ID: <3445523.JqAozkltlD@xps13> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC359EA906@smartserver.smartshare.dk>
2016-11-02 10:21, Morten Brørup:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2016-08-26 18:08, Wei Dai:
> > > > /**
> > > > * A structure used to retrieve statistics for an Ethernet port.
> > > > + * Not all statistics fields in struct rte_eth_stats are supported
> > > > + * by any type of network interface card (NIC). If any statistics
> > > > + * field is not supported, its value is 0 .
> > > > */
> > > > struct rte_eth_stats {
> > >
> > > I'm missing the point of this patch.
> > > Why do you think it is a fix?
> > >
> > > John, any opinion?
>
> I think the source code comment is an improvement.
[...]
Applied as an improvement (not a fix).
next prev parent reply other threads:[~2016-11-07 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 10:08 Wei Dai
2016-10-04 9:34 ` Thomas Monjalon
2016-11-02 8:28 ` Dai, Wei
2016-11-02 9:07 ` Mcnamara, John
2016-11-03 2:00 ` Remy Horton
2016-11-03 9:07 ` Morten Brørup
2016-11-02 9:21 ` Morten Brørup
2016-11-07 20:37 ` Thomas Monjalon [this message]
2016-11-08 13:33 ` Tahhan, Maryam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3445523.JqAozkltlD@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=greg.curran@intel.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).