From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id D755D9E3 for ; Mon, 7 Nov 2016 21:37:04 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id p190so207107560wmp.1 for ; Mon, 07 Nov 2016 12:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=8mkobzntV8FiK+KvzQR1sFK0uzwL6DtbO3AmAsRLeZA=; b=gsEKLr6pJBR+ExOm1NyctArGMV+1r7wR4W5+xw700Kox+PmlZQmbRLKwdY9YiOXu53 kCSHvKJqnTKWX0qWKBMi879Hv7NOTo92Q6yxZ/X88ODn1wzP/Ueoqn039MdyMMka1jGB EaXEZIHWejKj53oJSQFg0xTa2ncMrMD3HaiYeQyaJNIDdj7AQF9aH1fuRpfNhUdhx3wf 9069aT6vBOeaZ4bJUmrfNivYLtdYBPj+8KkxGrRMUUISkq1hNp25gQDw4UpYWvvkabiT Qhwopb4vTB0pGU9GluQeXe57+a9MzPFNfRZ2/GAd6rgkGXQ6m5/MgirAsssQy2yNDudm Lw6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=8mkobzntV8FiK+KvzQR1sFK0uzwL6DtbO3AmAsRLeZA=; b=DNtcP4+VGYczBFaY3MR/16YID9o7+KxWNSAdmidU8IC/xc2iNk83wh7Demos9yet/E WX6iWGrjekv7VD0mWu1b+dDWmLZ47U0hXZPM5kqGzLaWdkMmgPf+KbgYdoGpKjFvfyAM jHicNK9z9SVZOQ0z4wrgnC1h/kMxA1N7gjBz0XfS8k/Q0byoS+S+MQCTZpOJhpiqqsiN jcG8d8Fv/2gzsIkMWTPVhUSi8QKGs136lYvvyjliBtwb26ATZP6DCpNqyJvmyhFOOJ3I U+zNwnlgQ2JQq20QHxX1kDxv0pZ6C+rd+opAKbz94hVDR2tA6nXjIT6IhLcfWU+sCFQI PnUg== X-Gm-Message-State: ABUngvcnAuRE1ytZIkd0FOUpEND7NL9s9YTmz1OEO+aat4lAChR+IBONDj7PqRnA75uuJrHC X-Received: by 10.28.24.1 with SMTP id 1mr10527729wmy.107.1478551024306; Mon, 07 Nov 2016 12:37:04 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jt8sm33026238wjc.33.2016.11.07.12.37.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 12:37:03 -0800 (PST) From: Thomas Monjalon To: "Dai, Wei" Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= , "Mcnamara, John" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Zhang, Helin" , "Curran, Greg" , dev@dpdk.org Date: Mon, 07 Nov 2016 21:37:02 +0100 Message-ID: <3445523.JqAozkltlD@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC359EA906@smartserver.smartshare.dk> References: <1472206104-22035-1-git-send-email-wei.dai@intel.com> <49759EB36A64CF4892C1AFEC9231E8D63A2EB13C@PGSMSX106.gar.corp.intel.com> <98CBD80474FA8B44BF855DF32C47DC359EA906@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix statistics description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 20:37:05 -0000 2016-11-02 10:21, Morten Br=F8rup: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-08-26 18:08, Wei Dai: > > > > /** > > > > * A structure used to retrieve statistics for an Ethernet por= t. > > > > + * Not all statistics fields in struct rte_eth_stats are suppo= rted > > > > + * by any type of network interface card (NIC). If any statist= ics > > > > + * field is not supported, its value is 0 . > > > > */ > > > > struct rte_eth_stats { > > > > > > I'm missing the point of this patch. > > > Why do you think it is a fix? > > > > > > John, any opinion? >=20 > I think the source code comment is an improvement. [...] Applied as an improvement (not a fix).