From: Thomas Monjalon <thomas@monjalon.net>
To: Dharmik Thakkar <dharmik.thakkar@arm.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>,
dev@dpdk.org, nd@arm.com,
Bruce Richardson <bruce.richardson@intel.com>,
Nicolas Chautru <nicolas.chautru@intel.com>,
Liron Himi <lironh@marvell.com>, Zyta Szpak <zr@semihalf.com>,
Michael Shamis <michaelsh@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build
Date: Fri, 13 Nov 2020 10:29:58 +0100 [thread overview]
Message-ID: <3446766.G5VGAq2Z8k@thomas> (raw)
In-Reply-To: <20201105161130.GA781@bricha3-MOBL.ger.corp.intel.com>
05/11/2020 17:11, Bruce Richardson:
> On Thu, Nov 05, 2020 at 09:33:15AM -0600, Dharmik Thakkar wrote:
> > With pkg-config support available within AArch64crypto library,
> > meson option 'armv8_crypto_dir' can be removed.
> > PKG_CONFIG_PATH environment variable should be set appropriately
> > to use the crypto library.
> >
> > Refer [1] for build instructions.
> >
> > [1]
> > https://doc.dpdk.org/guides/cryptodevs/armv8.html
> >
> > Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> > Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >
> This simplification is great to see, thanks.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Series applied, thanks
Next meson options to be removed please:
- flexran_sdk
- lib_musdk_dir
next prev parent reply other threads:[~2020-11-13 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:33 Dharmik Thakkar
2020-11-05 15:33 ` [dpdk-dev] [PATCH 2/2] doc: update build guide for armv8 crypto PMD Dharmik Thakkar
2020-11-06 1:39 ` Ruifeng Wang
2020-11-05 16:11 ` [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build Bruce Richardson
2020-11-13 9:29 ` Thomas Monjalon [this message]
2020-11-13 9:39 ` Thomas Monjalon
2020-11-06 1:40 ` Ruifeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3446766.G5VGAq2Z8k@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=lironh@marvell.com \
--cc=michaelsh@marvell.com \
--cc=nd@arm.com \
--cc=nicolas.chautru@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).