DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: clarify comment on adding TX offload flags
Date: Thu, 16 Jul 2015 14:16:06 +0200	[thread overview]
Message-ID: <3447099.1oAx4vilGg@xps13> (raw)
In-Reply-To: <55A632E7.6000108@6wind.com>

2015-07-15 12:16, Olivier MATZ:
> On 07/09/2015 03:22 PM, Bruce Richardson wrote:
> > The comment for TX offload flags stated that those flags started at bit
> > 55 and then were added to the right of that, leaving 8 bits reserved for
> > generic mbuf (i.e. non-offload) use. This comment may not have been
> > clear as 5 of the 8 flags which were reserved have now been used for TX
> > offloads.
> > This patch:
> > * updates the description so that it now reflects reality that
> > only three flags are available for generic mbuf use
> > * reserved the final generic flag so that it can't be taken over for TX
> > offload in future
> > * clarifies the comment for TX flags to indicate that they should be
> > counting downwards not upwards.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks

      reply	other threads:[~2015-07-16 12:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 13:22 Bruce Richardson
2015-07-09 13:46 ` Eduard Gibert
2015-07-09 13:59 ` Thomas Monjalon
2015-07-15 10:16 ` Olivier MATZ
2015-07-16 12:16   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3447099.1oAx4vilGg@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).