From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 7ADE5C322 for ; Thu, 16 Jul 2015 14:17:18 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so11679426wib.0 for ; Thu, 16 Jul 2015 05:17:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=PnF3uRbWpcZnNdpgP6uDonl8oUC6gaP/jlhVlqhTlS4=; b=b6y95RlZzT6Y0vUdbPuoz3QNfhxiYlC8MHCN5flm4QtNzZTzq9TBfPxcu6vHYxDig8 f2c0Rc0itkUx/6zCRXDo3J9awZuYKEbgIds9OiQgpYN3Xb2WNfJpkDOVFf3vyRZrYKRt 61dDHAvSoUjM2atqnOmwlF8vKR4EvhD0NeTSYn3kZNeq//z4wQqPg1D4zLMZO+FVFniU GybIBUc/sLGFaDttUDjq6Ih8FWn6jgx2On6f0ctJc5VE+Xx4Er4EGqfKTCFR58xjxgHa iRK6Z0A4sN3qaOh88irWsT1b63yA0e4HdUY4itXLFRw1KUxfStZqgSOqDGrRMGEdENoh 9AWg== X-Gm-Message-State: ALoCoQleQKhmPjWYBYh+we+I3BGCe3zFY/Sh0XGKVPo1bTl6sQOKv/I/3gNxI7b3Zh1t5gjmjn6E X-Received: by 10.180.83.135 with SMTP id q7mr6099491wiy.17.1437049038287; Thu, 16 Jul 2015 05:17:18 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id j6sm2906306wix.5.2015.07.16.05.17.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 05:17:17 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 16 Jul 2015 14:16:06 +0200 Message-ID: <3447099.1oAx4vilGg@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <55A632E7.6000108@6wind.com> References: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> <55A632E7.6000108@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mbuf: clarify comment on adding TX offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 12:17:18 -0000 2015-07-15 12:16, Olivier MATZ: > On 07/09/2015 03:22 PM, Bruce Richardson wrote: > > The comment for TX offload flags stated that those flags started at bit > > 55 and then were added to the right of that, leaving 8 bits reserved for > > generic mbuf (i.e. non-offload) use. This comment may not have been > > clear as 5 of the 8 flags which were reserved have now been used for TX > > offloads. > > This patch: > > * updates the description so that it now reflects reality that > > only three flags are available for generic mbuf use > > * reserved the final generic flag so that it can't be taken over for TX > > offload in future > > * clarifies the comment for TX flags to indicate that they should be > > counting downwards not upwards. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Olivier Matz Applied, thanks