From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 33CCB5A6C for ; Thu, 19 Nov 2015 16:04:57 +0100 (CET) Received: by wmec201 with SMTP id c201so30083917wme.0 for ; Thu, 19 Nov 2015 07:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Ui630GAus5vdZi4gE/D3afNxEmC1ykxUYxL/njNqIFQ=; b=wQCOnsGXt45zji/VpVMOtEp0T1yD8zP5w14QxuHGDRFUuQzYpYprPBB3HYzfpSU0/1 gpqrrq4nKpVVFl54fZcF01IUV3AzL3DhIPnGsWuu5aKcklwcHDfmQfAGTkqYalMuWTSR ypawEdmmhHn0oPTvBUEpg7m9fKAH1IBHMKM6QCuh9EC3GQSZpRODD3ZzI5XSbM/blFjq JSncJJV5PorqTCn1bdA7JST0WXJ9jAnopSJSCopWJyFDmCY90qDwISPFzP1SjuWT60te 73R/p8too7o7Mf+wF7sYCrcXuFYBSHL0GtAijIgRdTzqw5dW7+I7LZgtgS5HER6NQqCU WqYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Ui630GAus5vdZi4gE/D3afNxEmC1ykxUYxL/njNqIFQ=; b=SmnJdVCZgdZG97KsxJXtO5E/GNnETiXWBcItr75Vnn4aszXpNW4J5w+WwUqc/KqGI8 m+T+gxFUQDPp8KYL2J4TLDmhssegRL5qLGmsW2+QkeaHZIcng0hXfIWG9Z3VeP+8zu1p B5Hy89uOzMlDiVjgjwNw7ql1IE2ivLJSQngeg42LzbaOjrcVmOCP6s0fNmV+hMXqtXni ep04WnE8T9t3axX41zkEZdas1z4DXJTbpUFEXmQn8Me8XJSgHFt8PtHK8YlABwev0ciU PZnfPpapeT5VcjWnJVknxH1bzxCldoZln/7M13DR5a5k8QK4nh4eUBFBqiNG3ZkQSOkt HJvw== X-Gm-Message-State: ALoCoQkdJ6C2C4BQ/okD1cgTfBRJJIzismtkjr/HT6afbHvXoGsspel+5qcjlUG0sAVMEiPso0Xd X-Received: by 10.28.183.215 with SMTP id h206mr17691348wmf.0.1447945496944; Thu, 19 Nov 2015 07:04:56 -0800 (PST) Received: from xps13.localnet (106.202.154.77.rev.sfr.net. [77.154.202.106]) by smtp.gmail.com with ESMTPSA id z10sm34513567wmg.4.2015.11.19.07.04.55 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 19 Nov 2015 07:04:56 -0800 (PST) From: Thomas Monjalon To: "Alejandro.Lucero" Date: Thu, 19 Nov 2015 16:02:19 +0100 Message-ID: <3447806.02PGEySCAP@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446720201-16386-2-git-send-email-alejandro.lucero@netronome.com> References: <1446720201-16386-1-git-send-email-alejandro.lucero@netronome.com> <1446720201-16386-2-git-send-email-alejandro.lucero@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/7] nfp: basic initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 15:04:57 -0000 Hi, 2015-11-05 10:43, Alejandro.Lucero: > +# Add extra flags for base driver files (also known as shared code) > +# to disable warnings > +# > +ifeq ($(CC), icc) > +CFLAGS_BASE_DRIVER = -wd593 > +else ifeq ($(CC), clang) > +CFLAGS_BASE_DRIVER += -Wno-sign-compare > +CFLAGS_BASE_DRIVER += -Wno-unused-value > +CFLAGS_BASE_DRIVER += -Wno-unused-parameter > +CFLAGS_BASE_DRIVER += -Wno-strict-aliasing > +CFLAGS_BASE_DRIVER += -Wno-format > +CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers > +CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast > +CFLAGS_BASE_DRIVER += -Wno-format-nonliteral > +else > +CFLAGS_BASE_DRIVER = -Wno-sign-compare > +CFLAGS_BASE_DRIVER += -Wno-unused-value > +CFLAGS_BASE_DRIVER += -Wno-unused-parameter > +CFLAGS_BASE_DRIVER += -Wno-strict-aliasing > +CFLAGS_BASE_DRIVER += -Wno-format > +CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers > +CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast > +CFLAGS_BASE_DRIVER += -Wno-format-nonliteral > +CFLAGS_BASE_DRIVER += -Wno-format-security > + > +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > +endif > + > +endif > +OBJS_BASE_DRIVER=$(patsubst %.c,%.o,$(notdir $(wildcard $(RTE_SDK)/lib/librte_pmd_nfp/*.c))) > +$(foreach obj, $(OBJS_BASE_DRIVER), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER))) These flags were copied from another PMD and should apply only to base drivers which we have some restricted updates. > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -142,6 +142,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lrte_pmd_e1000 > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4 > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 > +_LDLIBS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += -lrte_pmd_nfp > _LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe -lgxio > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) += -lrte_pmd_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap It is not too far of being alphabetically sorted.