Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-11-26 10:00, Panu Matilainen:
> On 11/26/2015 09:39 AM, Panu Matilainen wrote:
> > On 11/25/2015 07:38 PM, Thomas Monjalon wrote:
> >> --- a/config/common_linuxapp
> >> +++ b/config/common_linuxapp
> >> @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
> >>
> >>   #
> >>   # Compile generic crypto device library
> >> +# EXPERIMENTAL: API may change without prior notice
> >>   #
> >>   CONFIG_RTE_LIBRTE_CRYPTODEV=y
> >>   CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
> > [...]
> >
> > I think an experimental library which declares itself exempt from the
> > ABI policy should not be compiled by default. That way anybody wanting
> > to try it out will be forced to notice the experimental status.
> >
> > More generally / longer term, perhaps there should be a
> > CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and
> > defaults to off.
> 
> On a related note, librte_mbuf_offload cannot be built if 
> CONFIG_RTE_LIBRTE_CRYPTODEV is disabled. Which seems to suggest its (at 
> least currently) so tightly couple to cryptodev that perhaps it too 
> should be marked experimental and default to off.

I think you are right.
Declan, what is your opinion?