From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 26088C35C for ; Thu, 26 Nov 2015 11:10:05 +0100 (CET) Received: by wmvv187 with SMTP id v187so23743396wmv.1 for ; Thu, 26 Nov 2015 02:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=KiSmu60pBrwF2E73hxGtRivwUGvSWyA0qTiWHbHzLtc=; b=iUjdLwY53bfeVx9gQWTtsFQXzJE7tcU8pSttiYDSN7zaqgQGrIHMZHj1VvvK/3RCxV ibAHW2ohL60fevdXfLxWKIQthny6OKIzOPwGXlmTG+l2FdPntec7JPR8BX7ho9+2GsSW qd4alEqkApcJhuTcEgVXV2pLhMmuqnxbXOFP7HM86X0h3yVgAVIyJXUJbB3rp50Nwcq/ DKEgeRlQuFIAUGPsOyH3NiBRmnhMrDxqPjAE6LtJft9ItPDvc3/rlizf24Ib6tJ5T/sU iSp8QhhqwV7GgjGeyMqHHETtneMR/VnaJHs9DrnZNtKYOi1hcEmHS0RaDZX4I/soMQkn upMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=KiSmu60pBrwF2E73hxGtRivwUGvSWyA0qTiWHbHzLtc=; b=HaevH6c33QmXTPFQSvHwmDdGovVPvEiHIA0ngplEJOWZoziTsaDyd41+rWajXYBm2v 6OBwISKBpVg8UrrMN0M2l4if58DwutZmOHIlyRpZS9/tQjl2NvQmfRZqT+ChIx0gXQ4m iwQ0+3PFV5+2NuCF3xj4teNF4EfprUYsRyHHftRk3wUbxZP1Oq3dqVEXEXRZn3zBnf85 FxQOU0CaG45yzi20Lzb/+39xjiseXgGFpoGDuv7g/Uyq9V229l+y4BiQbxw4vAIhKKpF G4UIkKeWPfEaBv1/qpSJ+cBwWrFhRA24cEpZr9mzzsOoLAUyasS76u+23pha4RRLk6qS hgbQ== X-Gm-Message-State: ALoCoQnCfvP3g/3Wp81pGQwUN3SsTEqBduWF50V7xQzL3GvrzFrBZG2907asryoGoEvb++DmNrjb X-Received: by 10.28.172.129 with SMTP id v123mr2656853wme.47.1448532604619; Thu, 26 Nov 2015 02:10:04 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ft4sm27135401wjb.37.2015.11.26.02.10.03 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Nov 2015 02:10:03 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen , declan.doherty@intel.com Date: Thu, 26 Nov 2015 11:08:46 +0100 Message-ID: <34498752.nGP1cUxCqE@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5656BC09.20307@redhat.com> References: <1448473135-19604-1-git-send-email-thomas.monjalon@6wind.com> <5656B71D.7030704@redhat.com> <5656BC09.20307@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2015 10:10:05 -0000 2015-11-26 10:00, Panu Matilainen: > On 11/26/2015 09:39 AM, Panu Matilainen wrote: > > On 11/25/2015 07:38 PM, Thomas Monjalon wrote: > >> --- a/config/common_linuxapp > >> +++ b/config/common_linuxapp > >> @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y > >> > >> # > >> # Compile generic crypto device library > >> +# EXPERIMENTAL: API may change without prior notice > >> # > >> CONFIG_RTE_LIBRTE_CRYPTODEV=y > >> CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n > > [...] > > > > I think an experimental library which declares itself exempt from the > > ABI policy should not be compiled by default. That way anybody wanting > > to try it out will be forced to notice the experimental status. > > > > More generally / longer term, perhaps there should be a > > CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and > > defaults to off. > > On a related note, librte_mbuf_offload cannot be built if > CONFIG_RTE_LIBRTE_CRYPTODEV is disabled. Which seems to suggest its (at > least currently) so tightly couple to cryptodev that perhaps it too > should be marked experimental and default to off. I think you are right. Declan, what is your opinion?