DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, ocardona@microsoft.com, roretzla@microsoft.com,
	david.marchand@redhat.com, ferruh.yigit@intel.com,
	bruce.richardson@intel.com
Subject: Re: out of tree driver builds broken with C++
Date: Mon, 14 Feb 2022 10:22:08 +0100	[thread overview]
Message-ID: <3450334.eFTFzoEnKi@thomas> (raw)
In-Reply-To: <20220214091350.GA2793@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

14/02/2022 10:13, Tyler Retzlaff:
> while the driver api is "internal" we agreed some time ago that drivers
> could be built external to the dpdk tree. by enabling the meson setup
> option -Denable_driver_sdk=true.
> 
> it was agreed that the driver api was internal and would attract no
> binary compatibility support which was fine.  this change has now
> imposed a further restriction that out of tree drivers have to be
> authored in C only as non-C++ compatible code will invariably leak into
> the internal structures.
> 
> you won't allow us to build C++ drivers in the dpdk tree and it seems
> now you are preventing building of C++ drivers outside of the tree too.

That's the problem of non-written assumptions, they are unknown or forgotten.
Did we agree to support out-of-tree drivers in C++?

We really need to make things clear and written in documentation.

> could we please re-evaluate this.

Yes we can re-evaluate.
What is the list of impacted files?



> commit 7a335720575507f55b723b1e10bfea7daeba1386
> Author: Thomas Monjalon <thomas@monjalon.net>
> Date:   Wed Sep 15 18:46:35 2021 +0200
> 
>     lib: remove C++ include guard from private headers
> 
>     The private headers are compiled internally with a C compiler.
>     Thus extern "C" declaration is useless in such files.
> 
>     Signed-off-by: Thomas Monjalon <thomas@monjalon.net>




  reply	other threads:[~2022-02-14  9:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14  9:13 Tyler Retzlaff
2022-02-14  9:22 ` Thomas Monjalon [this message]
2022-02-14 10:45   ` Bruce Richardson
2022-02-14 11:19     ` Thomas Monjalon
2022-02-14 11:43       ` Bruce Richardson
2022-02-14 15:03         ` Bruce Richardson
2022-02-14 17:24           ` Stephen Hemminger
2022-02-14 17:49             ` Thomas Monjalon
2022-02-14 18:21               ` Stephen Hemminger
2022-02-14 18:32                 ` Tyler Retzlaff
2022-02-14 18:40                   ` Tyler Retzlaff
2022-02-14 18:03             ` Bruce Richardson
2022-02-15  6:10   ` Tyler Retzlaff
2022-02-15  8:55     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3450334.eFTFzoEnKi@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ocardona@microsoft.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=roretzla@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).