From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD77945D78; Fri, 22 Nov 2024 01:48:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D3B4026E; Fri, 22 Nov 2024 01:48:03 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id D7C854026A for ; Fri, 22 Nov 2024 01:48:01 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XvbyL6JW2zQvFB; Fri, 22 Nov 2024 08:46:34 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id EA46B180106; Fri, 22 Nov 2024 08:47:58 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 22 Nov 2024 08:47:58 +0800 Message-ID: <34527ced-9de7-4ebe-b3a5-70e966a1f1ad@huawei.com> Date: Fri, 22 Nov 2024 08:47:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd To: Andre Muezerie , References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732225298-10322-1-git-send-email-andremue@linux.microsoft.com> <1732225298-10322-21-git-send-email-andremue@linux.microsoft.com> Content-Language: en-US From: fengchengwen In-Reply-To: <1732225298-10322-21-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/11/22 5:41, Andre Muezerie wrote: > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. > > Signed-off-by: Andre Muezerie > --- > app/test-pmd/shared_rxq_fwd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c > index 623d62da88..b85830b90e 100644 > --- a/app/test-pmd/shared_rxq_fwd.c > +++ b/app/test-pmd/shared_rxq_fwd.c > @@ -92,7 +92,7 @@ forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx, > static bool > shared_rxq_fwd(struct fwd_stream *fs) > { > - struct rte_mbuf *pkts_burst[nb_pkt_per_burst]; > + struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; > uint16_t nb_rx; > > nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);