From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Eric Kinzie <ehkinzie@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: vector rx rearm after queue reset
Date: Mon, 03 Aug 2015 17:07:20 +0200 [thread overview]
Message-ID: <3452808.fsduaX7ycr@xps13> (raw)
In-Reply-To: <1435256741-25489-2-git-send-email-ehkinzie@gmail.com>
2015-06-25 11:25, Eric Kinzie:
> zero values in ixgbe_reset_rx_queue() used by vector receive so that
> rearming the rx queue happens at the right time. Not doing so can in
> some cases result in the software inadvertently setting the card's rx
> tail pointer equal to the head pointer, which indicates that there are
> no descriptors available. This causes receive to stop indefinitely
> on that queue.
>
> Fixes: 01fa1d6215fa ("ixgbe: unify Rx setup")
>
> Signed-off-by: Eric Kinzie <ehkinzie@gmail.com>
[...]
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2261,6 +2261,10 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)
> rxq->nb_rx_hold = 0;
> rxq->pkt_first_seg = NULL;
> rxq->pkt_last_seg = NULL;
> +#ifdef RTE_IXGBE_INC_VECTOR
> + rxq->rxrearm_nb = 0;
> + rxq->rxrearm_start = 0;
> +#endif
A similar patch has been applied:
http://dpdk.org/browse/dpdk/commit/?id=48e967695ba78
Thanks
next prev parent reply other threads:[~2015-08-03 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 18:25 [dpdk-dev] [PATCH 0/2] ixgbe vector rx/tx changes Eric Kinzie
2015-06-25 18:25 ` [dpdk-dev] [PATCH 1/2] ixgbe: vector rx rearm after queue reset Eric Kinzie
2015-08-03 15:07 ` Thomas Monjalon [this message]
2015-06-25 18:25 ` [dpdk-dev] [PATCH 2/2] ixgbe: add memory barriers in vector rx/tx Eric Kinzie
2015-06-29 11:28 ` Ananyev, Konstantin
2015-08-03 15:08 ` Thomas Monjalon
2015-10-21 15:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3452808.fsduaX7ycr@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ehkinzie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).