From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D148642DF6; Fri, 7 Jul 2023 10:06:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA341406B5; Fri, 7 Jul 2023 10:06:05 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 4841340685 for ; Fri, 7 Jul 2023 10:06:05 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id ECE205C018E; Fri, 7 Jul 2023 04:06:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 07 Jul 2023 04:06:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688717164; x=1688803564; bh=gNjrJ59wcRvK9Kwpvm6PYTxUiYuQvGOzIHC MXGymxbU=; b=MLk3eqtKV9XuGXrwoopeTBgokF3K10Z/2njWNjpyEZkMf1aXTig ucktRemIG6RToUMmFfJuSrO1WD9GDqNzFiATcumLEURff1blDGfV8o9SiMzoSjNB J6YMzGZYP1dR5EA1bKxkzApTjI2aZXrWbXXAX//jmtASpeeF/syXtAJ3XXF9O/cC m4I3IitNIcsm8f9LQaF1IulQx1WsncraYuSe5jEbHh/CS6P6hO9KSrHnmGZvP0vy 1vDxSHOkIjXTrLWISIJA6ql0BfkGPrpr0Khf4kd9471htcAKqM5I6xlWEJbYOJDT Y/5VYrwf4xMGaY4Q5KVglFSiriYj0d31Irw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688717164; x=1688803564; bh=gNjrJ59wcRvK9Kwpvm6PYTxUiYuQvGOzIHC MXGymxbU=; b=gZAD2ce1uGpApw1U/k1Q75nkNEQJUW/nOoiz0cdzD3mygRvJWht 9nKLUEhJq/RCOqwzY4a0CeJTFpzCbDugK44ze6fg5MXSA0WbB2D7sDKduh3TJa7A XhDSsAlJ9ttOykyvyL82f0SW/3pxTWuLqhpdXavhtfGC/n7/+YauqNMAJJampwhb n21pOyI4aBsoPhMXC6/vIv0oMJtH4Mh6YPK7lxjR+RAKqIqmRDyuZy8pA9W3JOPB YePGgYYt6m+8UHWxg1KY93vFHkFD3Q2UqNWICcDnbPjbxIB/NsEdZeB9/+YbYHzB e5ZDZ8uAZcbiMdnaGQsJZGmZefxriA6GhWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvdduucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdeikefgkedu hedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Jul 2023 04:06:03 -0400 (EDT) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: Anup Prabhu , dev@dpdk.org, sshankarnara@marvell.com, ptakkar@marvell.com Subject: Re: [PATCH v6] app/mldev: add internal function for file read Date: Fri, 07 Jul 2023 10:06:02 +0200 Message-ID: <3453314.BEx9A2HvPv@thomas> In-Reply-To: <20230607172415.21945-1-syalavarthi@marvell.com> References: <20230323152801.27666-1-syalavarthi@marvell.com> <20230607172415.21945-1-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/06/2023 19:24, Srikanth Yalavarthi: > Added internal function to read model, input and reference > files with required error checks. This change fixes the > unchecked return value and improper use of negative value > issues reported by coverity scan for file read operations. > > Coverity issue: 383742, 383743 > Fixes: f6661e6d9a3a ("app/mldev: validate model operations") > Fixes: da6793390596 ("app/mldev: support inference validation") > > Signed-off-by: Srikanth Yalavarthi Applied, thanks.