From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0A02EA05D3 for <public@inbox.dpdk.org>; Wed, 22 May 2019 16:05:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDF3010BD; Wed, 22 May 2019 16:05:12 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AB4B6A69 for <dev@dpdk.org>; Wed, 22 May 2019 16:05:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E1DD224E0F; Wed, 22 May 2019 10:05:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 22 May 2019 10:05:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=8DtMbZbOfTosMRY3/arFJCaMI/UijwVflFYaM1MMwcY=; b=AHDNvwJVRjun 3m4UfizNxYbvawrrU7TpxNkiN+5MQDugmkiUL5AdNoYmGliO+uhPZ3qj1jY6/8kP ZUrwBzx9nF3LFXbu2kODAlra/yv6qQv2mwC4OjSierm653pommpJPunODBES2x/O 2EBS8+I/aJUaIX7Vahveo1qyD7p7Ibs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=8DtMbZbOfTosMRY3/arFJCaMI/UijwVflFYaM1MMw cY=; b=7wxPJjDQ9BOM8NbOAgSgkI3Nphl6yEekknndo8Imn6fPryybukZKHlulz HzUfSpTl3OKiCUhl9It9zH5VLZJ37rVTvkctWIPwt+ydUlKTpn6p638i8QA6bx9o zOtyrpcboLJkRaI/ekfEXZYyqdFYaA75tSLPK/ISMnQGvAIp8C9uGVcrbb1oXMxx F/ba4nsugAwggnRy6siZrGi5xRPYf0IOd1tMxdDyzt/wSaO1qJP5PFO6XPnKhiH0 xQt8hQ/DcfAWZiwsEUUegTRX643NEC3GjoW3EnbWZuKJsHBI+YAlWL6LE99sjZiT jqh94/UFQTQy3GXLMlx+sy3zqVQHA== X-ME-Sender: <xms:FFflXE4NQF2U1K7PyY-UPtZ9yczFo8P4tQ_CgtJknvcViH8CmjsOHA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudduvddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:FFflXFdVycfQbMweXpQkN_-S0xveKJQrAiBJ-DoJbzoROJRN8DWnqg> <xmx:FFflXJ7QGcEzFGKu_hSETrGPFOYvvK22JG7wzIw5T0aFL-XaTZxgmQ> <xmx:FFflXIuV30AxqjBUtk5Eqq638On2s_LThaxU-cYOZt7Evxfte3s2gQ> <xmx:FFflXGqf8vGPIg2dLXACyXmODmr2DdVyVwQxWwRhkHDvz9DosbNx4A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 33D7F8006B; Wed, 22 May 2019 10:05:07 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Cc: "Ergin, Mesut A" <mesut.a.ergin@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com> Date: Wed, 22 May 2019 16:05:04 +0200 Message-ID: <3457411.zOjnD88UkL@xps> In-Reply-To: <2601191342CEEE43887BDE71AB9772580161636EF4@irsmsx105.ger.corp.intel.com> References: <1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com> <3615B82CA151CF42A86EDDD9846A8B38C7A872FE@ORSMSX112.amr.corp.intel.com> <2601191342CEEE43887BDE71AB9772580161636EF4@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi, 22/05/2019 13:01, Ananyev, Konstantin: > > As far as I can see, passing FDIR configuration via the rte_eth_conf struct: > > struct rte_fdir_conf fdir_conf; /**< FDIR configuration. DEPRECATED */ > > was deprecated. I suspect in favor of the late binding design mentioned, but > > again, I don't know the history on that. IMO, this made devargs a better choice. > > Ok, then it looks like there is a flaw in ethdev level API that needs to be fixed: > We deprecated old way to request FD usage without introducing new one. > CC-ing to ethdev maintainers - > Guys is there a new way to request FD enablement, instead of deprecated fdir_config? > Seems like not, unless I missed something obvious. > If not, then we probably need either to re-deprecate fdir_config, or introduce some new method. > My first thought would be to add new DEV_RX_OFFLOAD_* flag(s). > Does it make sense? Sorry,I have not read the full thread so I may be out of topic. Please be aware that the flow director API is deprecated in favor of the more generic rte_flow API.