From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by dpdk.org (Postfix) with ESMTP id 82EB1AFD0
 for <dev@dpdk.org>; Fri, 13 Jun 2014 16:03:18 +0200 (CEST)
Received: from azsmga001.ch.intel.com ([10.2.17.19])
 by azsmga101.ch.intel.com with ESMTP; 13 Jun 2014 07:03:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,471,1400050800"; d="scan'208";a="445207214"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by azsmga001.ch.intel.com with ESMTP; 13 Jun 2014 07:03:27 -0700
Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by
 IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Fri, 13 Jun 2014 15:03:23 +0100
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by
 IRSMSX154.ger.corp.intel.com ([169.254.12.14]) with mapi id 14.03.0123.003;
 Fri, 13 Jun 2014 15:03:23 +0100
From: "Doherty, Declan" <declan.doherty@intel.com>
To: Eric Kinzie <ehkinzie@gmail.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/4] Link Bonding Library
Thread-Index: AQHPhCdZGNKbXYqU2EmTO27kHQR50ptvF5KQ
Date: Fri, 13 Jun 2014 14:03:22 +0000
Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC13D38C10@IRSMSX101.ger.corp.intel.com>
References: <cover.1401287412.git.declan.doherty@intel.com>
 <e6e8ecba5e2ba9d1a0e5299e042e7c54757e8644.1401891670.git.declan.doherty@intel.com>
 <20140609211054.GA4853@roosta.home>
In-Reply-To: <20140609211054.GA4853@roosta.home>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] Link Bonding Library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jun 2014 14:03:19 -0000

> -----Original Message-----
> From: Eric Kinzie [mailto:ehkinzie@gmail.com]
> Sent: Monday, June 9, 2014 10:11 PM
> To: Doherty, Declan
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] Link Bonding Library
>=20
> On Wed Jun 04 16:18:53 +0100 2014, Declan Doherty wrote:
> > - Broadcast TX burst broadcast bug fix
> > - Add/remove slave behavior fix
> > - Checkpatch fixes
>=20
> Declan, would you consider the following change to rte_bond.c?  The two
> header files from librte_cmdline don't seem to be necessary.
>=20
>  Eric
>=20
>=20
> --- a/lib/librte_bond/rte_bond.c
> +++ b/lib/librte_bond/rte_bond.c
> @@ -44,9 +44,6 @@
>  #include <rte_ip.h>
>  #include <rte_udp.h>
>=20
> -#include <cmdline_parse.h>
> -#include <cmdline_parse_etheraddr.h>
> -
>  #include "rte_bond.h"
>=20
>  static const char *driver_name =3D "Link Bonding PMD";

Hi Eric,=20
I've cleaned up the includes in v3 of the patch, but the those headers are =
now actually required for the kvarg parsing.

Regards
Declan