From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 6AF13C7DA
 for <dev@dpdk.org>; Fri, 26 Jun 2015 09:33:06 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 26 Jun 2015 00:33:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,683,1427785200"; d="scan'208";a="718009020"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by orsmga001.jf.intel.com with ESMTP; 26 Jun 2015 00:33:05 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.245]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.90]) with mapi id 14.03.0224.002;
 Fri, 26 Jun 2015 08:33:03 +0100
From: "Doherty, Declan" <declan.doherty@intel.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
Thread-Index: AQHQrlsbuZiPgr9JI0G+dVCm5bMQO52+ZhRA
Date: Fri, 26 Jun 2015 07:33:03 +0000
Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC27F26410@irsmsx105.ger.corp.intel.com>
References: <1435135845-7060-1-git-send-email-tomaszx.kulasek@intel.com>
In-Reply-To: <1435135845-7060-1-git-send-email-tomaszx.kulasek@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Jun 2015 07:33:07 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Wednesday, June 24, 2015 1:51 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
>=20
> On Fortville NIC, link status change interrupt callback is not executed w=
hen
> slave in bonding is (re-)started. It causes that slave's NIC is inactive =
even
> if its link status is up on the start.
>=20
> This patch invokes lsc callback, just after port's start, to check its in=
itial
> link status and manage properly.
>=20
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_pmd.c |    5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 8bad2e1..277b310 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1357,6 +1357,11 @@ slave_configure(struct rte_eth_dev
> *bonded_eth_dev,
>  		return -1;
>  	}
>=20
> +	/* If lsc interrupt is set, check initial slave's link status */
> +	if (slave_eth_dev->driver->pci_drv.drv_flags & RTE_PCI_DRV_INTR_LSC)
> +		bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id,
> +				RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev-
> >data->port_id);
> +
>  	return 0;
>  }
>=20
> --
> 1.7.9.5

Acked-by : Declan Doherty <declan.doherty@intel.com>