From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 93E47922C for ; Thu, 26 Nov 2015 14:51:33 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 26 Nov 2015 05:51:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,347,1444719600"; d="scan'208";a="2654052" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga004.fm.intel.com with ESMTP; 26 Nov 2015 05:51:18 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.203]) by IRSMSX108.ger.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0248.002; Thu, 26 Nov 2015 13:51:17 +0000 From: "Doherty, Declan" To: Thomas Monjalon , Panu Matilainen Thread-Topic: [dpdk-dev] [PATCH] cryptodev: mark experimental state Thread-Index: AQHRJ6iGmMjQ4iV9y0GfJQXG1QDFKZ6t68GAgAAF3oCAACPvAIAAOkIw Date: Thu, 26 Nov 2015 13:51:16 +0000 Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC2809A787@irsmsx105.ger.corp.intel.com> References: <1448473135-19604-1-git-send-email-thomas.monjalon@6wind.com> <5656B71D.7030704@redhat.com> <5656BC09.20307@redhat.com> <34498752.nGP1cUxCqE@xps13> In-Reply-To: <34498752.nGP1cUxCqE@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2015 13:51:34 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 26, 2015 10:09 AM > To: Panu Matilainen; Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state >=20 > 2015-11-26 10:00, Panu Matilainen: > > On 11/26/2015 09:39 AM, Panu Matilainen wrote: > > > On 11/25/2015 07:38 PM, Thomas Monjalon wrote: > > >> --- a/config/common_linuxapp > > >> +++ b/config/common_linuxapp > > >> @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=3Dy > > >> > > >> # > > >> # Compile generic crypto device library > > >> +# EXPERIMENTAL: API may change without prior notice > > >> # > > >> CONFIG_RTE_LIBRTE_CRYPTODEV=3Dy > > >> CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=3Dn > > > [...] > > > > > > I think an experimental library which declares itself exempt from the > > > ABI policy should not be compiled by default. That way anybody wantin= g > > > to try it out will be forced to notice the experimental status. > > > > > > More generally / longer term, perhaps there should be a > > > CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and > > > defaults to off. > > > > On a related note, librte_mbuf_offload cannot be built if > > CONFIG_RTE_LIBRTE_CRYPTODEV is disabled. Which seems to suggest its (at > > least currently) so tightly couple to cryptodev that perhaps it too > > should be marked experimental and default to off. >=20 > I think you are right. > Declan, what is your opinion? Hey Thomas, yes librte_mbuf_offload should also be set as experimental, it'= s=20 probably one of the areas which will most likely change in the future. =20 On the issue of turning off experimental libraries in the build by default,= my preference would be not to turn them off unless the library has external dependencies, otherwise the possibility of patches being submitted which=20 could break an experimental library will be much higher. In my opinion the fewer build configurations developers have to test against the better.