From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0058.outbound.protection.outlook.com [104.47.32.58]) by dpdk.org (Postfix) with ESMTP id 17942DE0 for ; Tue, 19 Sep 2017 19:29:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=A1Xqz5bNyCc7Pd5kqFws7FS1Zq4y9yRDOy9Z7HVSb24=; b=idrwZkQEaZIssZ+9OkBA46tLmBiU9rhcoZ/N/Tt6mJ1rL3Pp6swEBv0sRrCJiIL2Wl4QzBr1G++GQ6W04b487BABGryUngeioEAmm24+rDteVF8Y5KRx79Lpmt01g26+nmGa0ARCCT6L9/T8jcjJXyxvm/b/ZqDkNkoiMo9KGyY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.89.1.20] (14.140.2.178) by CY4PR07MB3096.namprd07.prod.outlook.com (10.172.115.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 17:29:36 +0000 To: "Burakov, Anatoly" , dev@dpdk.org References: <20170831032618.7120-1-santosh.shukla@caviumnetworks.com> <20170918104234.9149-1-santosh.shukla@caviumnetworks.com> <20170918104234.9149-3-santosh.shukla@caviumnetworks.com> <92424c77-29d5-4e4e-7f53-22c015d24fb3@intel.com> From: santosh Message-ID: <345a32cc-7a22-ea86-78f9-131404a2642b@caviumnetworks.com> Date: Tue, 19 Sep 2017 22:59:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <92424c77-29d5-4e4e-7f53-22c015d24fb3@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: DM5PR13CA0037.namprd13.prod.outlook.com (10.168.240.151) To CY4PR07MB3096.namprd07.prod.outlook.com (10.172.115.10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec2f4ffe-bbe0-4193-169a-08d4ff8400b4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3096; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 3:2vGdwRZiggJz94xe+WHu6+qpo5BoYOXVLFdPW9KwFxoxaxqjtRoDdGTFON3p0XVEDsOzbCOmhORIfnQYEKe8Et6sG0XXBcIKl0GFZyvlJWuCRf7jnUW0joqZPRdL9gU/H7fzOJ8CV0E862jk9lGavmB8PV1MKhLYRTdaDfbX30sqMuVjgXqjWHOyzFJYuyQvxMlKowAHhmsgNmFsiOoaUy0HO48gabfELT+H1GOb+24ThHeumoiCfEdXPcjtC7pL; 25:gZwsOSmm6yIEOjFuUhsR0KJJ2I0k+3tl7M4jvouqgMnz7CU0Zb3liBtKfeFbWVPzFf4euLp/ZvpFFsMrC27vy/M/jDXXqhjY4VJEV/OARxWpa0llzc4hWCQgDhVqmfTUz51OmOvzKBPs5cfzihKO19VJm8uguYI31f1TrjuIgxiIsnK5YbCCeVG9ihXOCArQoFICEhh9nekqiw5QHsKmtYokhDXt4oxrwni8v2YC+vLbVxon7WxAVA7bUHmgfYRLf4ajZiiO+ZHoXpcqo4RLVlTJ/RbbOj5a4GLuI+R20XcxpOoKQ+Gr8oUxBEmXOOTANdFMVk+3jzIy/EDfLsJW7w==; 31:QEiAUClbTZDgZS+4SzHytsm4K3tTX6Xmu4MY6EamEOd7V2MkoBB+TQIRGI59+3j916tzz/EEVIqZFGdVhbeWdzIYVhOC2wpmFVvC+YpPjJzNQwvS5QJIcoa8oxgpZw/gzi79iYCOg9PyI+omPrRR9x3IX8Ob5IiLwGrKakvxYLUVTb0QzYeGQbAzet4LNT1lFdHmSWgpE3q6ZhpKF4usoypT9avEfG0jpDTWacJGfu0= X-MS-TrafficTypeDiagnostic: CY4PR07MB3096: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 20:iLYwiBB37fHmSrIuLumuUKK7S+Qe7YPXAhgztpspFBO9yy4crBb0oqDkt4d6FngGtp/S2IOJ3v9RR9X3WpclKJJ182AzgXhSuGVLCTbrR5DI3jrKIurmA2pi3Hpbap/V1uOlTqKs2b3JS3XDqPz28JXW/VWIAVYw4o+P9XHzxVAXs3ylHD0gsvKGALoktqWRf16kkWiW53BWCSOBnbxJ8g11PFqYzzOxOT/p5ExxJYSqkOmFXx5NV/EMQZGfqbdRgfh3jq4dtqcnMyZOS+V8iMsV59MLxVkM4csYamW8bbyWImP+tQiVhReCOG7NqS0qbCHkOpx4ft1Hso0VI0fXIj/HPL7ih0gChYvJZ0pPAAeGeyAu3BA0rfN0KjsWjMaaHyTzUd3gCKo58hn88GITo+mjU4JSylBcqOayTYjn/0k6yfXptAqMvFPeXsHlVpsowXdUbfOU/ofPfcsTcn7IRak2dAqLlFxf3ZvSWfBumfEKk7540OHRvhZaAE8OeiksaF5EpWvMIMcxfWjuZiRapae3Sm2tYmP3lBNG/Hxo/NGXwznrzyEkxv2htoB3A1BSdw9i4yw58sneon+X8c7PX+L4/z3CmZujHArMCCKOWFg=; 4:Kljm7jrQtCAEbJ2A3m3G0l4ZM8fUvC/rD5pSAYjSk9zwwf7wv1EO4BgSUgy7KwL1jvZ3RePwhp3YwO6QMAVjL+7WYyvUCxWJVg7Bu1h0j+PaUC6wbpsCMKL5L1IDqwAQ6YaHd5Tf9h0+uMnGeivpSrnHMSlh85Y2auPfa3a35Y9zL52VOjOgT2eqNgWoYdKTQPO/NpphSQ3Ex7hpYzHrT9rOLXOKe9OSFUhPwLx3oGqmGa7ilGl0sDenngWAM4bE8nclmpCQmEUeZCy2HkHdwsWLorFrd0G3MJHpVo4h6Lw= X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3096; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3096; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(346002)(189002)(24454002)(199003)(377454003)(65806001)(65956001)(66066001)(86152003)(6486002)(6116002)(25786009)(189998001)(77096006)(93886005)(53546010)(47776003)(229853002)(36756003)(3846002)(90366009)(97736004)(6666003)(58126008)(2950100002)(83506001)(7736002)(31696002)(305945005)(42882006)(316002)(64126003)(230700001)(50466002)(5009440100003)(16526017)(16576012)(65826007)(68736007)(8936002)(50986999)(76176999)(54356999)(5660300001)(72206003)(478600001)(2906002)(33646002)(105586002)(8676002)(81156014)(81166006)(106356001)(6246003)(53936002)(31686004)(101416001)(23676002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3096; H:[10.89.1.20]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA3TUIzMDk2OzIzOm1UOHE3Z1NJSDVRQXB4RXVPL0NxMDgyK0pZ?= =?utf-8?B?cXdrV2d6MDhjYnpHNXVmZ241dkkzbEVLL1k3blpHVEtrTzNkWUxXNGNIeURO?= =?utf-8?B?OEkwT1h4TzFXSWg3aXpQTHBqRFViZXZvYVVlc2NnN1JtWGs1Ujh1NVBPMWRi?= =?utf-8?B?RXFVT2QyUVZ2ZWgyYVhoZThSalU4NzcwMGtUTzRIQlQxSnppNGoyaDZBQjZr?= =?utf-8?B?bEptM212V2Q3SmJYOHBKVDlnL0dqSFB4R2gvZ2l5YVVHTjZyTjMzWUVDVCtz?= =?utf-8?B?M1AzYysxMG1rZGQ4VE13aHJVakhNbDBxNzhNbjNHcmQvWGc5TENrbmN2UjRN?= =?utf-8?B?Rmg1aXNuUHczanVyOExHVHpraldBQ0loQXhXY0RETnZLK01XcHQxSzFqV3RU?= =?utf-8?B?NWpRaHFqUWhoWGliQkRhbTh5K1hGUDVFdDFCVUtPTVZvcGk5WlpaaENHOHk3?= =?utf-8?B?b2JBV3pVSE11TjYwVUx1NmFGbWNyZy9UcUxPTlJEMmtZN0s4bzhBY29SaGZx?= =?utf-8?B?TlNESGxZRG9uUDI3ZnBiWlpnMlZnMTZoVFp0aElzTUVHaGlLT3BSNzk2WVdm?= =?utf-8?B?SGVyaEI0L3djWlRkemo2bWVXM1JxT1lPNzVOTWNGcmNDY0dnQTNCU0tKVlRk?= =?utf-8?B?L1c4K2lSMHBOZE5RYmh1dnFFVmYrRmlMZjVUR2U4SDV1eEY1aytwdGhHc3F4?= =?utf-8?B?by9vT1d0anlHS2l5WmNUWXgrYTU2Z3lLdUFhQ1RlY1c4STRpNzV5Vmd0UDl4?= =?utf-8?B?endhcnRyZUNya2RGMU1ncWlaU3hydjk2RU9RQ0IwVzhadlZnTWUrSWMxN0hE?= =?utf-8?B?SlJJYUJvZmh4ZkEzaUxPc1M1dnJMRFgzY0tmNzhWak96UkUwVGdjbnhFUGJw?= =?utf-8?B?QXNPS2Vyd1ZxOTBTZmttNXR5alRwTUsyM0tOWnZxZGEyNjl2b0xyWmZkVEIr?= =?utf-8?B?MWxUdG5EaVgrODN0K0hjM0cyRndBY0VjcEFrZlc0YkZlZGhqb0p4UC9zdHJa?= =?utf-8?B?RExxclZaOW5vZHNYcENRQ0k4OHhvM2o5QlRZMkVIdjNuUmFsTmtCdXJ6bVpO?= =?utf-8?B?M25FNjd4ZGI0SUc1dFRGUUk5blVDYmhTc1Z3YWl5bFlkc0pORjFUdjhPcFc3?= =?utf-8?B?UnlYU0NwRHhPUDI5SnhIcGVseVEvd0Q4VS9vczFsS0dBV1JGYVZScGlraVov?= =?utf-8?B?K0dCcWt4Nk1UY05MZTc1VlBoMFVNVytrRzRFRHZUVnNrK2twZmJxUjBLM1RS?= =?utf-8?B?a080M3oyRlh5bzBuWjNFVUtSQ0F1TW1LS01wY1VWelVCWm4vUEUyckpiM3Zi?= =?utf-8?B?dWUwejZ2NVMrMG1ORVFYL0w2ZUtNdHg4SnY0M0VEWVRCcWc2Rzh4SUttZU1Z?= =?utf-8?B?R2diVFVxalNrUkM5VEV6eUxqVkdaY0FrTEZxSFBZMGNHd3VBVUxLNkErM3Nu?= =?utf-8?B?K0oycW9kK2pFV1ZMSE1lUFV3VnJIOWpGem1hcGhpK2MxazNOVWNnUU5zS3My?= =?utf-8?B?K0xXWUZab1M1NE9WZFUwN1BLcnplUVNpY2hUWm5TOGhjZUtid3hnVkNrdlhh?= =?utf-8?B?ZWk3Rzg4bGxnZVdUaWhoQ0w2bGd3Q3IwTWxWejlLQ1BmUFVqaGhtQ09tZndx?= =?utf-8?B?WjVacUdtSGlpaklON2JhYllqMytnekFIQXRTUnI2bFdsSitPeTFjQmlRUG1n?= =?utf-8?B?MmJEQ3VERHVteCs4RlJNQkVTWFpHNE1XR3pQcU9lcDFDR2N3YmxlM09NM3VU?= =?utf-8?B?N205SFAvZktuWHdML3FhSXZ0NndFN2RjaFZQVHdwWFlTK0tXSlVGM3JaenNE?= =?utf-8?B?TUQyMWRvR1ZNQU1tRkM3S1hRZlEzZXhMWmN5amdraWJCNElYVE90d1VTcmNv?= =?utf-8?B?NHVSU1VIU2RHLzFXbkRpbUdvTXh4Y1J6bXFUKzR2NnZxTVJtNlB1TzVFOVdK?= =?utf-8?Q?YUomv+CMgCQRtyDLWAn1OZUmgZObD0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3096; 6:bJL6MXuqSNSm/hB3QWKQTKYJz3gn8ehYzcCF7xY4233CpaAZGDo38XWjrVReNZynF1AtuirCpdDaMJBqSahtAtMlDIzfZMtmCALcCEALoh+vgYpqlzL2Gb0dt971RHWg3SbKgKEGrnjwbhJY6XhIyM3IGyvaPBUfQeNOCmMKrO6EG/FgmyhQpjvaDjliuItgwu4OJIBKIpLXUV+YYfH+sCn2uxf/scut16IrA3qeidM6XPzodmrv1Su99SQKBjy7kZw6hEwws7VDSL8RWAfIY0dztSWLqvXnNHrI8XVi2MbOiUZbj6GU6Ce1A79YFVvrjOLHF+O1TaPmHhBOFCH0+w==; 5:7GQhy0x/7A0XYjPxTOBWQk3pDVmr9/JJ1cmZZbZAmSBl2v4DFxgP0Q0OOe8CQnysoF8W+z+QFzQ8RR5rx/FMTpNbRajIRu11/Ybz/KCKpeycgWebOf/8tMrt0D+vIgMwx6pyWTgqQYPN5kb73J6Txw==; 24:niVDOfp+Xc6qKv2KAW26UC4+hmdjtDleJnzygac4no1Z6QylrmNABcqUpI8iuMdfKzoXwawoOy7RfWvYKDy7jrhsE/8Ghga2YEA5lP8eyKE=; 7:Q5Cfj6U9hQpojkSlmGylQQKM21lRBCKRaeuMHYCB78HNQ4Xu4hYLXirqBR+Qw0AF2uYIdwQgP32W/7uCOElKsRNw5bXQEsyKiU4CKDK3FfKXMpxnbUWn1pXEUldOxWrpr/5ltu7t1zsZA+/ZTtluZnGG+TOzhPY32ThrgJCMTzbLeBmz+HyBbU5JvuqB8YQa/cQJTPQYP/f8BKST10vQ+RlSMnT1TEthfytYXW1o5Zs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 17:29:36.5994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3096 Subject: Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 17:29:40 -0000 Hi Anatoly, On Tuesday 19 September 2017 10:07 PM, Burakov, Anatoly wrote: > On 18-Sep-17 11:42 AM, Santosh Shukla wrote: >> Introducing rte_pci_get_iommu_class API which helps to get iommu class >> of PCI device on the bus and returns preferred iova mapping mode for >> PCI bus. >> >> Patch also add rte_pci_get_iommu_class definition for bsdapp, >> in bsdapp case - api returns default iova mode. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Jerin Jacob >> Reviewed-by: Maxime Coquelin >> --- > > Hi Santosh, > > You have probably missed my comment on previous version of this patch, but for commit history reasons i really think you should add a linuxapp stub in this commit as well as a FreeBSD stub, even though you are adding a linuxapp function in the next commit. Any linuxapp application using that function will fail to compile with this commit, despite this API being already present and declared as public. > First, apologies for not following up on your note: I prefer to keep less context in each patch and for [03/9], its already has _IOVA_AS_VA flag + whole autodetection algo inside (squashed per Aron suggestion). Now if I squash [2/9] into [3/9], then would be too much info for future reader to digest for (imo). Its a kind of trade-off. On any linuxapp appl breaking with this commit: This series exposes eal api for application to use and identify iova mode. If you still feel not convinced with my explanation then I'll spin v9 and squash [02/09], [03/09] in v9. Thanks.