From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>, dpdk stable <stable@dpdk.org>
Cc: dev@dpdk.org, pezhang@redhat.com, siliu@redhat.com,
fengqinx.wang@intel.com, zhaoyan.chen@intel.com,
qian.q.xu@intel.com, alialnu@mellanox.com, rasland@mellanox.com
Subject: Re: [dpdk-dev] [dpdk-stable] 17.11.7-rc1 (LTS) patches review and test
Date: Thu, 29 Aug 2019 17:10:53 +0100 [thread overview]
Message-ID: <345a5ceb-0dde-bb3b-884f-43b4755da107@intel.com> (raw)
In-Reply-To: <20190815180508.14043-1-yskoh@mellanox.com>
On 8/15/2019 7:05 PM, Yongseok Koh wrote:
> Hi all,
>
> Here is a list of patches targeted for LTS release 17.11.7. Please help review
> and test. The planned date for the final release is Aug 23, Before that, please
> shout if anyone has objections with these patches being applied.
>
> Also for the companies committed to running regression tests, please run the
> tests and report any issue before the release date.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1
>
> These patches are located at branch 17.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
I am getting build error [1] with Fedora 30 and gcc [2], the issue seems fixed
in the main repo [3].
[1] [-Werror=address-of-packed-member]
.../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_lookup’:
.../lib/librte_eal/common/eal_common_tailqs.c:76:11: error: taking address of
packed member of ‘struct rte_mem_config’ may result in an unaligned pointer
value [-Werror=address-of-packed-member]
76 | return &mcfg->tailq_head[i];
| ^~~~~~~~~~~~~~~~~~~~
.../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_dump_tailq’:
.../lib/librte_eal/common/eal_common_tailqs.c:90:23: error: taking address of
packed member of ‘struct rte_mem_config’ may result in an unaligned pointer
value [-Werror=address-of-packed-member]
90 | rte_rwlock_read_lock(&mcfg->qlock);
| ^~~~~~~~~~~~
.../lib/librte_eal/common/eal_common_tailqs.c:92:40: error: taking address of
packed member of ‘struct rte_mem_config’ may result in an unaligned pointer
value [-Werror=address-of-packed-member]
92 | const struct rte_tailq_head *tailq = &mcfg->tailq_head[i];
| ^~~~~~~~~~~~~~~~~~~~
.../lib/librte_eal/common/eal_common_tailqs.c:98:25: error: taking address of
packed member of ‘struct rte_mem_config’ may result in an unaligned pointer
value [-Werror=address-of-packed-member]
98 | rte_rwlock_read_unlock(&mcfg->qlock);
| ^~~~~~~~~~~~
.../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_create’:
.../lib/librte_eal/common/eal_common_tailqs.c:111:10: error: taking address of
packed member of ‘struct rte_mem_config’ may result in an unaligned pointer
value [-Werror=address-of-packed-member]
111 | head = &mcfg->tailq_head[rte_tailqs_count];
|
[2]
$ lsb_release -a
LSB Version: :core-4.1-amd64:core-4.1-noarch
Distributor ID: Fedora
Description: Fedora release 30 (Thirty)
Release: 30
Codename: Thirty
$ gcc --version
gcc (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1)
[3]
Fixes: a385972c3675 ("mk: disable warning for packed member pointer")
next prev parent reply other threads:[~2019-08-29 16:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:05 [dpdk-dev] " Yongseok Koh
2019-08-19 6:37 ` Pei Zhang
2019-08-25 10:30 ` Ali Alnubani
2019-08-29 16:10 ` Ferruh Yigit [this message]
[not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA95BA@SHSMSX101.ccr.corp.intel.com>
2019-08-30 12:58 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
[not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA8312@SHSMSX101.ccr.corp.intel.com>
[not found] ` <FD56CD4A6C7E9841B5CD62946D45F34C01B18CF1@SHSMSX104.ccr.corp.intel.com>
2019-09-12 8:52 ` [dpdk-dev] FW: " Peng, Yuan
2019-09-17 9:53 ` Luca Boccassi
2019-09-18 9:17 ` Luca Boccassi
2019-09-18 10:03 ` Yu, PingX
2019-09-24 11:07 ` Luca Boccassi
2019-09-24 16:36 ` Ferruh Yigit
2019-09-24 17:15 ` Kevin Traynor
2019-09-24 17:25 ` Luca Boccassi
2019-09-24 20:08 ` Luca Boccassi
2019-09-26 7:34 ` Yu, PingX
2019-09-26 7:38 ` Ferruh Yigit
2019-09-26 8:15 ` Yu, PingX
2019-09-26 8:19 ` Luca Boccassi
2019-09-12 8:59 ` [dpdk-dev] " Peng, Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345a5ceb-0dde-bb3b-884f-43b4755da107@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=fengqinx.wang@intel.com \
--cc=pezhang@redhat.com \
--cc=qian.q.xu@intel.com \
--cc=rasland@mellanox.com \
--cc=siliu@redhat.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
--cc=zhaoyan.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).