From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 00ED568C3
 for <dev@dpdk.org>; Wed, 28 May 2014 13:24:46 +0200 (CEST)
Received: by mail-wi0-f179.google.com with SMTP id bs8so3463827wib.6
 for <dev@dpdk.org>; Wed, 28 May 2014 04:24:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=/Y8FpXjtcxNalblw1pbJ6+3tgWPRcheQwNDB8ESg3AU=;
 b=UYt70dd4//xxHIZ9g56TyeBUacgA2WLfuWA/DzTBSa6sa0nPg04AnnJ+j/RFBAQihB
 8jBLKwoRQZ85XV9D8mcUhkBPweS9YV691fEpAhOkZdaLnJ29g8dmsIwJu40891IZnTp3
 oCONU8WebOu8hpn1gmZaRMB3j9NAB07JxBw5nZ/TodIv9qM0WStjNhxkOp23ED9yhHrO
 WLcw3opxZmxZO7pF+E9e1lAtvyL64XSpsR5ukcVD8wFayQiixS5qUYXpspFNeNedQTbP
 RZjNtYxmMGOQncBZOE8nKPnpDHDidJbtgJ+6ZiKuheCCsNqoBvj2Mt6l2Oit18wnyvp0
 z31g==
X-Gm-Message-State: ALoCoQkT37jSHtIsSr9k8Ds9AtvkK5Y806eUSwzeDp5zNxdezJC4yOrzcnBYqCXxCT7Z+IB9HBgD
X-Received: by 10.180.183.131 with SMTP id em3mr47463912wic.56.1401276296232; 
 Wed, 28 May 2014 04:24:56 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id ds6sm34263574wjd.38.2014.05.28.04.24.54
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 28 May 2014 04:24:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Date: Wed, 28 May 2014 13:24:51 +0200
Message-ID: <3463654.chnlgr18TH@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236976CC958D3@IRSMSX101.ger.corp.intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <1589072.KAuytnYNqt@xps13>
 <C6ECDF3AB251BE4894318F4E451236976CC958D3@IRSMSX101.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO
	interrupt type from EAL command-line
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2014 11:24:47 -0000

2014-05-28 10:35, Burakov, Anatoly:
> Hi Thomas,
> 
> > > +			}
> > > 
> > >  			else if (!strcmp(lgopts[option_index].name,
> > 
> > OPT_CREATE_UIO_DEV))
> > 
> > another code style issue reported by checkpatch.pl ;)
> > 
> > But it should be fixed by removing this code as Stephen suggests.
> 
> I'm not sure this could should be removed. Igb_uio allows to pick interrupt
> mode, so why not VFIO? I've modified my code to try all interrupt modes if
> nothing was explicitly specified, but why should that preclude the user
> from selecting a specific interrupt type if he so desires?
> 
> As for the style error - the whole chunk of code uses the same style there,
> so either we fix all of that (in a separate patch?), or leave it as it is.

OK to leave it as is.

But please, let's try to keep a clean code style.
About existing code style issues, separated patches for cleaning should be 
well accepted.

Thanks
-- 
Thomas