From: Thomas Monjalon <thomas@monjalon.net>
To: Shani Peretz <shperetz@nvidia.com>
Cc: dev@dpdk.org, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
Ori Kam <orika@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] examples/flow_filtering: fix destination IP mask
Date: Wed, 19 Mar 2025 04:13:40 +0100 [thread overview]
Message-ID: <3464272.K4a6FZZPjd@thomas> (raw)
In-Reply-To: <SA1PR12MB9491739955B431A33FB2EFC7BFD62@SA1PR12MB9491.namprd12.prod.outlook.com>
10/03/2025 07:48, Shani Peretz:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 12/01/2025 08:52, Shani Peretz:
> > > This patch corrects the destination IP address mask to restore the
> > > previous implementation's behavior.
> > >
> > > Also it fixes a misuse of rte_flow_item_tcp struct.
> > > Replace it with the appropriate rte_flow_item_ipv4 struct, as the code
> > > in this context filters ipv4 traffic.
> > >
> > > Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases
> > > snippets")
> > >
> > > Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> > [...]
> > > @@ -77,7 +77,7 @@ snippet_ipv4_flow_create_actions_template(uint16_t
> > port_id, struct rte_flow_erro
> > > };
> > >
> > > tactions[0].type = RTE_FLOW_ACTION_TYPE_QUEUE;
> > > - tactions[0].type = RTE_FLOW_ACTION_TYPE_END;
> > > + tactions[1].type = RTE_FLOW_ACTION_TYPE_END;
> >
> > It is a revert of this recent commit:
> > https://git.dpdk.org/dpdk/commit/?id=7d73fa47f4
> >
> > Do you confirm you want to keep RTE_FLOW_ACTION_TYPE_QUEUE here?
> >
>
> Yes to be consistent with the non-template API.
Applied, thanks.
prev parent reply other threads:[~2025-03-19 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 7:52 Shani Peretz
2025-02-19 15:19 ` Thomas Monjalon
2025-03-10 6:48 ` Shani Peretz
2025-03-19 3:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3464272.K4a6FZZPjd@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=orika@nvidia.com \
--cc=shperetz@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).