From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40B2442C40; Tue, 6 Jun 2023 15:00:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C718E40697; Tue, 6 Jun 2023 15:00:15 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id E427A40223 for ; Tue, 6 Jun 2023 15:00:13 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5EC8F5C00DA; Tue, 6 Jun 2023 09:00:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 06 Jun 2023 09:00:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686056411; x=1686142811; bh=L3prirT7AuBcqv+gaI5LIf7ZhQcPiTkJQs+ WDJ4UhOA=; b=JrAqP3ypriEV32WOUfDIl6xim8A7e7iCiUlCL+i8spyHwNO/R23 zwIGid3RIDza4+u8n3NbB4/CLRZsMAypJf81f4YHbFCbS7BSr6/cVIQDglyYaciL qNxvyjrtbQHjuql94B0yH7XQR8p5JXZDrqOCYvjtmembWg4T7fWOqZDcCI9fn45A lH2BOoD3y/PD+qSoqscsTK24EJPVuYzybmypAYjPX5a++jR2aiuv3G0iE7bDeUBF +sR67QtWwroVx9sifGSm/momWWCnfBzQ3co3W4ynZNrgFAIqMPdsq6n+AhIf/Wr2 25nSiYB6Rrl8khofQTpbpD3fwa6n7sq7gXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686056411; x=1686142811; bh=L3prirT7AuBcqv+gaI5LIf7ZhQcPiTkJQs+ WDJ4UhOA=; b=eVeS+OEpcK3utJU9JjCwIOzRHuhTDEQUTqMYNEVbJn0DFVTSSUg +Nodp3agkGa8tBeqV4AYmJvontZ0+iBODEedlZgTzL5pBkzaTa1HxAa+V9If8IJX WJEtjGTg6uLTau/znCi5B3tWYx/l/4oT2+n1Bxp0QOH24tyGLfgt9zKEHAx3jPpO Arvtydtcz6rRMdolBPPjpOWh7GodwaMIDGuHOx5gjEWBZfifFC+mHu5oyq4Zy2h3 j/mipsVep8WdmOsOGXIhNbNypdMnpL7BL97Z4fKlZEQVrAEHjypwxoZlAR+g2Z8b LiHFjO+G5yCA7QbwH7kl5spMk9XhyV5sr4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtuddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jun 2023 09:00:09 -0400 (EDT) From: Thomas Monjalon To: Nipun Gupta , Nipun Gupta Cc: dev@dpdk.org, david.marchand@redhat.com, hkalra@marvell.com, anatoly.burakov@intel.com, stephen@networkplumber.org, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com Subject: Re: [PATCH v7 1/4] bus/cdx: introduce AMD CDX bus Date: Tue, 06 Jun 2023 15:00:06 +0200 Message-ID: <3464713.L4jQFfv3LO@thomas> In-Reply-To: <20230606100258.26532-2-nipun.gupta@amd.com> References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230606100258.26532-1-nipun.gupta@amd.com> <20230606100258.26532-2-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/06/2023 12:02, Nipun Gupta: > +/* Forward declarations */ > +struct rte_cdx_device; > +struct rte_cdx_driver; > +struct rte_cdx_bus; You should be very careful about what you export. > + > +#define CDX_BUS_DEVICES_PATH "/sys/bus/cdx/devices" This define is not needed in the .h file. > + > +#define CDX_MAX_RESOURCE 4 This size looks required for rte_cdx_device, but as an exported constant, it should be prefixed with RTE_ > + > +/** Any CDX device identifier (vendor, device). */ > +#define RTE_CDX_ANY_ID (0xffff)