DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: fengchengwen <fengchengwen@huawei.com>
Cc: david.marchand@redhat.com, dev@dpdk.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 0/6] refine argparse library
Date: Fri, 18 Oct 2024 16:46:20 +0200	[thread overview]
Message-ID: <3466447.9LS3J3VOpE@thomas> (raw)
In-Reply-To: <5566b273-5c42-4d11-968c-b52648ff4732@huawei.com>

18/10/2024 03:09, fengchengwen:
> Hi Thomas and David,
> 
> This patchset was already acked by Stephen.
> It missed in DPDK 24.07, hope merge in 24.11.
> 
> Thanks
> 
> On 2024/10/10 9:35, fengchengwen wrote:
> > Hi Thomas and David,
> > 
> > Kindly ping for merge.
> > 
> > On 2024/10/10 3:33, Stephen Hemminger wrote:
> >> On Mon, 18 Mar 2024 11:18:32 +0000
> >> Chengwen Feng <fengchengwen@huawei.com> wrote:
> >>
> >>> I found a couple of issues when I revisited the argparse_autotest
> >>> output, so got this patchset.
> >>>
> >>> Chengwen Feng (6):
> >>>   argparse: refine error message
> >>>   argparse: remove dead code
> >>>   argparse: replace flag enum with marco
> >>>   argparse: fix argument flags operate as uint32 type
> >>>   test/argparse: refine testcases
> >>>   argparse: fix doc don't display two hyphens
> >>>
> >>> ---
> >>> v4: address Thomas's comment on 4/6 commit:
> >>> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and
> >>>   TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK.
> >>> v3:
> >>> - address Thomas's comment on 4/6 comit.
> >>> - add commit: fix doc don't display two hyphens.
> >>> v2: address David Marchand's comment:
> >>> - replace flag enum with marco.
> >>> - replace flag's hardcode with macro in test_argparse.c.
> >>>
> >>>  app/test/test_argparse.c               | 65 +++++++++++---------
> >>>  doc/guides/prog_guide/argparse_lib.rst | 47 +++++++-------
> >>>  lib/argparse/rte_argparse.c            | 61 +++++++++---------
> >>>  lib/argparse/rte_argparse.h            | 85 ++++++++++++--------------
> >>>  4 files changed, 127 insertions(+), 131 deletions(-)
> >>
> >> The verb refine is not usually used for edits to documents or software
> >> that probably is a translation issue.
> >>
> >> Series-acked-by: Stephen Hemminger <stephen@networkplumber.org>
> > 
> > Thank Stephen

Added Bugzilla ID, CC: stable, reworded as Stephen suggests,
and applied.

Note that the lists in doxygen comments does not look nice.
You may look at this: https://www.doxygen.nl/manual/lists.html



      reply	other threads:[~2024-10-18 14:46 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 13:14 [PATCH 0/4] " Chengwen Feng
2024-02-20 13:14 ` [PATCH 1/4] argparse: refine error message Chengwen Feng
2024-02-20 13:15 ` [PATCH 2/4] argparse: remove dead code Chengwen Feng
2024-02-20 13:15 ` [PATCH 3/4] argparse: fix argument flags operate as uint32 type Chengwen Feng
2024-03-06 17:34   ` David Marchand
2024-03-07 13:14     ` fengchengwen
2024-02-20 13:15 ` [PATCH 4/4] test/argparse: refine testcases Chengwen Feng
2024-03-07 13:07 ` [PATCH v2 0/5] refine argparse library Chengwen Feng
2024-03-07 13:07   ` [PATCH v2 1/5] argparse: refine error message Chengwen Feng
2024-03-07 13:07   ` [PATCH v2 2/5] argparse: remove dead code Chengwen Feng
2024-03-07 13:07   ` [PATCH v2 3/5] argparse: replace flag enum with marco Chengwen Feng
2024-03-07 17:43     ` Tyler Retzlaff
2024-03-07 17:58       ` David Marchand
2024-03-07 18:37         ` Tyler Retzlaff
2024-03-07 13:07   ` [PATCH v2 4/5] argparse: fix argument flags operate as uint32 type Chengwen Feng
2024-03-18  2:31     ` Thomas Monjalon
2024-03-18  9:22       ` fengchengwen
2024-03-07 13:07   ` [PATCH v2 5/5] test/argparse: refine testcases Chengwen Feng
2024-03-18  9:18 ` [PATCH v3 0/6] refine argparse library Chengwen Feng
2024-03-18  9:18   ` [PATCH v3 1/6] argparse: refine error message Chengwen Feng
2024-03-18  9:18   ` [PATCH v3 2/6] argparse: remove dead code Chengwen Feng
2024-03-18  9:18   ` [PATCH v3 3/6] argparse: replace flag enum with marco Chengwen Feng
2024-03-18  9:18   ` [PATCH v3 4/6] argparse: fix argument flags operate as uint32 type Chengwen Feng
2024-03-18  9:38     ` Thomas Monjalon
2024-03-18 11:24       ` fengchengwen
2024-03-18  9:18   ` [PATCH v3 5/6] test/argparse: refine testcases Chengwen Feng
2024-03-18  9:18   ` [PATCH v3 6/6] argparse: fix doc don't display two hyphens Chengwen Feng
2024-03-18 11:18 ` [PATCH v4 0/6] refine argparse library Chengwen Feng
2024-03-18 11:18   ` [PATCH v4 1/6] argparse: refine error message Chengwen Feng
2024-03-18 11:18   ` [PATCH v4 2/6] argparse: remove dead code Chengwen Feng
2024-03-18 11:18   ` [PATCH v4 3/6] argparse: replace flag enum with marco Chengwen Feng
2024-03-18 11:18   ` [PATCH v4 4/6] argparse: fix argument flags operate as uint32 type Chengwen Feng
2024-03-18 11:18   ` [PATCH v4 5/6] test/argparse: refine testcases Chengwen Feng
2024-03-18 11:18   ` [PATCH v4 6/6] argparse: fix doc don't display two hyphens Chengwen Feng
2024-03-21 17:27   ` [PATCH v4 0/6] refine argparse library Thomas Monjalon
2024-03-22  1:24     ` fengchengwen
2024-05-08  9:10     ` fengchengwen
2024-07-04  3:07   ` fengchengwen
2024-09-06  0:59     ` fengchengwen
2024-07-05  6:06   ` Jie Hai
2024-07-09 10:53   ` huangdengdui
2024-10-07 20:32   ` Stephen Hemminger
2024-10-09 19:33   ` Stephen Hemminger
2024-10-10  1:35     ` fengchengwen
2024-10-18  1:09       ` fengchengwen
2024-10-18 14:46         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3466447.9LS3J3VOpE@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).