From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2598845B69; Fri, 18 Oct 2024 16:46:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02CCE4025F; Fri, 18 Oct 2024 16:46:26 +0200 (CEST) Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) by mails.dpdk.org (Postfix) with ESMTP id 897944025C for ; Fri, 18 Oct 2024 16:46:24 +0200 (CEST) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0B2291140155; Fri, 18 Oct 2024 10:46:24 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Fri, 18 Oct 2024 10:46:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729262784; x=1729349184; bh=Q0sLOtvUeJaD66XanPCaCH7cdEmXnTSrINldGBII66Q=; b= hbWAU8HMQY79/+nN99r2CxxqRsX+q9PLUEFS5fjQAOL7XY9FijLhR0S+GYwe+jUT mFO5wtiAo7IZqM8m3wroQsBn4K+P2HtWdRmWeHgvL5lvLFHBVuSBzBnWE7zw0n05 lat2ulNLpHiTbFC+E/r2eAhr0KerYDIbKCH+kDMNRIQ5u1LHtE7roDnZfQfwpzyA vHuF1WUXNFU0BNeyJAw5ekXE/mH+rCrE74Zmptxi4xUAMhaH/rMerNQJNEhgFP7w R0edU38cA5osrBe3hWKOuSbCeR62vufqGbCh4QW5nvk5totXedQlUzVrPw1igaeh K0jNh435HyGv0doBOQkLaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729262784; x= 1729349184; bh=Q0sLOtvUeJaD66XanPCaCH7cdEmXnTSrINldGBII66Q=; b=p MGDayOO2zwhc2wzYzIG2TKnLCoCSX0ZyeYyPgCILK25j1lUlUyBe8egV71nB/qRh rEhJoBwiQVheUu5ZCdjw2voJfpZQsEPmSlbWARcb6ukNux4e88ph33OXYoB2PNjp LRoDxR2W/XyxTrjTqEg7LdR3KkyXAfSn4/KKLV5RUOsnrAh9lGJXK+4j/+HvLy4u 84csvaAdPppHjw1aHoonLTYQwdr1XI984tvLLPg+vkdS6WRaVGSSpNhyxeI54U5y 7ep59kBS2Q0T15SOcQcsvQVsUOLi8vtQeUo7kVdaCIKvtr4Bui4M1UuDKUIflNEa OFAuGKJCuM9vb2b1BWvkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehfedgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeduudeigfejvdevieegvdeugedvjeej jeetffeiheejudejveeltefgtdefgeeijeenucffohhmrghinhepughogiihghgvnhdrnh hlnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepgedpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepfhgvnhhgtghhvghnghifvghnsehhuhgrfigvihdr tghomhdprhgtphhtthhopegurghvihgurdhmrghrtghhrghnugesrhgvughhrghtrdgtoh hmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtohepshhtvghphhgv nhesnhgvthifohhrkhhplhhumhgsvghrrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Oct 2024 10:46:22 -0400 (EDT) From: Thomas Monjalon To: fengchengwen Cc: david.marchand@redhat.com, dev@dpdk.org, Stephen Hemminger Subject: Re: [PATCH v4 0/6] refine argparse library Date: Fri, 18 Oct 2024 16:46:20 +0200 Message-ID: <3466447.9LS3J3VOpE@thomas> In-Reply-To: <5566b273-5c42-4d11-968c-b52648ff4732@huawei.com> References: <20240220131502.47510-1-fengchengwen@huawei.com> <13bb1302-9e94-4526-913e-5a51c94d68aa@huawei.com> <5566b273-5c42-4d11-968c-b52648ff4732@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/10/2024 03:09, fengchengwen: > Hi Thomas and David, > > This patchset was already acked by Stephen. > It missed in DPDK 24.07, hope merge in 24.11. > > Thanks > > On 2024/10/10 9:35, fengchengwen wrote: > > Hi Thomas and David, > > > > Kindly ping for merge. > > > > On 2024/10/10 3:33, Stephen Hemminger wrote: > >> On Mon, 18 Mar 2024 11:18:32 +0000 > >> Chengwen Feng wrote: > >> > >>> I found a couple of issues when I revisited the argparse_autotest > >>> output, so got this patchset. > >>> > >>> Chengwen Feng (6): > >>> argparse: refine error message > >>> argparse: remove dead code > >>> argparse: replace flag enum with marco > >>> argparse: fix argument flags operate as uint32 type > >>> test/argparse: refine testcases > >>> argparse: fix doc don't display two hyphens > >>> > >>> --- > >>> v4: address Thomas's comment on 4/6 commit: > >>> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and > >>> TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. > >>> v3: > >>> - address Thomas's comment on 4/6 comit. > >>> - add commit: fix doc don't display two hyphens. > >>> v2: address David Marchand's comment: > >>> - replace flag enum with marco. > >>> - replace flag's hardcode with macro in test_argparse.c. > >>> > >>> app/test/test_argparse.c | 65 +++++++++++--------- > >>> doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- > >>> lib/argparse/rte_argparse.c | 61 +++++++++--------- > >>> lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- > >>> 4 files changed, 127 insertions(+), 131 deletions(-) > >> > >> The verb refine is not usually used for edits to documents or software > >> that probably is a translation issue. > >> > >> Series-acked-by: Stephen Hemminger > > > > Thank Stephen Added Bugzilla ID, CC: stable, reworded as Stephen suggests, and applied. Note that the lists in doxygen comments does not look nice. You may look at this: https://www.doxygen.nl/manual/lists.html