* [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix
@ 2019-05-16 7:10 Yogev Chaimovich
2019-05-16 7:10 ` Yogev Chaimovich
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yogev Chaimovich @ 2019-05-16 7:10 UTC (permalink / raw)
To: yongwang; +Cc: dev, Yogev Chaimovich, stable
Coverity issue: 323479
Fixes: 30f77abe net/vmxnet3: support stats reset
Cc: stable@dpdk.org
Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f54536b..c465996 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct rte_pci_device *pci_dev)
{
unsigned int i;
struct vmxnet3_hw *hw = dev->data->dev_private;
- struct UPT1_TxStats txStats;
- struct UPT1_RxStats rxStats;
+ struct UPT1_TxStats txStats = {0};
+ struct UPT1_RxStats rxStats = {0};
VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix
2019-05-16 7:10 [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix Yogev Chaimovich
@ 2019-05-16 7:10 ` Yogev Chaimovich
2019-05-16 8:28 ` David Marchand
2019-05-20 17:48 ` Yong Wang
2 siblings, 0 replies; 6+ messages in thread
From: Yogev Chaimovich @ 2019-05-16 7:10 UTC (permalink / raw)
To: yongwang; +Cc: dev, Yogev Chaimovich, stable
Coverity issue: 323479
Fixes: 30f77abe net/vmxnet3: support stats reset
Cc: stable@dpdk.org
Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f54536b..c465996 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct rte_pci_device *pci_dev)
{
unsigned int i;
struct vmxnet3_hw *hw = dev->data->dev_private;
- struct UPT1_TxStats txStats;
- struct UPT1_RxStats rxStats;
+ struct UPT1_TxStats txStats = {0};
+ struct UPT1_RxStats rxStats = {0};
VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix
2019-05-16 7:10 [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix Yogev Chaimovich
2019-05-16 7:10 ` Yogev Chaimovich
@ 2019-05-16 8:28 ` David Marchand
2019-05-16 8:28 ` David Marchand
2019-05-20 17:48 ` Yong Wang
2 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2019-05-16 8:28 UTC (permalink / raw)
To: Yogev Chaimovich; +Cc: yongwang, dev, stable
On Thu, May 16, 2019 at 9:10 AM Yogev Chaimovich <yogev@cgstowernetworks.com>
wrote:
I am not sure this is the right fix but I don't know this driver so I will
let Yong comment on this.
On the form, please, have a look at the recommandations for submitting
patches:
http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
Coverity issue: 323479
> Fixes: 30f77abe net/vmxnet3: support stats reset
>
Here, we would expect the Fixes: line as:
Fixes: 30f77abecd38 ("net/vmxnet3: support stats reset")
> Cc: stable@dpdk.org
>
> Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
>
Iiuc, your sob line should be:
Signed-off-by: Yogev Chaimovich <yogev@cgstowernetworks.com>
---
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index f54536b..c465996 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct
> rte_pci_device *pci_dev)
> {
> unsigned int i;
> struct vmxnet3_hw *hw = dev->data->dev_private;
> - struct UPT1_TxStats txStats;
> - struct UPT1_RxStats rxStats;
> + struct UPT1_TxStats txStats = {0};
> + struct UPT1_RxStats rxStats = {0};
>
> VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
>
> --
> 1.9.1
>
>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix
2019-05-16 8:28 ` David Marchand
@ 2019-05-16 8:28 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2019-05-16 8:28 UTC (permalink / raw)
To: Yogev Chaimovich; +Cc: yongwang, dev, stable
On Thu, May 16, 2019 at 9:10 AM Yogev Chaimovich <yogev@cgstowernetworks.com>
wrote:
I am not sure this is the right fix but I don't know this driver so I will
let Yong comment on this.
On the form, please, have a look at the recommandations for submitting
patches:
http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
Coverity issue: 323479
> Fixes: 30f77abe net/vmxnet3: support stats reset
>
Here, we would expect the Fixes: line as:
Fixes: 30f77abecd38 ("net/vmxnet3: support stats reset")
> Cc: stable@dpdk.org
>
> Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
>
Iiuc, your sob line should be:
Signed-off-by: Yogev Chaimovich <yogev@cgstowernetworks.com>
---
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index f54536b..c465996 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct
> rte_pci_device *pci_dev)
> {
> unsigned int i;
> struct vmxnet3_hw *hw = dev->data->dev_private;
> - struct UPT1_TxStats txStats;
> - struct UPT1_RxStats rxStats;
> + struct UPT1_TxStats txStats = {0};
> + struct UPT1_RxStats rxStats = {0};
>
> VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
>
> --
> 1.9.1
>
>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix
2019-05-16 7:10 [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix Yogev Chaimovich
2019-05-16 7:10 ` Yogev Chaimovich
2019-05-16 8:28 ` David Marchand
@ 2019-05-20 17:48 ` Yong Wang
2019-05-27 16:23 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2 siblings, 1 reply; 6+ messages in thread
From: Yong Wang @ 2019-05-20 17:48 UTC (permalink / raw)
To: Yogev Chaimovich; +Cc: dev, stable
-----Original Message-----
From: Yogev Chaimovich <yogev@cgstowernetworks.com>
Date: Thursday, May 16, 2019 at 12:10 AM
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yogev Chaimovich <yogev@cgstowernetworks.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: [PATCH] net/vmxnet3: uninitialized variable fix
Coverity issue: 323479
Fixes: 30f77abe net/vmxnet3: support stats reset
Cc: stable@dpdk.org
Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
---
Acked-by: Yong Wang <yongwang@vmware.com>
drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f54536b..c465996 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct rte_pci_device *pci_dev)
{
unsigned int i;
struct vmxnet3_hw *hw = dev->data->dev_private;
- struct UPT1_TxStats txStats;
- struct UPT1_RxStats rxStats;
+ struct UPT1_TxStats txStats = {0};
+ struct UPT1_RxStats rxStats = {0};
VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: uninitialized variable fix
2019-05-20 17:48 ` Yong Wang
@ 2019-05-27 16:23 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-05-27 16:23 UTC (permalink / raw)
To: Yong Wang, Yogev Chaimovich; +Cc: dev, stable, David Marchand
On 5/20/2019 6:48 PM, Yong Wang wrote:
>
> -----Original Message-----
> From: Yogev Chaimovich <yogev@cgstowernetworks.com>
> Date: Thursday, May 16, 2019 at 12:10 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>, Yogev Chaimovich <yogev@cgstowernetworks.com>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: [PATCH] net/vmxnet3: uninitialized variable fix
>
> Coverity issue: 323479
> Fixes: 30f77abe net/vmxnet3: support stats reset
> Cc: stable@dpdk.org
>
> Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
> ---
>
> Acked-by: Yong Wang <yongwang@vmware.com>
Applied to dpdk-next-net/master, thanks.
(Suggestions from David applied.)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-27 16:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 7:10 [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix Yogev Chaimovich
2019-05-16 7:10 ` Yogev Chaimovich
2019-05-16 8:28 ` David Marchand
2019-05-16 8:28 ` David Marchand
2019-05-20 17:48 ` Yong Wang
2019-05-27 16:23 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).