From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F0FA4240B; Wed, 18 Jan 2023 09:58:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F248540223; Wed, 18 Jan 2023 09:58:10 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 0EDA74003F for ; Wed, 18 Jan 2023 09:58:09 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D4C46320092F; Wed, 18 Jan 2023 03:58:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 18 Jan 2023 03:58:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674032287; x= 1674118687; bh=MKJCxa2B/hcBpChvXw09Jiwmk0oSCwSYiIqlOo0Ppqs=; b=h 93j/3Bp3BmnMrHMobJCAH/hHNA/PVH3S30LB1CVO3dK16bmn0xW3NRkOTxl226Gn aQm79C5tN0XJ0+ufB88OKYXIedYrOL+CTSflZtdHqQxtjTa7M7CEvuinLX6/mVlm FuapPi4GbXTNGeedgNJo9hn4f+u5PcxykRr7ZlkDn+wSmQOtRFmRnz2z6gefhLvT wSWHV5LxmUlBn95tlOn8WQyXM25LWoJ0/oSwDkPpRWvKixjdSquIKiu66aMbAktl bjanUK17a6f94PVYf3NRfns4JOR3Ud31u+NITk1moN65aVpBixTJCjcK1SPCl2am M4af3u7XG/Bo/7zQw3LVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674032287; x= 1674118687; bh=MKJCxa2B/hcBpChvXw09Jiwmk0oSCwSYiIqlOo0Ppqs=; b=r GHAV+4SG9v0FFebVZ6YLep6s6VW6Cs11Ns8aEOuA1ObuS3uGrRV1VjyqA6OT/LRD VNG2RROzUb5PwjFXQy4Omv+sUIskzE8tDJWelcLzUWmj6xsMCp1SZX5h8bsWqL+s jZXPv2lNemesKmuL1ErqnSjElndMDY9MtwCgqeKlHmOOZWXz/c5v4iOHxu8WZsck pk+45lO0dpY7bsfb3V/oxm3k20OiGIHiUx68SFUfpDXrlhiDoSTHP9WGri8nstJv NK4vK/TrPGqf6wWcMkC83J9SSo2IUMy+tKn59c1JLGnbaa+TdZJEbS2DaeLl1D1+ i1BHsHD8iT0Rkw/ifOh7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtjedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Jan 2023 03:58:06 -0500 (EST) From: Thomas Monjalon To: Leo Xu Cc: dev@dpdk.org, Matan Azrad , Viacheslav Ovsiienko Subject: Re: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support Date: Wed, 18 Jan 2023 09:58:05 +0100 Message-ID: <3467707.0WQXIW03uk@thomas> In-Reply-To: <20221220074403.1015411-4-yongquanx@nvidia.com> References: <20221212085923.2314350-1-yongquanx@nvidia.com> <20221220074403.1015411-1-yongquanx@nvidia.com> <20221220074403.1015411-4-yongquanx@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/12/2022 08:44, Leo Xu: > This patch adds ICMPv6 ID and sequence match support for HWS. > Since type and code of ICMPv6 echo is already specified by ITEM type: > RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST > RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY > mlx5 pmd will set appropriate type and code automatically: > Echo request: type(128), code(0) > Echo reply: type(129), code(0) > type and code provided by application will be ignored > > This patch also fixes these issues in ICMP definer. > 1. Parsing inner ICMP item gets and overwrites the outer IP_PROTOCOL > function, which will remove the outer L4 match incorrectly. Fix this > by getting correct inner function. > 2. Member order of mlx5_ifc_header_icmp_bits doesn't follow ICMP format. > Reorder them to make it more consistent. Please don't fix stuff in the same patch as a new feature. You should have one patch per fix. The code for the new feature may be squashed in the other mlx5 patch for the feature.