From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fixup hotplugging an already present device
Date: Thu, 25 Oct 2018 13:49:26 +0200 [thread overview]
Message-ID: <3469600.mFqcC2W9gb@xps> (raw)
In-Reply-To: <20181025105101.137701-1-dariusz.stojaczyk@intel.com>
25/10/2018 12:51, Darek Stojaczyk:
> We were returning rc = -1 from a device probing function
> whenever the provided device was already probed before.
>
> This basically broke hotplugging a device in secondary
> process when the same device was already hotplugged in
> the primary.
>
> To fix it, just return 0 instead of -1. I believe this is
> the originally intented behavior.
The intent was to return the error seen during probing again.
If there is no error, the PMD must return 0.
It means I reject this patch so far.
next prev parent reply other threads:[~2018-10-25 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 10:51 Darek Stojaczyk
2018-10-25 11:49 ` Thomas Monjalon [this message]
2018-10-26 8:18 ` Stojaczyk, Dariusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3469600.mFqcC2W9gb@xps \
--to=thomas@monjalon.net \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).