From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 3CA954F98;
 Thu, 25 Oct 2018 13:49:26 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 1622E1086;
 Thu, 25 Oct 2018 07:49:25 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 25 Oct 2018 07:49:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=ASL8vlmMfMu8YPoogL/+38NGst6KccZfHnNpe6AT88g=; b=h7KGpzBrE3P0
 0o/TPZZWk5TnyV6jv8ynf31KH5hgKhL+SshU165csWircb/yD2zGRRCvikvF8pfJ
 8owZSbCdX69tvXiiVBoJ+EhwfNpRniX/HgwH6aTRh3oDdbBtW4JUPiH6sxKU4iVV
 pUThru/V/aJeEa8zkhRiWbZ0r8dqy90=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=ASL8vlmMfMu8YPoogL/+38NGst6KccZfHnNpe6AT8
 8g=; b=VswZ9nwjPreQijv6kmXSMoCvgKsjs74Dxo1jR2akB0zXyRtrSMXwlEOQj
 orH308nI0jvBb55/Ld9Z4IGV1KFcntor5sKjBIl4ExUxypqrlD/LkdXf0WoqH2O3
 knoO9bS+OqQhtpBkwy5Xs0AQzvXYe9wnDz5tcWwBQY98qJkepwUWoJW/2YBk3lVX
 yeX9/4MMP4Ctc+KtnPvZnODoBr4+taRDVdcLFUnLtk6VwVSyq4BiZjtXrH9wJOUm
 XUeTXx8fZD1wMdKgy8oAdvwccEwIr4gxwIDnQ7GJlf+AFVLdSqxrrQdQUoe4n5U2
 OlGvr/Sb+GJctUQkq1WJlPG68V9VA==
X-ME-Sender: <xms:xK3RW8fKTBLMS-G8yg84BFpLX6MU0c0bM8p1n49LGutnmdGJl54Cew>
X-ME-Proxy: <xmx:xK3RW552J3VlAfi9UTt9TNWgFjgmPUZ8dUJKAZcAZiz82TS-7TMb9w>
 <xmx:xK3RW3ULpvlI2z84xEbmvY4Vkx-fSRt-TJRTF5QaAUnqMV5e4sSMhA>
 <xmx:xK3RW3VBrFoTxx1G3FQ72Yp0B20zGEAQrbq71HIQJ8O33j-cOZbgxw>
 <xmx:xK3RW4ZsFoNjxgFhJ8w-0r3l1GHkt8bywtatHjTg1f2NTw8rpmbmcw>
 <xmx:xK3RW6VTaTc7yr0pXE_iawra27KTiA9y0DszOd5ZWXtXJ4qfmucR_A>
 <xmx:xK3RW7HYn9i-zuiXBU9zlmdWq_AR5S2ZWrAzretY9TZLX3JNffWmUg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 628F7102ED;
 Thu, 25 Oct 2018 07:49:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Date: Thu, 25 Oct 2018 13:49:26 +0200
Message-ID: <3469600.mFqcC2W9gb@xps>
In-Reply-To: <20181025105101.137701-1-dariusz.stojaczyk@intel.com>
References: <20181025105101.137701-1-dariusz.stojaczyk@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fixup hotplugging an already present
	device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 11:49:26 -0000

25/10/2018 12:51, Darek Stojaczyk:
> We were returning rc = -1 from a device probing function
> whenever the provided device was already probed before.
> 
> This basically broke hotplugging a device in secondary
> process when the same device was already hotplugged in
> the primary.
> 
> To fix it, just return 0 instead of -1. I believe this is
> the originally intented behavior.

The intent was to return the error seen during probing again.
If there is no error, the PMD must return 0.
It means I reject this patch so far.