From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0061.outbound.protection.outlook.com [104.47.36.61]) by dpdk.org (Postfix) with ESMTP id DBACDD148 for ; Tue, 11 Apr 2017 15:54:48 +0200 (CEST) Received: from CY1PR03CA0031.namprd03.prod.outlook.com (10.174.128.41) by BY1PR0301MB1287.namprd03.prod.outlook.com (10.161.206.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Tue, 11 Apr 2017 13:54:47 +0000 Received: from BN1BFFO11FD047.protection.gbl (2a01:111:f400:7c10::1:177) by CY1PR03CA0031.outlook.office365.com (2603:10b6:600::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17 via Frontend Transport; Tue, 11 Apr 2017 13:54:46 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD047.mail.protection.outlook.com (10.58.145.2) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1019.14 via Frontend Transport; Tue, 11 Apr 2017 13:54:46 +0000 Received: from [127.0.0.1] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v3BDsek5005799; Tue, 11 Apr 2017 06:54:43 -0700 To: Olivier MATZ , Thomas Monjalon References: <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <21940728.tivBTtkBCF@xps13> <5f4fe240-8f17-0d4f-04b7-a8dd04b2c16e@intel.com> <1526541.obk11Y6NX2@xps13> <20170411145612.4bd8ed34@neon> CC: Ferruh Yigit , , From: Hemant Agrawal Message-ID: <346d87ec-b57c-bc80-68b6-4ac9f76d48da@nxp.com> Date: Tue, 11 Apr 2017 19:24:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411145612.4bd8ed34@neon> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131363924865200191; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(39850400002)(39400400002)(39840400002)(39450400003)(39410400002)(2980300002)(1110001)(1109001)(339900001)(377424004)(199003)(24454002)(377454003)(189002)(9170700003)(38730400002)(120886001)(230700001)(4326008)(106466001)(7126002)(7246003)(2950100002)(36756003)(54906002)(5660300001)(105606002)(33646002)(356003)(229853002)(53546009)(31686004)(23746002)(53936002)(50466002)(50986999)(76176999)(54356999)(97736004)(6246003)(83506001)(4001350100001)(93886004)(8936002)(64126003)(85426001)(104016004)(47776003)(65806001)(2906002)(8676002)(31696002)(189998001)(8656002)(65956001)(86362001)(65826007)(77096006)(305945005)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0301MB1287; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD047; 1:0iw3+c61m8VBO+E5sec5bn1wewb0pW33+etA7JX7D0bYHysVXqIuZWMwNx2loG0yWas0x+2MXCJ4DTY7mv95lMw6VOwWL5C1E492Qy/eQrX14CIN/Y7hLI/bBi+Nf9I1Ls+5tT9ySP8gdU9/dFzR3ookGn25keC5wwFLmN+e7nG5reVb5BdqaKB2swo6b1S63ZdUN2sunweIGBZgmtr/87VYKQyEMsgcfwdDY1VMqtsmidtRD7x9zVJqQ5sLkh7a/ZqHj9S9RT1ajbZlam375DJoaCq7ipJP8YS28Su0TnpZgsplNzjTKabwjklhfb9Ck0g6AJKKkXG7bM/P1m+4uRXv5uLC3Q19Si/kDT64Q5e5JvlK6IOB7Q2ceu48sFXvf4eIk/r7Vxke7CMKMG06MseJMqBOOv179oRQUdQBQC2bhd5UrARfr0Fm2RWO4UTA83OUBbhzndpWPkHtOdfGfghvrQz9rPAg7WHSFtiP1Dsi2UIISBO9bFmiI4vE1m1Pih7D216nkuwheKaq6T/JHHV+Mvk0XnEuYS4n/c0wHtQUB+Vv9k4ydWiIPWrSpTq3btia0TxeDoOoUVvvw3rNG1SxLBia0K1DGZfjBQMiY6PfcrEzWGxx6suufoZK3fiH X-MS-Office365-Filtering-Correlation-Id: 055c7ec5-8a5f-4541-cee2-08d480e25058 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030255120)(201703131430075)(201703131517081); SRVR:BY1PR0301MB1287; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1287; 3:GH6oPMo1GN5bZ1ifokWadV7udIf3nXkMugWufulONpz7r4NpwVpFp0D3hiudzp2ICZ/IDphDlMLKJSoBy5h/B9Y/ZOfmtlrqGX3mVggI7zKhTc07rpbcIqBOE5zI/O94E8VclAul6SDlmgf+HKa6lqIFgZp8Mt5C0HDgtFLkaaVKOd9SVDgoHCDL3MSH2JADx5Log6qV1DFuMh2aatNtd7mvjZPP/EG/1H5vFjJ5f1g3T+RSqOwef8msAZVrbE9CyAtrBTy0mY0BcAA+REWxOb3PZCGefKxg/L2QXy96u3/akZ8DAEzuI8VIDS2ruGfSyPZEk6p6ve4QlRNvGuieCTkG7mqSk4EyKUNqe6oe9S3N8Grw8VjyieIl+SW52uaChdfi8sQmobqJpGiuTXxH//7qaGxk/hgBETAapaS0vnmIO0D3gkXLcwmRjh4Z42mqs+lBqjbDseCuy5nWQvIr7g== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1287; 25:DpEXL39owQLc6zW5Q1h1Qoi2JufZfMK7q5Q7mdeVRENfKXrwCvTrDj7J+iJ/6tIB6k+3GRzhrAjsN7lPh/SZMoUlbYNKf4aJ3Xp82G2Sc4khEA17+CXcLlHxp74ZLlKlPNLbNqGKA2iJR0zqUVkWWPGYLll17+bQ4gTy5zQt5Ud5Bk2S8E+mOPGrCkZE+tKSLCnEpuMq7+mrLNPhGixnQ9F7hQCoo5ctBFsur81656BsXVB8UReFPnt+dv1PTTFynd+ba+2viTsVghvnLPqPTOyKpujMzuAjEtnReEGtwwd7aJststeSJ4hTvN8cii3D4a/ojxAwH/bXD+K6HJK/pQjL6Tqj0Ui4bMdbxCotUs1IfBN9cSxCm8tANnURliCB2qia/RpEuk+9b2DBwl9GEdvPDbyTY5vRXQIFhntPD/vpmZehtjcHHsEl95hyjJRXe0n8KVVjYanG6FsvAQTbrA==; 31:JT+aXKXITiM02anROj+O+ylcjrkM0bpKqVe2gR44yDmk11n6+ezWT/pqs1q6GpOFY8Cvn6C1usKVIwHP2qtGGADBHh7mDft5+QW/jEM4+kf0VWP8p45YmN4LUj494Q1ZZgHu6V0eeX5ygrSExa5W3HpButLjVLXcLJCmWtjiU1A7zO/CAge/iG1gOc0njVpCOjmHjNMMbuPMXpctd1sYO1jUyIkAq/dk0nyt06XcdWRBylTTNVvmMEp8OQ+mk0gnyqTrtqDLvmOIDgwP584UQXLSm+h79fO/+hINi2bumGs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13024025)(13023025)(13015025)(13018025)(5005006)(13017025)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259075)(20161123556025)(20161123563025)(20161123565025); SRVR:BY1PR0301MB1287; BCL:0; PCL:0; RULEID:(400006); SRVR:BY1PR0301MB1287; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1287; 4:fNDZ5ZsJjjFsGjerefQGloHn+kQL3m9f7owHn8HAxUkI4MFOgbIuXlwOmivHHZlXthCYi1nIlHnju2FVXVLjoE/cykUQWxcXuX84k/xpDrU5LevgnTcqXlHc/hX82y6wTefKHxPYdFz03xNlVNTXfMjr+jB55WkYaE69/dX0K2FwCPWs0BLZpuO7rzERnSVdBIQ7KvWTV48IzY3wz1B7QOvNGh2jRIInWMJ0xgvQWhIctGwlUX2winK3dpvtiQu/eFE/m1UcXSRzE8zq1LTsLMqNzYl8cJ8p6jP1MYkji+7JpVlste23V0tLaAvnbcLldCJCdFbs1++jHzQpc5nNwGMGviKhHTPSfQDFJmF8o7P92g8Q+jPt5ab3+5Ez2oIwjbXDJk34VR2gjq6/A0am4IEDEs01UJIliRxrt95Y1DVWzsbUjDh+W8BEMZmadxsxp7kkYv5EtrZ8uWZN1xLzROmhUwDloBWFCV9fo9nQNgMBgCXJbZUHdoges31jQMGdYr00Gp0ZF8jvMJyTGJtVmEF6ThmTPoM6hUDkRIXBNdSaN6J1BK8AHjYio8ovoD062LishNz7s3xT1L0vLBkJsnZakn8QFodHr3aBA/DhOTvCBF/C3SFeINCMU5QGAteyDYw991m+M4Q/5KeKlqToJCiSP7aDtvyBjQJVPxZMDoH3kodyU6nzU7cceVVi6CzcdoXdYOclFYq+lDy6ihFZu8dnm3q7pyAFtf4wt0T/XMhJhqW4dKbfOD9/og87esj8T82hJbA5hPq7NmEbG5rSJ7fjMEIH0Rhy6ANCggJ/jLnVuAPPVrDGrwbFr6oTryNnVn+cyoprvFO2AYE02iRwdGvxf/bZ2WmdXPINQZU1wxZkYCAmV9oqUNDcN98yyq4gmhmJeUHgbuZNBxoFeAJgCMKg7AfH0AjY3nGsb2FrlJ0= X-Forefront-PRVS: 0274272F87 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY1PR0301MB1287; 23:suH5B2qclMENRYffeA8b7lxDuunKBO85K3u?= =?Windows-1252?Q?XABvbySzpLGYRe8ofS/mWGdilR3W4tFv9kgnTCVoEY0f8zLCzOBu2IWs?= =?Windows-1252?Q?/2z/2OT/cBD0gUaDDHYs1kU2jZwfZ6C4QwLG+wIFyxnKdMpO4UZEZdlF?= =?Windows-1252?Q?NCORczMMjL8uYkGFIanYVwq8FQEVSC7rHb43sEprj3g4TtSGWUpKQ7aW?= =?Windows-1252?Q?xN9rD9+VniC9TFWV98GmIDQuXYj/xZkvk/f1R4LZ30KUtfFvl8s5g7rk?= =?Windows-1252?Q?lraXmPUEVyYWNei4qw6LB+6mM3HuKoUR52U9r8CeJX7degDOpk3HsXm7?= =?Windows-1252?Q?sd1vnZaMBP48nsSK8RsAtobtutOlRM4SN1X2LRX8zwKyGCzbJxn7BEW0?= =?Windows-1252?Q?1NCX2es0wP5xNmSj3Lz7x6sipS+KkXUuvVXUy8jJd/y7ScIhaqRUWOsC?= =?Windows-1252?Q?Uje6i6AB1sU8Wk+bljuJvjrPoa4NxXI711VHZm7URd1j7coWI3f6v8ZY?= =?Windows-1252?Q?gv7tx8cwROfXCJQMpFEIlwPmhNwClTESKTvGghg5Hq+OswQMmHG3Yt3s?= =?Windows-1252?Q?a1sonLCiMX6LRVCOEGW+7gfL+qeEw4sYlI7yvixiNT0e61MI3L9zxv1S?= =?Windows-1252?Q?aAJHDq9ZXBx1cYbPxetvcEYAjhRK5aOktQmWqNg8PuFv8Ia38RmILFVC?= =?Windows-1252?Q?Ltmx90DwdMGH4JOY3OSDrCGjVZMzmVP3KLFE6sy/JTGmmo5NYDqyEvwY?= =?Windows-1252?Q?F5Yr2cfMgAK7gpK24hoinLThs7VUuW41iyccV92PdkbCaHYZaQ1uuD/a?= =?Windows-1252?Q?+p5lqFwMMrIkoz+O/KvJA4Lff36wUTXESbsyP3tqsbu9QyWe56lEW6p4?= =?Windows-1252?Q?St5nU3PhC6eT1VWtCr4StxZQ5dvORRgMIak3HtituFAo6zeg8nJL3AHr?= =?Windows-1252?Q?RxgxST7NreVcuXw6Z2NvBFaVPSuVE4xZauFG/JUAUld3PaVa2JnfkR2p?= =?Windows-1252?Q?kkxvZuuyVRGRNp8toB0QeX24XIrynQCGu1DQZLZuse+vZksXVz+p7lvV?= =?Windows-1252?Q?GBhGCby0gulds2LzqeFWaFJFgDSHRZTN0E8NpZeX931tnTZH+GFKl3YF?= =?Windows-1252?Q?ywAf5d1oIvv2zEUaYNpkMdVQt1iK+PQoxUDDq8ARdXHd/TOZQgzuzsu5?= =?Windows-1252?Q?JEhDnyc27GFlVZRwokS7GwNr4q4ylvuBmoHU9zaZUFVV/Po9ZHVc1vVL?= =?Windows-1252?Q?qqgd/6u9QVuNnG0yENrK9MB0PVH5O2u8KyZCPsFhlSZVQzcUzaE+iRwc?= =?Windows-1252?Q?iaftc5JxSLUR8JCQueFZPuN/2zPQiOgAEDJMrIMLRDf7h1aaudCp04KQ?= =?Windows-1252?Q?ugBYuaVESfPvUAWzJEWTuNwxDbk86DlKRoiNv3UaQqvDIbP3uKEOOuZi?= =?Windows-1252?Q?m0keCZDYTVVOiwsBXzHMrGpC+dg24dQS0KJ/ZZ/I/ywsdvP+4Y9SRgpN?= =?Windows-1252?Q?ltl5D93CrmtWMtR2Q/gtAnH+aAyjiEtqMmOefwhEG/LJb9peFbWtGMY9?= =?Windows-1252?Q?is4aBrOGTT6RIwT1v3bwrvdOFIHf3lJhOFvhgAiKTQ3VzNLFeb/o5XkA?= =?Windows-1252?Q?yvTOKlELRQrPMEGANTR37LJfExWSUSNgCEkJHwBrvKgTFoXvbgjcRaLP?= =?Windows-1252?Q?mtH2NTiFMng=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1287; 6:RbnrmAnaSCjX9szr536PFLPQ92UJUSlC6V9PksIFNbvtdoj08h5bmpmLuD9C0FScn8EEkgx4ab+Aj8rjHYgRgjyfgvmZZaAMf5H1IITjSkSIHmDI/H6/MK/knGcunvfJL8OGzutWBTsELBH1VE6rXBbGHdQ/zsD/8pkkqgt4KU+9io+a4thAVKCUhvlf+iHpz6Jx3Cx5cbgsa7GPZ4zhbqSraUUzVQmyokjOZnGypvwbJ4oDkQo9JX0oVKhYb+VusqweFkEPNXTCfxVUJuF7ruk2bvrVWVMspYNooEAJcpmD5tykLU2OgxUkzUwKtOETUR/mVNFSYVbvlaEqqNmrnWOCli+5C+P2J6n7qGLZtAsiE2Wko4xnBffZmQ2DDMNFm1/Ufecc+yqFEcz/oLxeCwzLuJwCM3pBkGY/Z7NpQZMxrkmetpJZpjYCd93pgNKpf1v48bbpGjxSl3fmVdr7Tg==; 5:OhXuwqLrr5NKwoSaek21HFLWwYitfjkjYMzuSyVzvvvlhSrpkA5PPS54eT0Je98aqLUZOv8Z4NHakunMAAOM+jHLZaj+0tDhMTZ9i2xuTbS7R4MzlW9yOEhVv34Sf6yfnsB4NzJTICgxrUaY30Yyp0LwQi5VCTvvDC8ZMEX3o+6v4ATml+m/s5ZuNCtlUE06; 24:EZcZCMR7cfh/9+G40ddBPWNLGMnqU7qA/gIKcsrkQDK2zSXYlqR7Lb786WxmkiY7gmRTibL7NfpgfchTMWF5MCIBJuT8UZ1jEAIote2BppE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1287; 7:jtSjsh8S/2N4KAH7iA7pLf3TY8cPnsSVO1ywTgi7RUBVrg29WCIrd3S+4U35GCLObxjC9n9MvR4L1lOpyRbIBfWf4smTa/7L1oygvLybE4eo1xHdaLAvHBtuV0F7/mosJKAqmIGuOGrxFm3u+lT1OZLomX5yMkNC+i/yek2WoEC/KcmJrAWsQIkzFsYcbmN4AhJ8mLg/KFl7Md589sQXKGZSpdbtVLg/vAddgReQNAFofKd5PWL5rQWEpFfZYiohAbnRiQyK4l8Mw7N8x4b2SInyG3/Nxrt55gmTC/iKXYfVaU4A89qJ69hj44FAACR+Mds0oGUwKaQmAgLFzeQASg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2017 13:54:46.3172 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1287 Subject: Re: [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 13:54:49 -0000 Hi Thomas, On 4/11/2017 6:26 PM, Olivier MATZ wrote: > On Tue, 11 Apr 2017 14:50:14 +0200 > Thomas Monjalon wrote: > >> 2017-04-11 09:39, Ferruh Yigit: >>> On 4/11/2017 8:50 AM, Thomas Monjalon wrote: >>>> 2017-04-11 11:28, Hemant Agrawal: >>>>> On 4/11/2017 1:28 AM, Olivier MATZ wrote: >>>>>> Hemant Agrawal wrote: >>>>>>> --- a/drivers/bus/Makefile >>>>>>> +++ b/drivers/bus/Makefile >>>>>>> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk >>>>>>> >>>>>>> core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether >>>>>>> >>>>>>> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y) >>>>>>> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) >>>>>>> +endif >>>>>>> + >>>>>>> DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc >>>>>>> DEPDIRS-fslmc = ${core-libs} >>>>>>> >>>>>> >>>>>> What's the purpose of this? >>>>>> Not sure we are allowed to modify the configs in the Makefiles. >>>>> >>>>> DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance >>>>> detected on FSLMC_BUS. >>>>> So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is >>>>> to be enabled. >>>>> >>>>> Currently the config structure do not provide such dependency definitions. >>>>> >>>>> This was done based on the suggestions on the initial patches from >>>>> Ferruh and Jerin. >>>> >>>> Please do not do that. >>>> We do not change the configuration in the back of the user. >>>> This kind of dependency should be managed in the configuration step >>>> which do not exist yet. >>>> >>>> You can use $(error) to stop the compilation instead. >>> >>> As Hemant mentioned, this was my suggestion. There is a configuration >>> dependency here, that we don't have a way to resolve in dpdk. >>> >>> If one of the end leaf selected, it makes sense to me to auto select >>> dependent pieces. >> >> A dependency must be solved at configuration time with appropriate >> user notification. >> For now, we just check them at compilation time and throw an error. > At present, we have removed the config dependency check from the code and sent the new patch sets. I am not sure about error part. I will experiment on it and send patches over these patches. This should not block the existing patches. > Yes, a good reason for not doing this is because the "make config" > generates a rte_config.h file. Changing a configuration option at > one place in a Makefile makes configuration inconsistent. > > I don't think it's a blocker issue for the patch integration. > > Regards, > Olivier > >