* [PATCH] drivers: suggestion on removing empty version.map files
@ 2022-10-03 6:52 Abdullah Ömer Yamaç
2022-10-03 9:19 ` Bruce Richardson
0 siblings, 1 reply; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-03 6:52 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Abdullah Ömer Yamaç
In this patch, we remove all version.map files which include
only the below part:
`DPDK_23 {
local: *;
};`
Then we modify the meson.build to be able to compile without version.map
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
drivers/baseband/la12xx/version.map | 3 --
drivers/baseband/null/version.map | 3 --
drivers/baseband/turbo_sw/version.map | 3 --
drivers/common/qat/version.map | 3 --
drivers/compress/isal/version.map | 3 --
drivers/compress/mlx5/version.map | 3 --
drivers/compress/octeontx/version.map | 3 --
drivers/compress/zlib/version.map | 3 --
drivers/crypto/armv8/version.map | 3 --
drivers/crypto/bcmfs/version.map | 3 --
drivers/crypto/caam_jr/version.map | 3 --
drivers/crypto/ccp/version.map | 3 --
drivers/crypto/ipsec_mb/version.map | 3 --
drivers/crypto/mlx5/version.map | 3 --
drivers/crypto/mvsam/version.map | 3 --
drivers/crypto/nitrox/version.map | 3 --
drivers/crypto/null/version.map | 3 --
drivers/crypto/openssl/version.map | 3 --
drivers/crypto/virtio/version.map | 3 --
drivers/dma/cnxk/version.map | 3 --
drivers/dma/dpaa/version.map | 3 --
drivers/dma/hisilicon/version.map | 3 --
drivers/dma/idxd/version.map | 3 --
drivers/dma/ioat/version.map | 3 --
drivers/dma/skeleton/version.map | 3 --
drivers/event/cnxk/version.map | 3 --
drivers/event/dpaa/version.map | 3 --
drivers/event/dpaa2/version.map | 3 --
drivers/event/dsw/version.map | 3 --
drivers/event/octeontx/version.map | 3 --
drivers/event/opdl/version.map | 3 --
drivers/event/skeleton/version.map | 3 --
drivers/event/sw/version.map | 3 --
drivers/gpu/cuda/version.map | 3 --
drivers/mempool/bucket/version.map | 3 --
drivers/mempool/cnxk/version.map | 3 --
drivers/mempool/octeontx/version.map | 3 --
drivers/mempool/ring/version.map | 3 --
drivers/mempool/stack/version.map | 3 --
drivers/meson.build | 63 +++++++++++++++------------
drivers/net/af_packet/version.map | 3 --
drivers/net/af_xdp/version.map | 3 --
drivers/net/ark/version.map | 3 --
drivers/net/avp/version.map | 3 --
drivers/net/axgbe/version.map | 3 --
drivers/net/bnx2x/version.map | 3 --
drivers/net/cxgbe/version.map | 3 --
drivers/net/e1000/version.map | 3 --
drivers/net/ena/version.map | 3 --
drivers/net/enetc/version.map | 3 --
drivers/net/enetfec/version.map | 3 --
drivers/net/enic/version.map | 3 --
drivers/net/failsafe/version.map | 3 --
drivers/net/fm10k/version.map | 3 --
drivers/net/hinic/version.map | 3 --
drivers/net/hns3/version.map | 3 --
drivers/net/igc/version.map | 3 --
drivers/net/ionic/version.map | 3 --
drivers/net/kni/version.map | 3 --
drivers/net/liquidio/version.map | 3 --
drivers/net/memif/version.map | 3 --
drivers/net/mlx4/version.map | 3 --
drivers/net/mvneta/version.map | 3 --
drivers/net/mvpp2/version.map | 3 --
drivers/net/netvsc/version.map | 3 --
drivers/net/nfb/version.map | 3 --
drivers/net/nfp/version.map | 3 --
drivers/net/ngbe/version.map | 3 --
drivers/net/null/version.map | 3 --
drivers/net/octeon_ep/version.map | 3 --
drivers/net/pcap/version.map | 3 --
drivers/net/pfe/version.map | 3 --
drivers/net/qede/version.map | 3 --
drivers/net/sfc/version.map | 3 --
drivers/net/tap/version.map | 3 --
drivers/net/thunderx/version.map | 3 --
drivers/net/txgbe/version.map | 3 --
drivers/net/vdev_netvsc/version.map | 3 --
drivers/net/virtio/version.map | 3 --
drivers/net/vmxnet3/version.map | 3 --
drivers/raw/cnxk_bphy/version.map | 3 --
drivers/raw/cnxk_gpio/version.map | 3 --
drivers/raw/dpaa2_cmdif/version.map | 3 --
drivers/raw/ntb/version.map | 3 --
drivers/raw/skeleton/version.map | 3 --
drivers/regex/cn9k/version.map | 3 --
drivers/regex/mlx5/version.map | 3 --
drivers/vdpa/ifc/version.map | 3 --
drivers/vdpa/mlx5/version.map | 3 --
drivers/vdpa/sfc/version.map | 3 --
90 files changed, 34 insertions(+), 296 deletions(-)
delete mode 100644 drivers/baseband/la12xx/version.map
delete mode 100644 drivers/baseband/null/version.map
delete mode 100644 drivers/baseband/turbo_sw/version.map
delete mode 100644 drivers/common/qat/version.map
delete mode 100644 drivers/compress/isal/version.map
delete mode 100644 drivers/compress/mlx5/version.map
delete mode 100644 drivers/compress/octeontx/version.map
delete mode 100644 drivers/compress/zlib/version.map
delete mode 100644 drivers/crypto/armv8/version.map
delete mode 100644 drivers/crypto/bcmfs/version.map
delete mode 100644 drivers/crypto/caam_jr/version.map
delete mode 100644 drivers/crypto/ccp/version.map
delete mode 100644 drivers/crypto/ipsec_mb/version.map
delete mode 100644 drivers/crypto/mlx5/version.map
delete mode 100644 drivers/crypto/mvsam/version.map
delete mode 100644 drivers/crypto/nitrox/version.map
delete mode 100644 drivers/crypto/null/version.map
delete mode 100644 drivers/crypto/openssl/version.map
delete mode 100644 drivers/crypto/virtio/version.map
delete mode 100644 drivers/dma/cnxk/version.map
delete mode 100644 drivers/dma/dpaa/version.map
delete mode 100644 drivers/dma/hisilicon/version.map
delete mode 100644 drivers/dma/idxd/version.map
delete mode 100644 drivers/dma/ioat/version.map
delete mode 100644 drivers/dma/skeleton/version.map
delete mode 100644 drivers/event/cnxk/version.map
delete mode 100644 drivers/event/dpaa/version.map
delete mode 100644 drivers/event/dpaa2/version.map
delete mode 100644 drivers/event/dsw/version.map
delete mode 100644 drivers/event/octeontx/version.map
delete mode 100644 drivers/event/opdl/version.map
delete mode 100644 drivers/event/skeleton/version.map
delete mode 100644 drivers/event/sw/version.map
delete mode 100644 drivers/gpu/cuda/version.map
delete mode 100644 drivers/mempool/bucket/version.map
delete mode 100644 drivers/mempool/cnxk/version.map
delete mode 100644 drivers/mempool/octeontx/version.map
delete mode 100644 drivers/mempool/ring/version.map
delete mode 100644 drivers/mempool/stack/version.map
delete mode 100644 drivers/net/af_packet/version.map
delete mode 100644 drivers/net/af_xdp/version.map
delete mode 100644 drivers/net/ark/version.map
delete mode 100644 drivers/net/avp/version.map
delete mode 100644 drivers/net/axgbe/version.map
delete mode 100644 drivers/net/bnx2x/version.map
delete mode 100644 drivers/net/cxgbe/version.map
delete mode 100644 drivers/net/e1000/version.map
delete mode 100644 drivers/net/ena/version.map
delete mode 100644 drivers/net/enetc/version.map
delete mode 100644 drivers/net/enetfec/version.map
delete mode 100644 drivers/net/enic/version.map
delete mode 100644 drivers/net/failsafe/version.map
delete mode 100644 drivers/net/fm10k/version.map
delete mode 100644 drivers/net/hinic/version.map
delete mode 100644 drivers/net/hns3/version.map
delete mode 100644 drivers/net/igc/version.map
delete mode 100644 drivers/net/ionic/version.map
delete mode 100644 drivers/net/kni/version.map
delete mode 100644 drivers/net/liquidio/version.map
delete mode 100644 drivers/net/memif/version.map
delete mode 100644 drivers/net/mlx4/version.map
delete mode 100644 drivers/net/mvneta/version.map
delete mode 100644 drivers/net/mvpp2/version.map
delete mode 100644 drivers/net/netvsc/version.map
delete mode 100644 drivers/net/nfb/version.map
delete mode 100644 drivers/net/nfp/version.map
delete mode 100644 drivers/net/ngbe/version.map
delete mode 100644 drivers/net/null/version.map
delete mode 100644 drivers/net/octeon_ep/version.map
delete mode 100644 drivers/net/pcap/version.map
delete mode 100644 drivers/net/pfe/version.map
delete mode 100644 drivers/net/qede/version.map
delete mode 100644 drivers/net/sfc/version.map
delete mode 100644 drivers/net/tap/version.map
delete mode 100644 drivers/net/thunderx/version.map
delete mode 100644 drivers/net/txgbe/version.map
delete mode 100644 drivers/net/vdev_netvsc/version.map
delete mode 100644 drivers/net/virtio/version.map
delete mode 100644 drivers/net/vmxnet3/version.map
delete mode 100644 drivers/raw/cnxk_bphy/version.map
delete mode 100644 drivers/raw/cnxk_gpio/version.map
delete mode 100644 drivers/raw/dpaa2_cmdif/version.map
delete mode 100644 drivers/raw/ntb/version.map
delete mode 100644 drivers/raw/skeleton/version.map
delete mode 100644 drivers/regex/cn9k/version.map
delete mode 100644 drivers/regex/mlx5/version.map
delete mode 100644 drivers/vdpa/ifc/version.map
delete mode 100644 drivers/vdpa/mlx5/version.map
delete mode 100644 drivers/vdpa/sfc/version.map
diff --git a/drivers/baseband/la12xx/version.map b/drivers/baseband/la12xx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/la12xx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/null/version.map b/drivers/baseband/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/turbo_sw/version.map b/drivers/baseband/turbo_sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/turbo_sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/common/qat/version.map b/drivers/common/qat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/common/qat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/isal/version.map b/drivers/compress/isal/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/isal/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/mlx5/version.map b/drivers/compress/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/octeontx/version.map b/drivers/compress/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/zlib/version.map b/drivers/compress/zlib/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/zlib/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/armv8/version.map b/drivers/crypto/armv8/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/armv8/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/bcmfs/version.map b/drivers/crypto/bcmfs/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/bcmfs/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/caam_jr/version.map b/drivers/crypto/caam_jr/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/caam_jr/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ccp/version.map b/drivers/crypto/ccp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ccp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ipsec_mb/version.map b/drivers/crypto/ipsec_mb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ipsec_mb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mlx5/version.map b/drivers/crypto/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mvsam/version.map b/drivers/crypto/mvsam/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mvsam/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/nitrox/version.map b/drivers/crypto/nitrox/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/nitrox/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/null/version.map b/drivers/crypto/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/openssl/version.map b/drivers/crypto/openssl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/openssl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/virtio/version.map b/drivers/crypto/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/cnxk/version.map b/drivers/dma/cnxk/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/dpaa/version.map b/drivers/dma/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/hisilicon/version.map b/drivers/dma/hisilicon/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/hisilicon/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/idxd/version.map b/drivers/dma/idxd/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/idxd/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/ioat/version.map b/drivers/dma/ioat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/ioat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/skeleton/version.map b/drivers/dma/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/cnxk/version.map b/drivers/event/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/event/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/event/dpaa/version.map b/drivers/event/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dpaa2/version.map b/drivers/event/dpaa2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dsw/version.map b/drivers/event/dsw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dsw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/octeontx/version.map b/drivers/event/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/opdl/version.map b/drivers/event/opdl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/opdl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/skeleton/version.map b/drivers/event/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/sw/version.map b/drivers/event/sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/gpu/cuda/version.map b/drivers/gpu/cuda/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/gpu/cuda/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/bucket/version.map b/drivers/mempool/bucket/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/bucket/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/cnxk/version.map b/drivers/mempool/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/mempool/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/mempool/octeontx/version.map b/drivers/mempool/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/ring/version.map b/drivers/mempool/ring/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/ring/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/stack/version.map b/drivers/mempool/stack/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/stack/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/meson.build b/drivers/meson.build
index f6ba5ba4fb..1b2ad1803d 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
+fs = import('fs')
+
# Defines the order of dependencies evaluation
subdirs = [
'common',
@@ -193,38 +195,41 @@ foreach subpath:subdirs
version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
implib = 'lib' + lib_name + '.dll.a'
- def_file = custom_target(lib_name + '_def',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_exports.def'.format(lib_name))
-
- mingw_map = custom_target(lib_name + '_mingw',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_mingw.map'.format(lib_name))
-
- lk_deps = [version_map, def_file, mingw_map]
- if is_windows
- if is_ms_linker
- lk_args = ['-Wl,/def:' + def_file.full_path()]
- if meson.version().version_compare('<0.54.0')
- lk_args += ['-Wl,/implib:drivers\\' + implib]
+ if fs.is_file(version_map)
+ def_file = custom_target(lib_name + '_def',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_exports.def'.format(lib_name))
+
+ mingw_map = custom_target(lib_name + '_mingw',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_mingw.map'.format(lib_name))
+
+ lk_deps = [version_map, def_file, mingw_map]
+ if is_windows
+ if is_ms_linker
+ lk_args = ['-Wl,/def:' + def_file.full_path()]
+ if meson.version().version_compare('<0.54.0')
+ lk_args += ['-Wl,/implib:drivers\\' + implib]
+ endif
+ else
+ lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
endif
else
- lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
- endif
- else
- lk_args = ['-Wl,--version-script=' + version_map]
- if developer_mode
- # on unix systems check the output of the
- # check-symbols.sh script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.sym_chk',
- command: [check_symbols, version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.sym_chk')
+ lk_args = ['-Wl,--version-script=' + version_map]
+ if developer_mode
+ # on unix systems check the output of the
+ # check-symbols.sh script, using it as a
+ # dependency of the .so build
+ lk_deps += custom_target(lib_name + '.sym_chk',
+ command: [check_symbols, version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.sym_chk')
+ endif
endif
+
endif
shared_lib = shared_library(lib_name, sources,
diff --git a/drivers/net/af_packet/version.map b/drivers/net/af_packet/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_packet/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_xdp/version.map b/drivers/net/af_xdp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_xdp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ark/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/avp/version.map b/drivers/net/avp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/avp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/axgbe/version.map b/drivers/net/axgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/axgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/bnx2x/version.map b/drivers/net/bnx2x/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/bnx2x/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/cxgbe/version.map b/drivers/net/cxgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/cxgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/e1000/version.map b/drivers/net/e1000/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/e1000/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ena/version.map b/drivers/net/ena/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ena/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetc/version.map b/drivers/net/enetc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetfec/version.map b/drivers/net/enetfec/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetfec/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enic/version.map b/drivers/net/enic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/failsafe/version.map b/drivers/net/failsafe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/failsafe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/fm10k/version.map b/drivers/net/fm10k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/fm10k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hinic/version.map b/drivers/net/hinic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hinic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hns3/version.map b/drivers/net/hns3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hns3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/igc/version.map b/drivers/net/igc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/igc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ionic/version.map b/drivers/net/ionic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ionic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/kni/version.map b/drivers/net/kni/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/kni/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/liquidio/version.map b/drivers/net/liquidio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/liquidio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/memif/version.map b/drivers/net/memif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/memif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mlx4/version.map b/drivers/net/mlx4/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mlx4/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvneta/version.map b/drivers/net/mvneta/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvneta/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvpp2/version.map b/drivers/net/mvpp2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvpp2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/netvsc/version.map b/drivers/net/netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfb/version.map b/drivers/net/nfb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfp/version.map b/drivers/net/nfp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ngbe/version.map b/drivers/net/ngbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ngbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/null/version.map b/drivers/net/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/octeon_ep/version.map b/drivers/net/octeon_ep/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/octeon_ep/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pcap/version.map b/drivers/net/pcap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pcap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pfe/version.map b/drivers/net/pfe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pfe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/qede/version.map b/drivers/net/qede/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/qede/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/sfc/version.map b/drivers/net/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/tap/version.map b/drivers/net/tap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/tap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/thunderx/version.map b/drivers/net/thunderx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/thunderx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/txgbe/version.map b/drivers/net/txgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/txgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vdev_netvsc/version.map b/drivers/net/vdev_netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vdev_netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/virtio/version.map b/drivers/net/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vmxnet3/version.map b/drivers/net/vmxnet3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vmxnet3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_bphy/version.map b/drivers/raw/cnxk_bphy/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_bphy/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_gpio/version.map b/drivers/raw/cnxk_gpio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_gpio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/dpaa2_cmdif/version.map b/drivers/raw/dpaa2_cmdif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/dpaa2_cmdif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/ntb/version.map b/drivers/raw/ntb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/ntb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/skeleton/version.map b/drivers/raw/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/cn9k/version.map b/drivers/regex/cn9k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/cn9k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/mlx5/version.map b/drivers/regex/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/ifc/version.map b/drivers/vdpa/ifc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/ifc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/mlx5/version.map b/drivers/vdpa/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] drivers: suggestion on removing empty version.map files
2022-10-03 6:52 [PATCH] drivers: suggestion on removing empty version.map files Abdullah Ömer Yamaç
@ 2022-10-03 9:19 ` Bruce Richardson
2022-10-03 13:59 ` Omer Yamac
0 siblings, 1 reply; 22+ messages in thread
From: Bruce Richardson @ 2022-10-03 9:19 UTC (permalink / raw)
To: Abdullah Ömer Yamaç; +Cc: dev, ferruh.yigit
On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
> In this patch, we remove all version.map files which include
> only the below part:
> `DPDK_23 {
> local: *;
> };`
>
> Then we modify the meson.build to be able to compile without version.map
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
I think you need to flag this as depending on us bumping the meson version
requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
versions.
One other suggestion is to split this into 2 patches. Have the first patch
just with the meson changes to support this, and the second patch then
doing the actual removal. That would make this a lot easier to review since
the code needing the review will all be in the first patch.
Otherwise, good idea!
Regards,
/Bruce
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] drivers: suggestion on removing empty version.map files
2022-10-03 9:19 ` Bruce Richardson
@ 2022-10-03 13:59 ` Omer Yamac
2022-10-03 14:01 ` Bruce Richardson
0 siblings, 1 reply; 22+ messages in thread
From: Omer Yamac @ 2022-10-03 13:59 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, ferruh.yigit
On 03.10.2022 12:19, Bruce Richardson wrote:
> On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
>> In this patch, we remove all version.map files which include
>> only the below part:
>> `DPDK_23 {
>> local: *;
>> };`
>>
>> Then we modify the meson.build to be able to compile without
>> version.map
>>
>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> ---
>
> I think you need to flag this as depending on us bumping the meson
> version
> requirement up to 0.53 as has been proposed. This doesn't work with
> 0.4x
> versions.
>
Thanks for your warnings.
Instead of using fs module, I will use python script that checks file
exist or not.
If it is okay, I will resubmit the patch.
> One other suggestion is to split this into 2 patches. Have the first
> patch
> just with the meson changes to support this, and the second patch then
> doing the actual removal. That would make this a lot easier to review
> since
> the code needing the review will all be in the first patch.
>
I will do in the next patch.
> Otherwise, good idea!
>
> Regards,
> /Bruce
Thanks
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] drivers: suggestion on removing empty version.map files
2022-10-03 13:59 ` Omer Yamac
@ 2022-10-03 14:01 ` Bruce Richardson
2022-10-04 6:30 ` Omer Yamac
0 siblings, 1 reply; 22+ messages in thread
From: Bruce Richardson @ 2022-10-03 14:01 UTC (permalink / raw)
To: Omer Yamac; +Cc: dev, ferruh.yigit
On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote:
>
>
> On 03.10.2022 12:19, Bruce Richardson wrote:
> > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
> > > In this patch, we remove all version.map files which include
> > > only the below part:
> > > `DPDK_23 {
> > > local: *;
> > > };`
> > >
> > > Then we modify the meson.build to be able to compile without
> > > version.map
> > >
> > > Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> > > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > > ---
> >
> > I think you need to flag this as depending on us bumping the meson
> > version
> > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
> > versions.
> >
> Thanks for your warnings.
> Instead of using fs module, I will use python script that checks file exist
> or not.
> If it is okay, I will resubmit the patch.
I'd rather not go down that road unless we really need to. Right now the
empty version.map files are pretty much harmless, so there is no compelling
need to change. Therefore, I'd rather wait to have the meson version bumped
to 0.53 and then have this patch applied, without having to worry about
using script fallbacks.
/Bruce
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] drivers: suggestion on removing empty version.map files
2022-10-03 14:01 ` Bruce Richardson
@ 2022-10-04 6:30 ` Omer Yamac
2022-10-04 8:07 ` Bruce Richardson
0 siblings, 1 reply; 22+ messages in thread
From: Omer Yamac @ 2022-10-04 6:30 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, ferruh.yigit
On 03.10.2022 17:01, Bruce Richardson wrote:
> On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote:
>>
>>
>> On 03.10.2022 12:19, Bruce Richardson wrote:
>> > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
>> > > In this patch, we remove all version.map files which include
>> > > only the below part:
>> > > `DPDK_23 {
>> > > local: *;
>> > > };`
>> > >
>> > > Then we modify the meson.build to be able to compile without
>> > > version.map
>> > >
>> > > Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>> > > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> > > ---
>> >
>> > I think you need to flag this as depending on us bumping the meson
>> > version
>> > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
>> > versions.
>> >
>> Thanks for your warnings.
>> Instead of using fs module, I will use python script that checks file
>> exist
>> or not.
>> If it is okay, I will resubmit the patch.
>
> I'd rather not go down that road unless we really need to. Right now
> the
> empty version.map files are pretty much harmless, so there is no
> compelling
> need to change. Therefore, I'd rather wait to have the meson version
> bumped
> to 0.53 and then have this patch applied, without having to worry about
> using script fallbacks.
I understood; but one thing I'm not sure what should I do? I don't know
how can I flag the meson requirement. Is there any special method or
just a comment in the commit?
>
> /Bruce
Thanks
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] drivers: suggestion on removing empty version.map files
2022-10-04 6:30 ` Omer Yamac
@ 2022-10-04 8:07 ` Bruce Richardson
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
0 siblings, 1 reply; 22+ messages in thread
From: Bruce Richardson @ 2022-10-04 8:07 UTC (permalink / raw)
To: Omer Yamac; +Cc: dev, ferruh.yigit
On Tue, Oct 04, 2022 at 09:30:39AM +0300, Omer Yamac wrote:
>
>
> On 03.10.2022 17:01, Bruce Richardson wrote:
> > On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote:
> > >
> > >
> > > On 03.10.2022 12:19, Bruce Richardson wrote:
> > > > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
> > > > > In this patch, we remove all version.map files which include
> > > > > only the below part:
> > > > > `DPDK_23 {
> > > > > local: *;
> > > > > };`
> > > > >
> > > > > Then we modify the meson.build to be able to compile without
> > > > > version.map
> > > > >
> > > > > Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> > > > > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > > > > ---
> > > >
> > > > I think you need to flag this as depending on us bumping the meson
> > > > version
> > > > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
> > > > versions.
> > > >
> > > Thanks for your warnings.
> > > Instead of using fs module, I will use python script that checks
> > > file exist
> > > or not.
> > > If it is okay, I will resubmit the patch.
> >
> > I'd rather not go down that road unless we really need to. Right now the
> > empty version.map files are pretty much harmless, so there is no
> > compelling
> > need to change. Therefore, I'd rather wait to have the meson version
> > bumped
> > to 0.53 and then have this patch applied, without having to worry about
> > using script fallbacks.
> I understood; but one thing I'm not sure what should I do? I don't know how
> can I flag the meson requirement. Is there any special method or just a
> comment in the commit?
You can just put a note in the commit log, under a cut-line indicating what
other patches your patch depends upon.
See https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies
Regards,
/Bruce
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH 1/2] drivers: suggestion on meson without version file
2022-10-04 8:07 ` Bruce Richardson
@ 2022-10-06 7:19 ` Abdullah Ömer Yamaç
2022-10-06 7:19 ` [PATCH 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
0 siblings, 2 replies; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-06 7:19 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit
Most of the drivers don't have a special version.map file. They just
included due to the compilation issue and needs to be updated for each
release.
These version.map files include:
DPDK_23 {
local: *;
};
In this patch, we removed the necessity of the version files and
you don't need to update these files for each release, you can just
remove them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Depends on: patch-116222 ("build: increase minimum meson version to 0.53")
---
drivers/meson.build | 63 ++++++++++++++++++++++++---------------------
1 file changed, 34 insertions(+), 29 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index f6ba5ba4fb..6ef03e14c7 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
+fs = import('fs')
+
# Defines the order of dependencies evaluation
subdirs = [
'common',
@@ -193,38 +195,41 @@ foreach subpath:subdirs
version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
implib = 'lib' + lib_name + '.dll.a'
- def_file = custom_target(lib_name + '_def',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_exports.def'.format(lib_name))
-
- mingw_map = custom_target(lib_name + '_mingw',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_mingw.map'.format(lib_name))
-
- lk_deps = [version_map, def_file, mingw_map]
- if is_windows
- if is_ms_linker
- lk_args = ['-Wl,/def:' + def_file.full_path()]
- if meson.version().version_compare('<0.54.0')
- lk_args += ['-Wl,/implib:drivers\\' + implib]
+ if fs.is_file(version_map)
+ def_file = custom_target(lib_name + '_def',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_exports.def'.format(lib_name))
+
+ mingw_map = custom_target(lib_name + '_mingw',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_mingw.map'.format(lib_name))
+
+ lk_deps = [version_map, def_file, mingw_map]
+ if is_windows
+ if is_ms_linker
+ lk_args = ['-Wl,/def:' + def_file.full_path()]
+ if meson.version().version_compare('<0.54.0')
+ lk_args += ['-Wl,/implib:drivers\\' + implib]
+ endif
+ else
+ lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
endif
else
- lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
- endif
- else
- lk_args = ['-Wl,--version-script=' + version_map]
- if developer_mode
- # on unix systems check the output of the
- # check-symbols.sh script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.sym_chk',
- command: [check_symbols, version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.sym_chk')
+ lk_args = ['-Wl,--version-script=' + version_map]
+ if developer_mode
+ # on unix systems check the output of the
+ # check-symbols.sh script, using it as a
+ # dependency of the .so build
+ lk_deps += custom_target(lib_name + '.sym_chk',
+ command: [check_symbols, version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.sym_chk')
+ endif
endif
+
endif
shared_lib = shared_library(lib_name, sources,
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH 2/2] drivers: remove the unnecessary version.map
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
@ 2022-10-06 7:19 ` Abdullah Ömer Yamaç
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
1 sibling, 0 replies; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-06 7:19 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit
With the previous patch, some version.map files are not necessary.
In this patch, we removed them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Depends on: patch-116222 ("build: increase minimum meson version to 0.53")
---
drivers/baseband/la12xx/version.map | 3 ---
drivers/baseband/null/version.map | 3 ---
drivers/baseband/turbo_sw/version.map | 3 ---
drivers/common/qat/version.map | 3 ---
drivers/compress/isal/version.map | 3 ---
drivers/compress/mlx5/version.map | 3 ---
drivers/compress/octeontx/version.map | 3 ---
drivers/compress/zlib/version.map | 3 ---
drivers/crypto/armv8/version.map | 3 ---
drivers/crypto/bcmfs/version.map | 3 ---
drivers/crypto/caam_jr/version.map | 3 ---
drivers/crypto/ccp/version.map | 3 ---
drivers/crypto/ipsec_mb/version.map | 3 ---
drivers/crypto/mlx5/version.map | 3 ---
drivers/crypto/mvsam/version.map | 3 ---
drivers/crypto/nitrox/version.map | 3 ---
drivers/crypto/null/version.map | 3 ---
drivers/crypto/openssl/version.map | 3 ---
drivers/crypto/virtio/version.map | 3 ---
drivers/dma/cnxk/version.map | 3 ---
drivers/dma/dpaa/version.map | 3 ---
drivers/dma/hisilicon/version.map | 3 ---
drivers/dma/idxd/version.map | 3 ---
drivers/dma/ioat/version.map | 3 ---
drivers/dma/skeleton/version.map | 3 ---
drivers/event/cnxk/version.map | 3 ---
drivers/event/dpaa/version.map | 3 ---
drivers/event/dpaa2/version.map | 3 ---
drivers/event/dsw/version.map | 3 ---
drivers/event/octeontx/version.map | 3 ---
drivers/event/opdl/version.map | 3 ---
drivers/event/skeleton/version.map | 3 ---
drivers/event/sw/version.map | 3 ---
drivers/gpu/cuda/version.map | 3 ---
drivers/mempool/bucket/version.map | 3 ---
drivers/mempool/cnxk/version.map | 3 ---
drivers/mempool/octeontx/version.map | 3 ---
drivers/mempool/ring/version.map | 3 ---
drivers/mempool/stack/version.map | 3 ---
drivers/net/af_packet/version.map | 3 ---
drivers/net/af_xdp/version.map | 3 ---
drivers/net/ark/version.map | 3 ---
drivers/net/avp/version.map | 3 ---
drivers/net/axgbe/version.map | 3 ---
drivers/net/bnx2x/version.map | 3 ---
drivers/net/cxgbe/version.map | 3 ---
drivers/net/e1000/version.map | 3 ---
drivers/net/ena/version.map | 3 ---
drivers/net/enetc/version.map | 3 ---
drivers/net/enetfec/version.map | 3 ---
drivers/net/enic/version.map | 3 ---
drivers/net/failsafe/version.map | 3 ---
drivers/net/fm10k/version.map | 3 ---
drivers/net/hinic/version.map | 3 ---
drivers/net/hns3/version.map | 3 ---
drivers/net/igc/version.map | 3 ---
drivers/net/ionic/version.map | 3 ---
drivers/net/kni/version.map | 3 ---
drivers/net/liquidio/version.map | 3 ---
drivers/net/memif/version.map | 3 ---
drivers/net/mlx4/version.map | 3 ---
drivers/net/mvneta/version.map | 3 ---
drivers/net/mvpp2/version.map | 3 ---
drivers/net/netvsc/version.map | 3 ---
drivers/net/nfb/version.map | 3 ---
drivers/net/nfp/version.map | 3 ---
drivers/net/ngbe/version.map | 3 ---
drivers/net/null/version.map | 3 ---
drivers/net/octeon_ep/version.map | 3 ---
drivers/net/pcap/version.map | 3 ---
drivers/net/pfe/version.map | 3 ---
drivers/net/qede/version.map | 3 ---
drivers/net/sfc/version.map | 3 ---
drivers/net/tap/version.map | 3 ---
drivers/net/thunderx/version.map | 3 ---
drivers/net/txgbe/version.map | 3 ---
drivers/net/vdev_netvsc/version.map | 3 ---
drivers/net/virtio/version.map | 3 ---
drivers/net/vmxnet3/version.map | 3 ---
drivers/raw/cnxk_bphy/version.map | 3 ---
drivers/raw/cnxk_gpio/version.map | 3 ---
drivers/raw/dpaa2_cmdif/version.map | 3 ---
drivers/raw/ntb/version.map | 3 ---
drivers/raw/skeleton/version.map | 3 ---
drivers/regex/cn9k/version.map | 3 ---
drivers/regex/mlx5/version.map | 3 ---
drivers/vdpa/ifc/version.map | 3 ---
drivers/vdpa/mlx5/version.map | 3 ---
drivers/vdpa/sfc/version.map | 3 ---
89 files changed, 267 deletions(-)
delete mode 100644 drivers/baseband/la12xx/version.map
delete mode 100644 drivers/baseband/null/version.map
delete mode 100644 drivers/baseband/turbo_sw/version.map
delete mode 100644 drivers/common/qat/version.map
delete mode 100644 drivers/compress/isal/version.map
delete mode 100644 drivers/compress/mlx5/version.map
delete mode 100644 drivers/compress/octeontx/version.map
delete mode 100644 drivers/compress/zlib/version.map
delete mode 100644 drivers/crypto/armv8/version.map
delete mode 100644 drivers/crypto/bcmfs/version.map
delete mode 100644 drivers/crypto/caam_jr/version.map
delete mode 100644 drivers/crypto/ccp/version.map
delete mode 100644 drivers/crypto/ipsec_mb/version.map
delete mode 100644 drivers/crypto/mlx5/version.map
delete mode 100644 drivers/crypto/mvsam/version.map
delete mode 100644 drivers/crypto/nitrox/version.map
delete mode 100644 drivers/crypto/null/version.map
delete mode 100644 drivers/crypto/openssl/version.map
delete mode 100644 drivers/crypto/virtio/version.map
delete mode 100644 drivers/dma/cnxk/version.map
delete mode 100644 drivers/dma/dpaa/version.map
delete mode 100644 drivers/dma/hisilicon/version.map
delete mode 100644 drivers/dma/idxd/version.map
delete mode 100644 drivers/dma/ioat/version.map
delete mode 100644 drivers/dma/skeleton/version.map
delete mode 100644 drivers/event/cnxk/version.map
delete mode 100644 drivers/event/dpaa/version.map
delete mode 100644 drivers/event/dpaa2/version.map
delete mode 100644 drivers/event/dsw/version.map
delete mode 100644 drivers/event/octeontx/version.map
delete mode 100644 drivers/event/opdl/version.map
delete mode 100644 drivers/event/skeleton/version.map
delete mode 100644 drivers/event/sw/version.map
delete mode 100644 drivers/gpu/cuda/version.map
delete mode 100644 drivers/mempool/bucket/version.map
delete mode 100644 drivers/mempool/cnxk/version.map
delete mode 100644 drivers/mempool/octeontx/version.map
delete mode 100644 drivers/mempool/ring/version.map
delete mode 100644 drivers/mempool/stack/version.map
delete mode 100644 drivers/net/af_packet/version.map
delete mode 100644 drivers/net/af_xdp/version.map
delete mode 100644 drivers/net/ark/version.map
delete mode 100644 drivers/net/avp/version.map
delete mode 100644 drivers/net/axgbe/version.map
delete mode 100644 drivers/net/bnx2x/version.map
delete mode 100644 drivers/net/cxgbe/version.map
delete mode 100644 drivers/net/e1000/version.map
delete mode 100644 drivers/net/ena/version.map
delete mode 100644 drivers/net/enetc/version.map
delete mode 100644 drivers/net/enetfec/version.map
delete mode 100644 drivers/net/enic/version.map
delete mode 100644 drivers/net/failsafe/version.map
delete mode 100644 drivers/net/fm10k/version.map
delete mode 100644 drivers/net/hinic/version.map
delete mode 100644 drivers/net/hns3/version.map
delete mode 100644 drivers/net/igc/version.map
delete mode 100644 drivers/net/ionic/version.map
delete mode 100644 drivers/net/kni/version.map
delete mode 100644 drivers/net/liquidio/version.map
delete mode 100644 drivers/net/memif/version.map
delete mode 100644 drivers/net/mlx4/version.map
delete mode 100644 drivers/net/mvneta/version.map
delete mode 100644 drivers/net/mvpp2/version.map
delete mode 100644 drivers/net/netvsc/version.map
delete mode 100644 drivers/net/nfb/version.map
delete mode 100644 drivers/net/nfp/version.map
delete mode 100644 drivers/net/ngbe/version.map
delete mode 100644 drivers/net/null/version.map
delete mode 100644 drivers/net/octeon_ep/version.map
delete mode 100644 drivers/net/pcap/version.map
delete mode 100644 drivers/net/pfe/version.map
delete mode 100644 drivers/net/qede/version.map
delete mode 100644 drivers/net/sfc/version.map
delete mode 100644 drivers/net/tap/version.map
delete mode 100644 drivers/net/thunderx/version.map
delete mode 100644 drivers/net/txgbe/version.map
delete mode 100644 drivers/net/vdev_netvsc/version.map
delete mode 100644 drivers/net/virtio/version.map
delete mode 100644 drivers/net/vmxnet3/version.map
delete mode 100644 drivers/raw/cnxk_bphy/version.map
delete mode 100644 drivers/raw/cnxk_gpio/version.map
delete mode 100644 drivers/raw/dpaa2_cmdif/version.map
delete mode 100644 drivers/raw/ntb/version.map
delete mode 100644 drivers/raw/skeleton/version.map
delete mode 100644 drivers/regex/cn9k/version.map
delete mode 100644 drivers/regex/mlx5/version.map
delete mode 100644 drivers/vdpa/ifc/version.map
delete mode 100644 drivers/vdpa/mlx5/version.map
delete mode 100644 drivers/vdpa/sfc/version.map
diff --git a/drivers/baseband/la12xx/version.map b/drivers/baseband/la12xx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/la12xx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/null/version.map b/drivers/baseband/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/turbo_sw/version.map b/drivers/baseband/turbo_sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/turbo_sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/common/qat/version.map b/drivers/common/qat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/common/qat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/isal/version.map b/drivers/compress/isal/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/isal/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/mlx5/version.map b/drivers/compress/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/octeontx/version.map b/drivers/compress/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/zlib/version.map b/drivers/compress/zlib/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/zlib/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/armv8/version.map b/drivers/crypto/armv8/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/armv8/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/bcmfs/version.map b/drivers/crypto/bcmfs/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/bcmfs/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/caam_jr/version.map b/drivers/crypto/caam_jr/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/caam_jr/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ccp/version.map b/drivers/crypto/ccp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ccp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ipsec_mb/version.map b/drivers/crypto/ipsec_mb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ipsec_mb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mlx5/version.map b/drivers/crypto/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mvsam/version.map b/drivers/crypto/mvsam/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mvsam/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/nitrox/version.map b/drivers/crypto/nitrox/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/nitrox/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/null/version.map b/drivers/crypto/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/openssl/version.map b/drivers/crypto/openssl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/openssl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/virtio/version.map b/drivers/crypto/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/cnxk/version.map b/drivers/dma/cnxk/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/dpaa/version.map b/drivers/dma/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/hisilicon/version.map b/drivers/dma/hisilicon/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/hisilicon/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/idxd/version.map b/drivers/dma/idxd/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/idxd/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/ioat/version.map b/drivers/dma/ioat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/ioat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/skeleton/version.map b/drivers/dma/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/cnxk/version.map b/drivers/event/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/event/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/event/dpaa/version.map b/drivers/event/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dpaa2/version.map b/drivers/event/dpaa2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dsw/version.map b/drivers/event/dsw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dsw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/octeontx/version.map b/drivers/event/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/opdl/version.map b/drivers/event/opdl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/opdl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/skeleton/version.map b/drivers/event/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/sw/version.map b/drivers/event/sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/gpu/cuda/version.map b/drivers/gpu/cuda/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/gpu/cuda/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/bucket/version.map b/drivers/mempool/bucket/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/bucket/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/cnxk/version.map b/drivers/mempool/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/mempool/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/mempool/octeontx/version.map b/drivers/mempool/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/ring/version.map b/drivers/mempool/ring/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/ring/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/stack/version.map b/drivers/mempool/stack/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/stack/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_packet/version.map b/drivers/net/af_packet/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_packet/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_xdp/version.map b/drivers/net/af_xdp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_xdp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ark/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/avp/version.map b/drivers/net/avp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/avp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/axgbe/version.map b/drivers/net/axgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/axgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/bnx2x/version.map b/drivers/net/bnx2x/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/bnx2x/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/cxgbe/version.map b/drivers/net/cxgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/cxgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/e1000/version.map b/drivers/net/e1000/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/e1000/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ena/version.map b/drivers/net/ena/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ena/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetc/version.map b/drivers/net/enetc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetfec/version.map b/drivers/net/enetfec/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetfec/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enic/version.map b/drivers/net/enic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/failsafe/version.map b/drivers/net/failsafe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/failsafe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/fm10k/version.map b/drivers/net/fm10k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/fm10k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hinic/version.map b/drivers/net/hinic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hinic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hns3/version.map b/drivers/net/hns3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hns3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/igc/version.map b/drivers/net/igc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/igc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ionic/version.map b/drivers/net/ionic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ionic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/kni/version.map b/drivers/net/kni/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/kni/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/liquidio/version.map b/drivers/net/liquidio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/liquidio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/memif/version.map b/drivers/net/memif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/memif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mlx4/version.map b/drivers/net/mlx4/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mlx4/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvneta/version.map b/drivers/net/mvneta/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvneta/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvpp2/version.map b/drivers/net/mvpp2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvpp2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/netvsc/version.map b/drivers/net/netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfb/version.map b/drivers/net/nfb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfp/version.map b/drivers/net/nfp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ngbe/version.map b/drivers/net/ngbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ngbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/null/version.map b/drivers/net/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/octeon_ep/version.map b/drivers/net/octeon_ep/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/octeon_ep/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pcap/version.map b/drivers/net/pcap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pcap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pfe/version.map b/drivers/net/pfe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pfe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/qede/version.map b/drivers/net/qede/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/qede/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/sfc/version.map b/drivers/net/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/tap/version.map b/drivers/net/tap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/tap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/thunderx/version.map b/drivers/net/thunderx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/thunderx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/txgbe/version.map b/drivers/net/txgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/txgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vdev_netvsc/version.map b/drivers/net/vdev_netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vdev_netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/virtio/version.map b/drivers/net/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vmxnet3/version.map b/drivers/net/vmxnet3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vmxnet3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_bphy/version.map b/drivers/raw/cnxk_bphy/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_bphy/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_gpio/version.map b/drivers/raw/cnxk_gpio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_gpio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/dpaa2_cmdif/version.map b/drivers/raw/dpaa2_cmdif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/dpaa2_cmdif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/ntb/version.map b/drivers/raw/ntb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/ntb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/skeleton/version.map b/drivers/raw/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/cn9k/version.map b/drivers/regex/cn9k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/cn9k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/mlx5/version.map b/drivers/regex/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/ifc/version.map b/drivers/vdpa/ifc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/ifc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/mlx5/version.map b/drivers/vdpa/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH 1/2] drivers: suggestion on meson without version file
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
2022-10-06 7:19 ` [PATCH 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
@ 2022-10-07 10:30 ` Bruce Richardson
2022-10-10 7:41 ` Omer Yamac
1 sibling, 1 reply; 22+ messages in thread
From: Bruce Richardson @ 2022-10-07 10:30 UTC (permalink / raw)
To: Abdullah Ömer Yamaç; +Cc: dev, Ferruh Yigit
The title of this patch needs an update - I would suggest something
like:
"build: make version file optional for drivers"
More comments inline below.
On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yamaç wrote:
> Most of the drivers don't have a special version.map file. They just
> included due to the compilation issue and needs to be updated for each
> release.
>
> These version.map files include:
> DPDK_23 {
> local: *;
> };
>
> In this patch, we removed the necessity of the version files and
> you don't need to update these files for each release, you can just
> remove them.
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> ---
> Depends on: patch-116222 ("build: increase minimum meson version to 0.53")
> ---
Thanks for splitting the patch. It is a lot easier to review now,
especially if we apply and use "diff -w".
For any other reviewers, the "diff -w" for this patch is:
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
+fs = import('fs')
+
# Defines the order of dependencies evaluation
subdirs = [
'common',
@@ -193,6 +195,7 @@ foreach subpath:subdirs
version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
implib = 'lib' + lib_name + '.dll.a'
+ if fs.is_file(version_map)
def_file = custom_target(lib_name + '_def',
command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
input: version_map,
@@ -227,6 +230,8 @@ foreach subpath:subdirs
endif
endif
+ endif
+
shared_lib = shared_library(lib_name, sources,
objects: objs,
include_directories: includes,
> drivers/meson.build | 63 ++++++++++++++++++++++++---------------------
> 1 file changed, 34 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/meson.build b/drivers/meson.build
> index f6ba5ba4fb..6ef03e14c7 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -1,6 +1,8 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017-2019 Intel Corporation
>
> +fs = import('fs')
> +
> # Defines the order of dependencies evaluation
> subdirs = [
> 'common',
> @@ -193,38 +195,41 @@ foreach subpath:subdirs
> version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
> implib = 'lib' + lib_name + '.dll.a'
>
<snip>
> + capture: true,
> + input: static_lib,
> + output: lib_name + '.sym_chk')
> + endif
> endif
> +
> endif
>
> shared_lib = shared_library(lib_name, sources,
Beware that the shared_lib calls use both lk_deps and lk_args parameters,
which are only set inside the "if" block you added.
This will cause problems in that:
1. If the first driver doesn't have a version.map file, these variables
will be undefined and you'll get a build error.
2. For any subsequent drivers that don't have a version.map file, the old
values of the variables from the previous driver will be used.
Therefore, at the start of processing each driver, you need to assign empty
values to these variable.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH 1/2] drivers: suggestion on meson without version file
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
@ 2022-10-10 7:41 ` Omer Yamac
2022-10-10 8:34 ` Bruce Richardson
0 siblings, 1 reply; 22+ messages in thread
From: Omer Yamac @ 2022-10-10 7:41 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Ferruh Yigit
On 07.10.2022 13:30, Bruce Richardson wrote:
> The title of this patch needs an update - I would suggest something
> like:
>
> "build: make version file optional for drivers"
Thank you, it will make more sense
>
> More comments inline below.
>
> On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yamaç wrote:
>> Most of the drivers don't have a special version.map file. They just
>> included due to the compilation issue and needs to be updated for each
>> release.
>>
>> These version.map files include:
>> DPDK_23 {
>> local: *;
>> };
>>
>> In this patch, we removed the necessity of the version files and
>> you don't need to update these files for each release, you can just
>> remove them.
>>
>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>
>> ---
>> Depends on: patch-116222 ("build: increase minimum meson version to
>> 0.53")
>> ---
>
> Thanks for splitting the patch. It is a lot easier to review now,
> especially if we apply and use "diff -w".
>
> For any other reviewers, the "diff -w" for this patch is:
>
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -1,6 +1,8 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017-2019 Intel Corporation
>
> +fs = import('fs')
> +
> # Defines the order of dependencies evaluation
> subdirs = [
> 'common',
> @@ -193,6 +195,7 @@ foreach subpath:subdirs
> version_map =
> '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
> implib = 'lib' + lib_name + '.dll.a'
>
> + if fs.is_file(version_map)
> def_file = custom_target(lib_name + '_def',
> command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
> input: version_map,
> @@ -227,6 +230,8 @@ foreach subpath:subdirs
> endif
> endif
>
> + endif
> +
> shared_lib = shared_library(lib_name, sources,
> objects: objs,
> include_directories: includes,
>
>
>> drivers/meson.build | 63
>> ++++++++++++++++++++++++---------------------
>> 1 file changed, 34 insertions(+), 29 deletions(-)
>>
>> diff --git a/drivers/meson.build b/drivers/meson.build
>> index f6ba5ba4fb..6ef03e14c7 100644
>> --- a/drivers/meson.build
>> +++ b/drivers/meson.build
>> @@ -1,6 +1,8 @@
>> # SPDX-License-Identifier: BSD-3-Clause
>> # Copyright(c) 2017-2019 Intel Corporation
>>
>> +fs = import('fs')
>> +
>> # Defines the order of dependencies evaluation
>> subdirs = [
>> 'common',
>> @@ -193,38 +195,41 @@ foreach subpath:subdirs
>> version_map =
>> '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
>> implib = 'lib' + lib_name + '.dll.a'
>>
> <snip>
>> + capture: true,
>> + input: static_lib,
>> + output: lib_name + '.sym_chk')
>> + endif
>> endif
>> +
>> endif
>>
>> shared_lib = shared_library(lib_name, sources,
>
> Beware that the shared_lib calls use both lk_deps and lk_args
> parameters,
> which are only set inside the "if" block you added.
> This will cause problems in that:
> 1. If the first driver doesn't have a version.map file, these variables
> will be undefined and you'll get a build error.
> 2. For any subsequent drivers that don't have a version.map file, the
> old
> values of the variables from the previous driver will be used.
>
You're right, I missed that part and I will add a "else condition" to
set variables as empty. Then everything is OK?
> Therefore, at the start of processing each driver, you need to assign
> empty
> values to these variable.
>
> Regards,
> /Bruce
Thank you
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH 1/2] drivers: suggestion on meson without version file
2022-10-10 7:41 ` Omer Yamac
@ 2022-10-10 8:34 ` Bruce Richardson
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
0 siblings, 1 reply; 22+ messages in thread
From: Bruce Richardson @ 2022-10-10 8:34 UTC (permalink / raw)
To: Omer Yamac; +Cc: dev, Ferruh Yigit
On Mon, Oct 10, 2022 at 10:41:57AM +0300, Omer Yamac wrote:
>
<snip>
> > Beware that the shared_lib calls use both lk_deps and lk_args
> > parameters,
> > which are only set inside the "if" block you added.
> > This will cause problems in that:
> > 1. If the first driver doesn't have a version.map file, these variables
> > will be undefined and you'll get a build error.
> > 2. For any subsequent drivers that don't have a version.map file, the
> > old
> > values of the variables from the previous driver will be used.
> >
> You're right, I missed that part and I will add a "else condition" to set
> variables as empty. Then everything is OK?
Don't add an "else" leg as it will complicate things. Instead, initialize
them to empty at the start of the per-driver block, where we initialize
the other variables. It doesn't matter having them assigned twice in the
one block.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 1/2] build: make version file optional for drivers
2022-10-10 8:34 ` Bruce Richardson
@ 2022-10-11 11:08 ` Abdullah Ömer Yamaç
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-11 12:00 ` [PATCH v2 " Bruce Richardson
0 siblings, 2 replies; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-11 11:08 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit
In this patch, we removed the necessity of the version files and
you don't need to update these files for each release, you can just
remove them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Depends on: patch-116222 ("build: increase minimum meson version to 0.53")
---
drivers/meson.build | 67 +++++++++++++++++++++++++--------------------
1 file changed, 37 insertions(+), 30 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index 216971f4e2..b5856b963b 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
+fs = import('fs')
+
# Defines the order of dependencies evaluation
subdirs = [
'common',
@@ -201,39 +203,44 @@ foreach subpath:subdirs
# now build the shared driver
version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
implib = 'lib' + lib_name + '.dll.a'
-
- def_file = custom_target(lib_name + '_def',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_exports.def'.format(lib_name))
-
- mingw_map = custom_target(lib_name + '_mingw',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_mingw.map'.format(lib_name))
-
- lk_deps = [version_map, def_file, mingw_map]
- if is_windows
- if is_ms_linker
- lk_args = ['-Wl,/def:' + def_file.full_path()]
- if meson.version().version_compare('<0.54.0')
- lk_args += ['-Wl,/implib:drivers\\' + implib]
+
+ lk_deps = []
+ lk_args = []
+ if fs.is_file(version_map)
+ def_file = custom_target(lib_name + '_def',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_exports.def'.format(lib_name))
+
+ mingw_map = custom_target(lib_name + '_mingw',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_mingw.map'.format(lib_name))
+
+ lk_deps = [version_map, def_file, mingw_map]
+ if is_windows
+ if is_ms_linker
+ lk_args = ['-Wl,/def:' + def_file.full_path()]
+ if meson.version().version_compare('<0.54.0')
+ lk_args += ['-Wl,/implib:drivers\\' + implib]
+ endif
+ else
+ lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
endif
else
- lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
- endif
- else
- lk_args = ['-Wl,--version-script=' + version_map]
- if developer_mode
- # on unix systems check the output of the
- # check-symbols.sh script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.sym_chk',
- command: [check_symbols, version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.sym_chk')
+ lk_args = ['-Wl,--version-script=' + version_map]
+ if developer_mode
+ # on unix systems check the output of the
+ # check-symbols.sh script, using it as a
+ # dependency of the .so build
+ lk_deps += custom_target(lib_name + '.sym_chk',
+ command: [check_symbols, version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.sym_chk')
+ endif
endif
+
endif
shared_lib = shared_library(lib_name, sources,
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH v2 2/2] drivers: remove the unnecessary version.map
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
@ 2022-10-11 11:08 ` Abdullah Ömer Yamaç
2022-10-11 13:10 ` David Marchand
2022-10-11 12:00 ` [PATCH v2 " Bruce Richardson
1 sibling, 1 reply; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-11 11:08 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit
With the previous patch, some version.map files are not necessary.
In this patch, we removed them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Depends on: patch-116222 ("build: increase minimum meson version to 0.53")
---
drivers/baseband/la12xx/version.map | 3 ---
drivers/baseband/null/version.map | 3 ---
drivers/baseband/turbo_sw/version.map | 3 ---
drivers/common/qat/version.map | 3 ---
drivers/compress/isal/version.map | 3 ---
drivers/compress/mlx5/version.map | 3 ---
drivers/compress/octeontx/version.map | 3 ---
drivers/compress/zlib/version.map | 3 ---
drivers/crypto/armv8/version.map | 3 ---
drivers/crypto/bcmfs/version.map | 3 ---
drivers/crypto/caam_jr/version.map | 3 ---
drivers/crypto/ccp/version.map | 3 ---
drivers/crypto/ipsec_mb/version.map | 3 ---
drivers/crypto/mlx5/version.map | 3 ---
drivers/crypto/mvsam/version.map | 3 ---
drivers/crypto/nitrox/version.map | 3 ---
drivers/crypto/null/version.map | 3 ---
drivers/crypto/openssl/version.map | 3 ---
drivers/crypto/virtio/version.map | 3 ---
drivers/dma/cnxk/version.map | 3 ---
drivers/dma/dpaa/version.map | 3 ---
drivers/dma/hisilicon/version.map | 3 ---
drivers/dma/idxd/version.map | 3 ---
drivers/dma/ioat/version.map | 3 ---
drivers/dma/skeleton/version.map | 3 ---
drivers/event/cnxk/version.map | 3 ---
drivers/event/dpaa/version.map | 3 ---
drivers/event/dpaa2/version.map | 3 ---
drivers/event/dsw/version.map | 3 ---
drivers/event/octeontx/version.map | 3 ---
drivers/event/opdl/version.map | 3 ---
drivers/event/skeleton/version.map | 3 ---
drivers/event/sw/version.map | 3 ---
drivers/gpu/cuda/version.map | 3 ---
drivers/mempool/bucket/version.map | 3 ---
drivers/mempool/cnxk/version.map | 3 ---
drivers/mempool/octeontx/version.map | 3 ---
drivers/mempool/ring/version.map | 3 ---
drivers/mempool/stack/version.map | 3 ---
drivers/net/af_packet/version.map | 3 ---
drivers/net/af_xdp/version.map | 3 ---
drivers/net/ark/version.map | 3 ---
drivers/net/avp/version.map | 3 ---
drivers/net/axgbe/version.map | 3 ---
drivers/net/bnx2x/version.map | 3 ---
drivers/net/cxgbe/version.map | 3 ---
drivers/net/e1000/version.map | 3 ---
drivers/net/ena/version.map | 3 ---
drivers/net/enetc/version.map | 3 ---
drivers/net/enetfec/version.map | 3 ---
drivers/net/enic/version.map | 3 ---
drivers/net/failsafe/version.map | 3 ---
drivers/net/fm10k/version.map | 3 ---
drivers/net/hinic/version.map | 3 ---
drivers/net/hns3/version.map | 3 ---
drivers/net/igc/version.map | 3 ---
drivers/net/ionic/version.map | 3 ---
drivers/net/kni/version.map | 3 ---
drivers/net/liquidio/version.map | 3 ---
drivers/net/memif/version.map | 3 ---
drivers/net/mlx4/version.map | 3 ---
drivers/net/mvneta/version.map | 3 ---
drivers/net/mvpp2/version.map | 3 ---
drivers/net/netvsc/version.map | 3 ---
drivers/net/nfb/version.map | 3 ---
drivers/net/nfp/version.map | 3 ---
drivers/net/ngbe/version.map | 3 ---
drivers/net/null/version.map | 3 ---
drivers/net/octeon_ep/version.map | 3 ---
drivers/net/pcap/version.map | 3 ---
drivers/net/pfe/version.map | 3 ---
drivers/net/qede/version.map | 3 ---
drivers/net/sfc/version.map | 3 ---
drivers/net/tap/version.map | 3 ---
drivers/net/thunderx/version.map | 3 ---
drivers/net/txgbe/version.map | 3 ---
drivers/net/vdev_netvsc/version.map | 3 ---
drivers/net/virtio/version.map | 3 ---
drivers/net/vmxnet3/version.map | 3 ---
drivers/raw/cnxk_bphy/version.map | 3 ---
drivers/raw/cnxk_gpio/version.map | 3 ---
drivers/raw/dpaa2_cmdif/version.map | 3 ---
drivers/raw/ntb/version.map | 3 ---
drivers/raw/skeleton/version.map | 3 ---
drivers/regex/cn9k/version.map | 3 ---
drivers/regex/mlx5/version.map | 3 ---
drivers/vdpa/ifc/version.map | 3 ---
drivers/vdpa/mlx5/version.map | 3 ---
drivers/vdpa/sfc/version.map | 3 ---
89 files changed, 267 deletions(-)
delete mode 100644 drivers/baseband/la12xx/version.map
delete mode 100644 drivers/baseband/null/version.map
delete mode 100644 drivers/baseband/turbo_sw/version.map
delete mode 100644 drivers/common/qat/version.map
delete mode 100644 drivers/compress/isal/version.map
delete mode 100644 drivers/compress/mlx5/version.map
delete mode 100644 drivers/compress/octeontx/version.map
delete mode 100644 drivers/compress/zlib/version.map
delete mode 100644 drivers/crypto/armv8/version.map
delete mode 100644 drivers/crypto/bcmfs/version.map
delete mode 100644 drivers/crypto/caam_jr/version.map
delete mode 100644 drivers/crypto/ccp/version.map
delete mode 100644 drivers/crypto/ipsec_mb/version.map
delete mode 100644 drivers/crypto/mlx5/version.map
delete mode 100644 drivers/crypto/mvsam/version.map
delete mode 100644 drivers/crypto/nitrox/version.map
delete mode 100644 drivers/crypto/null/version.map
delete mode 100644 drivers/crypto/openssl/version.map
delete mode 100644 drivers/crypto/virtio/version.map
delete mode 100644 drivers/dma/cnxk/version.map
delete mode 100644 drivers/dma/dpaa/version.map
delete mode 100644 drivers/dma/hisilicon/version.map
delete mode 100644 drivers/dma/idxd/version.map
delete mode 100644 drivers/dma/ioat/version.map
delete mode 100644 drivers/dma/skeleton/version.map
delete mode 100644 drivers/event/cnxk/version.map
delete mode 100644 drivers/event/dpaa/version.map
delete mode 100644 drivers/event/dpaa2/version.map
delete mode 100644 drivers/event/dsw/version.map
delete mode 100644 drivers/event/octeontx/version.map
delete mode 100644 drivers/event/opdl/version.map
delete mode 100644 drivers/event/skeleton/version.map
delete mode 100644 drivers/event/sw/version.map
delete mode 100644 drivers/gpu/cuda/version.map
delete mode 100644 drivers/mempool/bucket/version.map
delete mode 100644 drivers/mempool/cnxk/version.map
delete mode 100644 drivers/mempool/octeontx/version.map
delete mode 100644 drivers/mempool/ring/version.map
delete mode 100644 drivers/mempool/stack/version.map
delete mode 100644 drivers/net/af_packet/version.map
delete mode 100644 drivers/net/af_xdp/version.map
delete mode 100644 drivers/net/ark/version.map
delete mode 100644 drivers/net/avp/version.map
delete mode 100644 drivers/net/axgbe/version.map
delete mode 100644 drivers/net/bnx2x/version.map
delete mode 100644 drivers/net/cxgbe/version.map
delete mode 100644 drivers/net/e1000/version.map
delete mode 100644 drivers/net/ena/version.map
delete mode 100644 drivers/net/enetc/version.map
delete mode 100644 drivers/net/enetfec/version.map
delete mode 100644 drivers/net/enic/version.map
delete mode 100644 drivers/net/failsafe/version.map
delete mode 100644 drivers/net/fm10k/version.map
delete mode 100644 drivers/net/hinic/version.map
delete mode 100644 drivers/net/hns3/version.map
delete mode 100644 drivers/net/igc/version.map
delete mode 100644 drivers/net/ionic/version.map
delete mode 100644 drivers/net/kni/version.map
delete mode 100644 drivers/net/liquidio/version.map
delete mode 100644 drivers/net/memif/version.map
delete mode 100644 drivers/net/mlx4/version.map
delete mode 100644 drivers/net/mvneta/version.map
delete mode 100644 drivers/net/mvpp2/version.map
delete mode 100644 drivers/net/netvsc/version.map
delete mode 100644 drivers/net/nfb/version.map
delete mode 100644 drivers/net/nfp/version.map
delete mode 100644 drivers/net/ngbe/version.map
delete mode 100644 drivers/net/null/version.map
delete mode 100644 drivers/net/octeon_ep/version.map
delete mode 100644 drivers/net/pcap/version.map
delete mode 100644 drivers/net/pfe/version.map
delete mode 100644 drivers/net/qede/version.map
delete mode 100644 drivers/net/sfc/version.map
delete mode 100644 drivers/net/tap/version.map
delete mode 100644 drivers/net/thunderx/version.map
delete mode 100644 drivers/net/txgbe/version.map
delete mode 100644 drivers/net/vdev_netvsc/version.map
delete mode 100644 drivers/net/virtio/version.map
delete mode 100644 drivers/net/vmxnet3/version.map
delete mode 100644 drivers/raw/cnxk_bphy/version.map
delete mode 100644 drivers/raw/cnxk_gpio/version.map
delete mode 100644 drivers/raw/dpaa2_cmdif/version.map
delete mode 100644 drivers/raw/ntb/version.map
delete mode 100644 drivers/raw/skeleton/version.map
delete mode 100644 drivers/regex/cn9k/version.map
delete mode 100644 drivers/regex/mlx5/version.map
delete mode 100644 drivers/vdpa/ifc/version.map
delete mode 100644 drivers/vdpa/mlx5/version.map
delete mode 100644 drivers/vdpa/sfc/version.map
diff --git a/drivers/baseband/la12xx/version.map b/drivers/baseband/la12xx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/la12xx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/null/version.map b/drivers/baseband/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/turbo_sw/version.map b/drivers/baseband/turbo_sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/turbo_sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/common/qat/version.map b/drivers/common/qat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/common/qat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/isal/version.map b/drivers/compress/isal/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/isal/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/mlx5/version.map b/drivers/compress/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/octeontx/version.map b/drivers/compress/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/zlib/version.map b/drivers/compress/zlib/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/zlib/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/armv8/version.map b/drivers/crypto/armv8/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/armv8/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/bcmfs/version.map b/drivers/crypto/bcmfs/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/bcmfs/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/caam_jr/version.map b/drivers/crypto/caam_jr/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/caam_jr/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ccp/version.map b/drivers/crypto/ccp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ccp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ipsec_mb/version.map b/drivers/crypto/ipsec_mb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ipsec_mb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mlx5/version.map b/drivers/crypto/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mvsam/version.map b/drivers/crypto/mvsam/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mvsam/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/nitrox/version.map b/drivers/crypto/nitrox/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/nitrox/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/null/version.map b/drivers/crypto/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/openssl/version.map b/drivers/crypto/openssl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/openssl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/virtio/version.map b/drivers/crypto/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/cnxk/version.map b/drivers/dma/cnxk/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/dpaa/version.map b/drivers/dma/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/hisilicon/version.map b/drivers/dma/hisilicon/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/hisilicon/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/idxd/version.map b/drivers/dma/idxd/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/idxd/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/ioat/version.map b/drivers/dma/ioat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/ioat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/skeleton/version.map b/drivers/dma/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/cnxk/version.map b/drivers/event/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/event/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/event/dpaa/version.map b/drivers/event/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dpaa2/version.map b/drivers/event/dpaa2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dsw/version.map b/drivers/event/dsw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dsw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/octeontx/version.map b/drivers/event/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/opdl/version.map b/drivers/event/opdl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/opdl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/skeleton/version.map b/drivers/event/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/sw/version.map b/drivers/event/sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/gpu/cuda/version.map b/drivers/gpu/cuda/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/gpu/cuda/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/bucket/version.map b/drivers/mempool/bucket/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/bucket/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/cnxk/version.map b/drivers/mempool/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/mempool/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/mempool/octeontx/version.map b/drivers/mempool/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/ring/version.map b/drivers/mempool/ring/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/ring/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/stack/version.map b/drivers/mempool/stack/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/stack/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_packet/version.map b/drivers/net/af_packet/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_packet/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_xdp/version.map b/drivers/net/af_xdp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_xdp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ark/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/avp/version.map b/drivers/net/avp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/avp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/axgbe/version.map b/drivers/net/axgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/axgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/bnx2x/version.map b/drivers/net/bnx2x/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/bnx2x/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/cxgbe/version.map b/drivers/net/cxgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/cxgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/e1000/version.map b/drivers/net/e1000/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/e1000/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ena/version.map b/drivers/net/ena/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ena/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetc/version.map b/drivers/net/enetc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetfec/version.map b/drivers/net/enetfec/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetfec/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enic/version.map b/drivers/net/enic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/failsafe/version.map b/drivers/net/failsafe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/failsafe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/fm10k/version.map b/drivers/net/fm10k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/fm10k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hinic/version.map b/drivers/net/hinic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hinic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hns3/version.map b/drivers/net/hns3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hns3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/igc/version.map b/drivers/net/igc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/igc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ionic/version.map b/drivers/net/ionic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ionic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/kni/version.map b/drivers/net/kni/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/kni/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/liquidio/version.map b/drivers/net/liquidio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/liquidio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/memif/version.map b/drivers/net/memif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/memif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mlx4/version.map b/drivers/net/mlx4/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mlx4/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvneta/version.map b/drivers/net/mvneta/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvneta/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvpp2/version.map b/drivers/net/mvpp2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvpp2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/netvsc/version.map b/drivers/net/netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfb/version.map b/drivers/net/nfb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfp/version.map b/drivers/net/nfp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ngbe/version.map b/drivers/net/ngbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ngbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/null/version.map b/drivers/net/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/octeon_ep/version.map b/drivers/net/octeon_ep/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/octeon_ep/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pcap/version.map b/drivers/net/pcap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pcap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pfe/version.map b/drivers/net/pfe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pfe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/qede/version.map b/drivers/net/qede/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/qede/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/sfc/version.map b/drivers/net/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/tap/version.map b/drivers/net/tap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/tap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/thunderx/version.map b/drivers/net/thunderx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/thunderx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/txgbe/version.map b/drivers/net/txgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/txgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vdev_netvsc/version.map b/drivers/net/vdev_netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vdev_netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/virtio/version.map b/drivers/net/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vmxnet3/version.map b/drivers/net/vmxnet3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vmxnet3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_bphy/version.map b/drivers/raw/cnxk_bphy/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_bphy/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_gpio/version.map b/drivers/raw/cnxk_gpio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_gpio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/dpaa2_cmdif/version.map b/drivers/raw/dpaa2_cmdif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/dpaa2_cmdif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/ntb/version.map b/drivers/raw/ntb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/ntb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/skeleton/version.map b/drivers/raw/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/cn9k/version.map b/drivers/regex/cn9k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/cn9k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/mlx5/version.map b/drivers/regex/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/ifc/version.map b/drivers/vdpa/ifc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/ifc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/mlx5/version.map b/drivers/vdpa/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v2 2/2] drivers: remove the unnecessary version.map
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
@ 2022-10-11 13:10 ` David Marchand
2022-10-11 19:21 ` Omer Yamac
0 siblings, 1 reply; 22+ messages in thread
From: David Marchand @ 2022-10-11 13:10 UTC (permalink / raw)
To: Abdullah Ömer Yamaç
Cc: dev, Ferruh Yigit, Bruce Richardson, Thomas Monjalon
On Tue, Oct 11, 2022 at 1:09 PM Abdullah Ömer Yamaç
<omer.yamac@ceng.metu.edu.tr> wrote:
>
> With the previous patch, some version.map files are not necessary.
> In this patch, we removed them.
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
I'd like some check added as part of this series.
Something like:
$ git diff
diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
index 32e1fa5c8f..9d2f85ed73 100755
--- a/devtools/check-symbol-maps.sh
+++ b/devtools/check-symbol-maps.sh
@@ -60,4 +60,18 @@ if [ -n "$local_miss_maps" ] ; then
ret=1
fi
+find_unneeded_maps ()
+{
+ for map in $@ ; do
+ [ $(buildtools/map-list-symbol.sh $map | wc -l) != 0 ] || echo $map
+ done
+}
+
+unneeded_maps=$(find_unneeded_maps $@)
+if [ -n "$unneeded_maps" ] ; then
+ echo "Found unneeded map files:"
+ echo "$unneeded_maps"
+ ret=1
+fi
+
exit $ret
It helped me catch:
$ ./devtools/check-symbol-maps.sh
Found unneeded map files:
drivers/net/mana/version.map
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v2 2/2] drivers: remove the unnecessary version.map
2022-10-11 13:10 ` David Marchand
@ 2022-10-11 19:21 ` Omer Yamac
2022-10-12 10:29 ` [PATCH v3 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
0 siblings, 1 reply; 22+ messages in thread
From: Omer Yamac @ 2022-10-11 19:21 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Ferruh Yigit, Bruce Richardson, Thomas Monjalon
On 11.10.2022 16:10, David Marchand wrote:
> On Tue, Oct 11, 2022 at 1:09 PM Abdullah Ömer Yamaç
> <omer.yamac@ceng.metu.edu.tr> wrote:
>>
>> With the previous patch, some version.map files are not necessary.
>> In this patch, we removed them.
>>
>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> I'd like some check added as part of this series.
Thank you for this patch.
> Something like:
>
> $ git diff
> diff --git a/devtools/check-symbol-maps.sh
> b/devtools/check-symbol-maps.sh
> index 32e1fa5c8f..9d2f85ed73 100755
> --- a/devtools/check-symbol-maps.sh
> +++ b/devtools/check-symbol-maps.sh
> @@ -60,4 +60,18 @@ if [ -n "$local_miss_maps" ] ; then
> ret=1
> fi
>
> +find_unneeded_maps ()
> +{
> + for map in $@ ; do
> + [ $(buildtools/map-list-symbol.sh $map | wc -l) != 0 ] || echo
> $map
> + done
> +}
> +
> +unneeded_maps=$(find_unneeded_maps $@)
> +if [ -n "$unneeded_maps" ] ; then
> + echo "Found unneeded map files:"
> + echo "$unneeded_maps"
> + ret=1
> +fi
> +
> exit $ret
>
>
> It helped me catch:
>
> $ ./devtools/check-symbol-maps.sh
> Found unneeded map files:
> drivers/net/mana/version.map
That’s my fault, I forgot to rebase my local repo. Thanks
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH v3 1/2] build: make version file optional for drivers
2022-10-11 19:21 ` Omer Yamac
@ 2022-10-12 10:29 ` Abdullah Ömer Yamaç
2022-10-12 10:29 ` [PATCH v3 2/2] " Abdullah Ömer Yamaç
0 siblings, 1 reply; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-12 10:29 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit, Bruce Richardson
In this patch, we removed the necessity of the version files and
you don't need to update these files for each release, you can just
remove them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/meson.build | 65 +++++++++++++++++++++++++--------------------
1 file changed, 36 insertions(+), 29 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index 216971f4e2..c0f3ec4037 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
+fs = import('fs')
+
# Defines the order of dependencies evaluation
subdirs = [
'common',
@@ -202,38 +204,43 @@ foreach subpath:subdirs
version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
implib = 'lib' + lib_name + '.dll.a'
- def_file = custom_target(lib_name + '_def',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_exports.def'.format(lib_name))
-
- mingw_map = custom_target(lib_name + '_mingw',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_mingw.map'.format(lib_name))
-
- lk_deps = [version_map, def_file, mingw_map]
- if is_windows
- if is_ms_linker
- lk_args = ['-Wl,/def:' + def_file.full_path()]
- if meson.version().version_compare('<0.54.0')
- lk_args += ['-Wl,/implib:drivers\\' + implib]
+ lk_deps = []
+ lk_args = []
+ if fs.is_file(version_map)
+ def_file = custom_target(lib_name + '_def',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_exports.def'.format(lib_name))
+
+ mingw_map = custom_target(lib_name + '_mingw',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_mingw.map'.format(lib_name))
+
+ lk_deps = [version_map, def_file, mingw_map]
+ if is_windows
+ if is_ms_linker
+ lk_args = ['-Wl,/def:' + def_file.full_path()]
+ if meson.version().version_compare('<0.54.0')
+ lk_args += ['-Wl,/implib:drivers\\' + implib]
+ endif
+ else
+ lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
endif
else
- lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
- endif
- else
- lk_args = ['-Wl,--version-script=' + version_map]
- if developer_mode
- # on unix systems check the output of the
- # check-symbols.sh script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.sym_chk',
- command: [check_symbols, version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.sym_chk')
+ lk_args = ['-Wl,--version-script=' + version_map]
+ if developer_mode
+ # on unix systems check the output of the
+ # check-symbols.sh script, using it as a
+ # dependency of the .so build
+ lk_deps += custom_target(lib_name + '.sym_chk',
+ command: [check_symbols, version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.sym_chk')
+ endif
endif
+
endif
shared_lib = shared_library(lib_name, sources,
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH v3 2/2] build: make version file optional for drivers
2022-10-12 10:29 ` [PATCH v3 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
@ 2022-10-12 10:29 ` Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
0 siblings, 1 reply; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-12 10:29 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit, Bruce Richardson
In this patch, we removed the necessity of the version files and
you don't need to update these files for each release, you can just
remove them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/baseband/la12xx/version.map | 3 ---
drivers/baseband/null/version.map | 3 ---
drivers/baseband/turbo_sw/version.map | 3 ---
drivers/common/qat/version.map | 3 ---
drivers/compress/isal/version.map | 3 ---
drivers/compress/mlx5/version.map | 3 ---
drivers/compress/octeontx/version.map | 3 ---
drivers/compress/zlib/version.map | 3 ---
drivers/crypto/armv8/version.map | 3 ---
drivers/crypto/bcmfs/version.map | 3 ---
drivers/crypto/caam_jr/version.map | 3 ---
drivers/crypto/ccp/version.map | 3 ---
drivers/crypto/ipsec_mb/version.map | 3 ---
drivers/crypto/mlx5/version.map | 3 ---
drivers/crypto/mvsam/version.map | 3 ---
drivers/crypto/nitrox/version.map | 3 ---
drivers/crypto/null/version.map | 3 ---
drivers/crypto/openssl/version.map | 3 ---
drivers/crypto/virtio/version.map | 3 ---
drivers/dma/cnxk/version.map | 3 ---
drivers/dma/dpaa/version.map | 3 ---
drivers/dma/hisilicon/version.map | 3 ---
drivers/dma/idxd/version.map | 3 ---
drivers/dma/ioat/version.map | 3 ---
drivers/dma/skeleton/version.map | 3 ---
drivers/event/cnxk/version.map | 3 ---
drivers/event/dpaa/version.map | 3 ---
drivers/event/dpaa2/version.map | 3 ---
drivers/event/dsw/version.map | 3 ---
drivers/event/octeontx/version.map | 3 ---
drivers/event/opdl/version.map | 3 ---
drivers/event/skeleton/version.map | 3 ---
drivers/event/sw/version.map | 3 ---
drivers/gpu/cuda/version.map | 3 ---
drivers/mempool/bucket/version.map | 3 ---
drivers/mempool/cnxk/version.map | 3 ---
drivers/mempool/octeontx/version.map | 3 ---
drivers/mempool/ring/version.map | 3 ---
drivers/mempool/stack/version.map | 3 ---
drivers/net/af_packet/version.map | 3 ---
drivers/net/af_xdp/version.map | 3 ---
drivers/net/ark/version.map | 3 ---
drivers/net/avp/version.map | 3 ---
drivers/net/axgbe/version.map | 3 ---
drivers/net/bnx2x/version.map | 3 ---
drivers/net/cxgbe/version.map | 3 ---
drivers/net/e1000/version.map | 3 ---
drivers/net/ena/version.map | 3 ---
drivers/net/enetc/version.map | 3 ---
drivers/net/enetfec/version.map | 3 ---
drivers/net/enic/version.map | 3 ---
drivers/net/failsafe/version.map | 3 ---
drivers/net/fm10k/version.map | 3 ---
drivers/net/hinic/version.map | 3 ---
drivers/net/hns3/version.map | 3 ---
drivers/net/igc/version.map | 3 ---
drivers/net/ionic/version.map | 3 ---
drivers/net/kni/version.map | 3 ---
drivers/net/liquidio/version.map | 3 ---
drivers/net/mana/version.map | 3 ---
drivers/net/memif/version.map | 3 ---
drivers/net/mlx4/version.map | 3 ---
drivers/net/mvneta/version.map | 3 ---
drivers/net/mvpp2/version.map | 3 ---
drivers/net/netvsc/version.map | 3 ---
drivers/net/nfb/version.map | 3 ---
drivers/net/nfp/version.map | 3 ---
drivers/net/ngbe/version.map | 3 ---
drivers/net/null/version.map | 3 ---
drivers/net/octeon_ep/version.map | 3 ---
drivers/net/pcap/version.map | 3 ---
drivers/net/pfe/version.map | 3 ---
drivers/net/qede/version.map | 3 ---
drivers/net/sfc/version.map | 3 ---
drivers/net/tap/version.map | 3 ---
drivers/net/thunderx/version.map | 3 ---
drivers/net/txgbe/version.map | 3 ---
drivers/net/vdev_netvsc/version.map | 3 ---
drivers/net/virtio/version.map | 3 ---
drivers/net/vmxnet3/version.map | 3 ---
drivers/raw/cnxk_bphy/version.map | 3 ---
drivers/raw/cnxk_gpio/version.map | 3 ---
drivers/raw/dpaa2_cmdif/version.map | 3 ---
drivers/raw/ntb/version.map | 3 ---
drivers/raw/skeleton/version.map | 3 ---
drivers/regex/cn9k/version.map | 3 ---
drivers/regex/mlx5/version.map | 3 ---
drivers/vdpa/ifc/version.map | 3 ---
drivers/vdpa/mlx5/version.map | 3 ---
drivers/vdpa/sfc/version.map | 3 ---
90 files changed, 270 deletions(-)
delete mode 100644 drivers/baseband/la12xx/version.map
delete mode 100644 drivers/baseband/null/version.map
delete mode 100644 drivers/baseband/turbo_sw/version.map
delete mode 100644 drivers/common/qat/version.map
delete mode 100644 drivers/compress/isal/version.map
delete mode 100644 drivers/compress/mlx5/version.map
delete mode 100644 drivers/compress/octeontx/version.map
delete mode 100644 drivers/compress/zlib/version.map
delete mode 100644 drivers/crypto/armv8/version.map
delete mode 100644 drivers/crypto/bcmfs/version.map
delete mode 100644 drivers/crypto/caam_jr/version.map
delete mode 100644 drivers/crypto/ccp/version.map
delete mode 100644 drivers/crypto/ipsec_mb/version.map
delete mode 100644 drivers/crypto/mlx5/version.map
delete mode 100644 drivers/crypto/mvsam/version.map
delete mode 100644 drivers/crypto/nitrox/version.map
delete mode 100644 drivers/crypto/null/version.map
delete mode 100644 drivers/crypto/openssl/version.map
delete mode 100644 drivers/crypto/virtio/version.map
delete mode 100644 drivers/dma/cnxk/version.map
delete mode 100644 drivers/dma/dpaa/version.map
delete mode 100644 drivers/dma/hisilicon/version.map
delete mode 100644 drivers/dma/idxd/version.map
delete mode 100644 drivers/dma/ioat/version.map
delete mode 100644 drivers/dma/skeleton/version.map
delete mode 100644 drivers/event/cnxk/version.map
delete mode 100644 drivers/event/dpaa/version.map
delete mode 100644 drivers/event/dpaa2/version.map
delete mode 100644 drivers/event/dsw/version.map
delete mode 100644 drivers/event/octeontx/version.map
delete mode 100644 drivers/event/opdl/version.map
delete mode 100644 drivers/event/skeleton/version.map
delete mode 100644 drivers/event/sw/version.map
delete mode 100644 drivers/gpu/cuda/version.map
delete mode 100644 drivers/mempool/bucket/version.map
delete mode 100644 drivers/mempool/cnxk/version.map
delete mode 100644 drivers/mempool/octeontx/version.map
delete mode 100644 drivers/mempool/ring/version.map
delete mode 100644 drivers/mempool/stack/version.map
delete mode 100644 drivers/net/af_packet/version.map
delete mode 100644 drivers/net/af_xdp/version.map
delete mode 100644 drivers/net/ark/version.map
delete mode 100644 drivers/net/avp/version.map
delete mode 100644 drivers/net/axgbe/version.map
delete mode 100644 drivers/net/bnx2x/version.map
delete mode 100644 drivers/net/cxgbe/version.map
delete mode 100644 drivers/net/e1000/version.map
delete mode 100644 drivers/net/ena/version.map
delete mode 100644 drivers/net/enetc/version.map
delete mode 100644 drivers/net/enetfec/version.map
delete mode 100644 drivers/net/enic/version.map
delete mode 100644 drivers/net/failsafe/version.map
delete mode 100644 drivers/net/fm10k/version.map
delete mode 100644 drivers/net/hinic/version.map
delete mode 100644 drivers/net/hns3/version.map
delete mode 100644 drivers/net/igc/version.map
delete mode 100644 drivers/net/ionic/version.map
delete mode 100644 drivers/net/kni/version.map
delete mode 100644 drivers/net/liquidio/version.map
delete mode 100644 drivers/net/mana/version.map
delete mode 100644 drivers/net/memif/version.map
delete mode 100644 drivers/net/mlx4/version.map
delete mode 100644 drivers/net/mvneta/version.map
delete mode 100644 drivers/net/mvpp2/version.map
delete mode 100644 drivers/net/netvsc/version.map
delete mode 100644 drivers/net/nfb/version.map
delete mode 100644 drivers/net/nfp/version.map
delete mode 100644 drivers/net/ngbe/version.map
delete mode 100644 drivers/net/null/version.map
delete mode 100644 drivers/net/octeon_ep/version.map
delete mode 100644 drivers/net/pcap/version.map
delete mode 100644 drivers/net/pfe/version.map
delete mode 100644 drivers/net/qede/version.map
delete mode 100644 drivers/net/sfc/version.map
delete mode 100644 drivers/net/tap/version.map
delete mode 100644 drivers/net/thunderx/version.map
delete mode 100644 drivers/net/txgbe/version.map
delete mode 100644 drivers/net/vdev_netvsc/version.map
delete mode 100644 drivers/net/virtio/version.map
delete mode 100644 drivers/net/vmxnet3/version.map
delete mode 100644 drivers/raw/cnxk_bphy/version.map
delete mode 100644 drivers/raw/cnxk_gpio/version.map
delete mode 100644 drivers/raw/dpaa2_cmdif/version.map
delete mode 100644 drivers/raw/ntb/version.map
delete mode 100644 drivers/raw/skeleton/version.map
delete mode 100644 drivers/regex/cn9k/version.map
delete mode 100644 drivers/regex/mlx5/version.map
delete mode 100644 drivers/vdpa/ifc/version.map
delete mode 100644 drivers/vdpa/mlx5/version.map
delete mode 100644 drivers/vdpa/sfc/version.map
diff --git a/drivers/baseband/la12xx/version.map b/drivers/baseband/la12xx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/la12xx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/null/version.map b/drivers/baseband/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/turbo_sw/version.map b/drivers/baseband/turbo_sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/turbo_sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/common/qat/version.map b/drivers/common/qat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/common/qat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/isal/version.map b/drivers/compress/isal/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/isal/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/mlx5/version.map b/drivers/compress/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/octeontx/version.map b/drivers/compress/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/zlib/version.map b/drivers/compress/zlib/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/zlib/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/armv8/version.map b/drivers/crypto/armv8/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/armv8/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/bcmfs/version.map b/drivers/crypto/bcmfs/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/bcmfs/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/caam_jr/version.map b/drivers/crypto/caam_jr/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/caam_jr/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ccp/version.map b/drivers/crypto/ccp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ccp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ipsec_mb/version.map b/drivers/crypto/ipsec_mb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ipsec_mb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mlx5/version.map b/drivers/crypto/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mvsam/version.map b/drivers/crypto/mvsam/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mvsam/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/nitrox/version.map b/drivers/crypto/nitrox/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/nitrox/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/null/version.map b/drivers/crypto/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/openssl/version.map b/drivers/crypto/openssl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/openssl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/virtio/version.map b/drivers/crypto/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/cnxk/version.map b/drivers/dma/cnxk/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/dpaa/version.map b/drivers/dma/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/hisilicon/version.map b/drivers/dma/hisilicon/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/hisilicon/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/idxd/version.map b/drivers/dma/idxd/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/idxd/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/ioat/version.map b/drivers/dma/ioat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/ioat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/skeleton/version.map b/drivers/dma/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/cnxk/version.map b/drivers/event/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/event/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/event/dpaa/version.map b/drivers/event/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dpaa2/version.map b/drivers/event/dpaa2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dsw/version.map b/drivers/event/dsw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dsw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/octeontx/version.map b/drivers/event/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/opdl/version.map b/drivers/event/opdl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/opdl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/skeleton/version.map b/drivers/event/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/sw/version.map b/drivers/event/sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/gpu/cuda/version.map b/drivers/gpu/cuda/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/gpu/cuda/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/bucket/version.map b/drivers/mempool/bucket/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/bucket/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/cnxk/version.map b/drivers/mempool/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/mempool/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/mempool/octeontx/version.map b/drivers/mempool/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/ring/version.map b/drivers/mempool/ring/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/ring/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/stack/version.map b/drivers/mempool/stack/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/stack/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_packet/version.map b/drivers/net/af_packet/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_packet/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_xdp/version.map b/drivers/net/af_xdp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_xdp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ark/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/avp/version.map b/drivers/net/avp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/avp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/axgbe/version.map b/drivers/net/axgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/axgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/bnx2x/version.map b/drivers/net/bnx2x/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/bnx2x/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/cxgbe/version.map b/drivers/net/cxgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/cxgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/e1000/version.map b/drivers/net/e1000/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/e1000/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ena/version.map b/drivers/net/ena/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ena/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetc/version.map b/drivers/net/enetc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetfec/version.map b/drivers/net/enetfec/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetfec/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enic/version.map b/drivers/net/enic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/failsafe/version.map b/drivers/net/failsafe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/failsafe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/fm10k/version.map b/drivers/net/fm10k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/fm10k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hinic/version.map b/drivers/net/hinic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hinic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hns3/version.map b/drivers/net/hns3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hns3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/igc/version.map b/drivers/net/igc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/igc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ionic/version.map b/drivers/net/ionic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ionic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/kni/version.map b/drivers/net/kni/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/kni/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/liquidio/version.map b/drivers/net/liquidio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/liquidio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mana/version.map b/drivers/net/mana/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mana/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/memif/version.map b/drivers/net/memif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/memif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mlx4/version.map b/drivers/net/mlx4/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mlx4/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvneta/version.map b/drivers/net/mvneta/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvneta/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvpp2/version.map b/drivers/net/mvpp2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvpp2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/netvsc/version.map b/drivers/net/netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfb/version.map b/drivers/net/nfb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfp/version.map b/drivers/net/nfp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ngbe/version.map b/drivers/net/ngbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ngbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/null/version.map b/drivers/net/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/octeon_ep/version.map b/drivers/net/octeon_ep/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/octeon_ep/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pcap/version.map b/drivers/net/pcap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pcap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pfe/version.map b/drivers/net/pfe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pfe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/qede/version.map b/drivers/net/qede/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/qede/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/sfc/version.map b/drivers/net/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/tap/version.map b/drivers/net/tap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/tap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/thunderx/version.map b/drivers/net/thunderx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/thunderx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/txgbe/version.map b/drivers/net/txgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/txgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vdev_netvsc/version.map b/drivers/net/vdev_netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vdev_netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/virtio/version.map b/drivers/net/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vmxnet3/version.map b/drivers/net/vmxnet3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vmxnet3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_bphy/version.map b/drivers/raw/cnxk_bphy/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_bphy/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_gpio/version.map b/drivers/raw/cnxk_gpio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_gpio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/dpaa2_cmdif/version.map b/drivers/raw/dpaa2_cmdif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/dpaa2_cmdif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/ntb/version.map b/drivers/raw/ntb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/ntb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/skeleton/version.map b/drivers/raw/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/cn9k/version.map b/drivers/regex/cn9k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/cn9k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/mlx5/version.map b/drivers/regex/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/ifc/version.map b/drivers/vdpa/ifc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/ifc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/mlx5/version.map b/drivers/vdpa/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH v4 1/2] build: make version file optional for drivers
2022-10-12 10:29 ` [PATCH v3 2/2] " Abdullah Ömer Yamaç
@ 2022-10-12 10:42 ` Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 2/2] drivers: remove the unnecessary Abdullah Ömer Yamaç
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
0 siblings, 2 replies; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-12 10:42 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit, Bruce Richardson
In this patch, we removed the necessity of the version files and
you don't need to update these files for each release, you can just
remove them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/meson.build | 65 +++++++++++++++++++++++++--------------------
1 file changed, 36 insertions(+), 29 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index 216971f4e2..c0f3ec4037 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
+fs = import('fs')
+
# Defines the order of dependencies evaluation
subdirs = [
'common',
@@ -202,38 +204,43 @@ foreach subpath:subdirs
version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)
implib = 'lib' + lib_name + '.dll.a'
- def_file = custom_target(lib_name + '_def',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_exports.def'.format(lib_name))
-
- mingw_map = custom_target(lib_name + '_mingw',
- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
- input: version_map,
- output: '@0@_mingw.map'.format(lib_name))
-
- lk_deps = [version_map, def_file, mingw_map]
- if is_windows
- if is_ms_linker
- lk_args = ['-Wl,/def:' + def_file.full_path()]
- if meson.version().version_compare('<0.54.0')
- lk_args += ['-Wl,/implib:drivers\\' + implib]
+ lk_deps = []
+ lk_args = []
+ if fs.is_file(version_map)
+ def_file = custom_target(lib_name + '_def',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_exports.def'.format(lib_name))
+
+ mingw_map = custom_target(lib_name + '_mingw',
+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],
+ input: version_map,
+ output: '@0@_mingw.map'.format(lib_name))
+
+ lk_deps = [version_map, def_file, mingw_map]
+ if is_windows
+ if is_ms_linker
+ lk_args = ['-Wl,/def:' + def_file.full_path()]
+ if meson.version().version_compare('<0.54.0')
+ lk_args += ['-Wl,/implib:drivers\\' + implib]
+ endif
+ else
+ lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
endif
else
- lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]
- endif
- else
- lk_args = ['-Wl,--version-script=' + version_map]
- if developer_mode
- # on unix systems check the output of the
- # check-symbols.sh script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.sym_chk',
- command: [check_symbols, version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.sym_chk')
+ lk_args = ['-Wl,--version-script=' + version_map]
+ if developer_mode
+ # on unix systems check the output of the
+ # check-symbols.sh script, using it as a
+ # dependency of the .so build
+ lk_deps += custom_target(lib_name + '.sym_chk',
+ command: [check_symbols, version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.sym_chk')
+ endif
endif
+
endif
shared_lib = shared_library(lib_name, sources,
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH v4 2/2] drivers: remove the unnecessary
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
@ 2022-10-12 10:42 ` Abdullah Ömer Yamaç
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
1 sibling, 0 replies; 22+ messages in thread
From: Abdullah Ömer Yamaç @ 2022-10-12 10:42 UTC (permalink / raw)
To: dev; +Cc: Abdullah Ömer Yamaç, Ferruh Yigit, Bruce Richardson
With the previous patch, some version.map files are not necessary.
In this patch, we removed them.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/baseband/la12xx/version.map | 3 ---
drivers/baseband/null/version.map | 3 ---
drivers/baseband/turbo_sw/version.map | 3 ---
drivers/common/qat/version.map | 3 ---
drivers/compress/isal/version.map | 3 ---
drivers/compress/mlx5/version.map | 3 ---
drivers/compress/octeontx/version.map | 3 ---
drivers/compress/zlib/version.map | 3 ---
drivers/crypto/armv8/version.map | 3 ---
drivers/crypto/bcmfs/version.map | 3 ---
drivers/crypto/caam_jr/version.map | 3 ---
drivers/crypto/ccp/version.map | 3 ---
drivers/crypto/ipsec_mb/version.map | 3 ---
drivers/crypto/mlx5/version.map | 3 ---
drivers/crypto/mvsam/version.map | 3 ---
drivers/crypto/nitrox/version.map | 3 ---
drivers/crypto/null/version.map | 3 ---
drivers/crypto/openssl/version.map | 3 ---
drivers/crypto/virtio/version.map | 3 ---
drivers/dma/cnxk/version.map | 3 ---
drivers/dma/dpaa/version.map | 3 ---
drivers/dma/hisilicon/version.map | 3 ---
drivers/dma/idxd/version.map | 3 ---
drivers/dma/ioat/version.map | 3 ---
drivers/dma/skeleton/version.map | 3 ---
drivers/event/cnxk/version.map | 3 ---
drivers/event/dpaa/version.map | 3 ---
drivers/event/dpaa2/version.map | 3 ---
drivers/event/dsw/version.map | 3 ---
drivers/event/octeontx/version.map | 3 ---
drivers/event/opdl/version.map | 3 ---
drivers/event/skeleton/version.map | 3 ---
drivers/event/sw/version.map | 3 ---
drivers/gpu/cuda/version.map | 3 ---
drivers/mempool/bucket/version.map | 3 ---
drivers/mempool/cnxk/version.map | 3 ---
drivers/mempool/octeontx/version.map | 3 ---
drivers/mempool/ring/version.map | 3 ---
drivers/mempool/stack/version.map | 3 ---
drivers/net/af_packet/version.map | 3 ---
drivers/net/af_xdp/version.map | 3 ---
drivers/net/ark/version.map | 3 ---
drivers/net/avp/version.map | 3 ---
drivers/net/axgbe/version.map | 3 ---
drivers/net/bnx2x/version.map | 3 ---
drivers/net/cxgbe/version.map | 3 ---
drivers/net/e1000/version.map | 3 ---
drivers/net/ena/version.map | 3 ---
drivers/net/enetc/version.map | 3 ---
drivers/net/enetfec/version.map | 3 ---
drivers/net/enic/version.map | 3 ---
drivers/net/failsafe/version.map | 3 ---
drivers/net/fm10k/version.map | 3 ---
drivers/net/hinic/version.map | 3 ---
drivers/net/hns3/version.map | 3 ---
drivers/net/igc/version.map | 3 ---
drivers/net/ionic/version.map | 3 ---
drivers/net/kni/version.map | 3 ---
drivers/net/liquidio/version.map | 3 ---
drivers/net/mana/version.map | 3 ---
drivers/net/memif/version.map | 3 ---
drivers/net/mlx4/version.map | 3 ---
drivers/net/mvneta/version.map | 3 ---
drivers/net/mvpp2/version.map | 3 ---
drivers/net/netvsc/version.map | 3 ---
drivers/net/nfb/version.map | 3 ---
drivers/net/nfp/version.map | 3 ---
drivers/net/ngbe/version.map | 3 ---
drivers/net/null/version.map | 3 ---
drivers/net/octeon_ep/version.map | 3 ---
drivers/net/pcap/version.map | 3 ---
drivers/net/pfe/version.map | 3 ---
drivers/net/qede/version.map | 3 ---
drivers/net/sfc/version.map | 3 ---
drivers/net/tap/version.map | 3 ---
drivers/net/thunderx/version.map | 3 ---
drivers/net/txgbe/version.map | 3 ---
drivers/net/vdev_netvsc/version.map | 3 ---
drivers/net/virtio/version.map | 3 ---
drivers/net/vmxnet3/version.map | 3 ---
drivers/raw/cnxk_bphy/version.map | 3 ---
drivers/raw/cnxk_gpio/version.map | 3 ---
drivers/raw/dpaa2_cmdif/version.map | 3 ---
drivers/raw/ntb/version.map | 3 ---
drivers/raw/skeleton/version.map | 3 ---
drivers/regex/cn9k/version.map | 3 ---
drivers/regex/mlx5/version.map | 3 ---
drivers/vdpa/ifc/version.map | 3 ---
drivers/vdpa/mlx5/version.map | 3 ---
drivers/vdpa/sfc/version.map | 3 ---
90 files changed, 270 deletions(-)
delete mode 100644 drivers/baseband/la12xx/version.map
delete mode 100644 drivers/baseband/null/version.map
delete mode 100644 drivers/baseband/turbo_sw/version.map
delete mode 100644 drivers/common/qat/version.map
delete mode 100644 drivers/compress/isal/version.map
delete mode 100644 drivers/compress/mlx5/version.map
delete mode 100644 drivers/compress/octeontx/version.map
delete mode 100644 drivers/compress/zlib/version.map
delete mode 100644 drivers/crypto/armv8/version.map
delete mode 100644 drivers/crypto/bcmfs/version.map
delete mode 100644 drivers/crypto/caam_jr/version.map
delete mode 100644 drivers/crypto/ccp/version.map
delete mode 100644 drivers/crypto/ipsec_mb/version.map
delete mode 100644 drivers/crypto/mlx5/version.map
delete mode 100644 drivers/crypto/mvsam/version.map
delete mode 100644 drivers/crypto/nitrox/version.map
delete mode 100644 drivers/crypto/null/version.map
delete mode 100644 drivers/crypto/openssl/version.map
delete mode 100644 drivers/crypto/virtio/version.map
delete mode 100644 drivers/dma/cnxk/version.map
delete mode 100644 drivers/dma/dpaa/version.map
delete mode 100644 drivers/dma/hisilicon/version.map
delete mode 100644 drivers/dma/idxd/version.map
delete mode 100644 drivers/dma/ioat/version.map
delete mode 100644 drivers/dma/skeleton/version.map
delete mode 100644 drivers/event/cnxk/version.map
delete mode 100644 drivers/event/dpaa/version.map
delete mode 100644 drivers/event/dpaa2/version.map
delete mode 100644 drivers/event/dsw/version.map
delete mode 100644 drivers/event/octeontx/version.map
delete mode 100644 drivers/event/opdl/version.map
delete mode 100644 drivers/event/skeleton/version.map
delete mode 100644 drivers/event/sw/version.map
delete mode 100644 drivers/gpu/cuda/version.map
delete mode 100644 drivers/mempool/bucket/version.map
delete mode 100644 drivers/mempool/cnxk/version.map
delete mode 100644 drivers/mempool/octeontx/version.map
delete mode 100644 drivers/mempool/ring/version.map
delete mode 100644 drivers/mempool/stack/version.map
delete mode 100644 drivers/net/af_packet/version.map
delete mode 100644 drivers/net/af_xdp/version.map
delete mode 100644 drivers/net/ark/version.map
delete mode 100644 drivers/net/avp/version.map
delete mode 100644 drivers/net/axgbe/version.map
delete mode 100644 drivers/net/bnx2x/version.map
delete mode 100644 drivers/net/cxgbe/version.map
delete mode 100644 drivers/net/e1000/version.map
delete mode 100644 drivers/net/ena/version.map
delete mode 100644 drivers/net/enetc/version.map
delete mode 100644 drivers/net/enetfec/version.map
delete mode 100644 drivers/net/enic/version.map
delete mode 100644 drivers/net/failsafe/version.map
delete mode 100644 drivers/net/fm10k/version.map
delete mode 100644 drivers/net/hinic/version.map
delete mode 100644 drivers/net/hns3/version.map
delete mode 100644 drivers/net/igc/version.map
delete mode 100644 drivers/net/ionic/version.map
delete mode 100644 drivers/net/kni/version.map
delete mode 100644 drivers/net/liquidio/version.map
delete mode 100644 drivers/net/mana/version.map
delete mode 100644 drivers/net/memif/version.map
delete mode 100644 drivers/net/mlx4/version.map
delete mode 100644 drivers/net/mvneta/version.map
delete mode 100644 drivers/net/mvpp2/version.map
delete mode 100644 drivers/net/netvsc/version.map
delete mode 100644 drivers/net/nfb/version.map
delete mode 100644 drivers/net/nfp/version.map
delete mode 100644 drivers/net/ngbe/version.map
delete mode 100644 drivers/net/null/version.map
delete mode 100644 drivers/net/octeon_ep/version.map
delete mode 100644 drivers/net/pcap/version.map
delete mode 100644 drivers/net/pfe/version.map
delete mode 100644 drivers/net/qede/version.map
delete mode 100644 drivers/net/sfc/version.map
delete mode 100644 drivers/net/tap/version.map
delete mode 100644 drivers/net/thunderx/version.map
delete mode 100644 drivers/net/txgbe/version.map
delete mode 100644 drivers/net/vdev_netvsc/version.map
delete mode 100644 drivers/net/virtio/version.map
delete mode 100644 drivers/net/vmxnet3/version.map
delete mode 100644 drivers/raw/cnxk_bphy/version.map
delete mode 100644 drivers/raw/cnxk_gpio/version.map
delete mode 100644 drivers/raw/dpaa2_cmdif/version.map
delete mode 100644 drivers/raw/ntb/version.map
delete mode 100644 drivers/raw/skeleton/version.map
delete mode 100644 drivers/regex/cn9k/version.map
delete mode 100644 drivers/regex/mlx5/version.map
delete mode 100644 drivers/vdpa/ifc/version.map
delete mode 100644 drivers/vdpa/mlx5/version.map
delete mode 100644 drivers/vdpa/sfc/version.map
diff --git a/drivers/baseband/la12xx/version.map b/drivers/baseband/la12xx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/la12xx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/null/version.map b/drivers/baseband/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/baseband/turbo_sw/version.map b/drivers/baseband/turbo_sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/baseband/turbo_sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/common/qat/version.map b/drivers/common/qat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/common/qat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/isal/version.map b/drivers/compress/isal/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/isal/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/mlx5/version.map b/drivers/compress/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/octeontx/version.map b/drivers/compress/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/compress/zlib/version.map b/drivers/compress/zlib/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/compress/zlib/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/armv8/version.map b/drivers/crypto/armv8/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/armv8/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/bcmfs/version.map b/drivers/crypto/bcmfs/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/bcmfs/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/caam_jr/version.map b/drivers/crypto/caam_jr/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/caam_jr/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ccp/version.map b/drivers/crypto/ccp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ccp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/ipsec_mb/version.map b/drivers/crypto/ipsec_mb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/ipsec_mb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mlx5/version.map b/drivers/crypto/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/mvsam/version.map b/drivers/crypto/mvsam/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/mvsam/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/nitrox/version.map b/drivers/crypto/nitrox/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/nitrox/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/null/version.map b/drivers/crypto/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/openssl/version.map b/drivers/crypto/openssl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/openssl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/crypto/virtio/version.map b/drivers/crypto/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/crypto/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/cnxk/version.map b/drivers/dma/cnxk/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/dpaa/version.map b/drivers/dma/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/hisilicon/version.map b/drivers/dma/hisilicon/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/hisilicon/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/idxd/version.map b/drivers/dma/idxd/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/idxd/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/ioat/version.map b/drivers/dma/ioat/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/ioat/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/dma/skeleton/version.map b/drivers/dma/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/dma/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/cnxk/version.map b/drivers/event/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/event/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/event/dpaa/version.map b/drivers/event/dpaa/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dpaa2/version.map b/drivers/event/dpaa2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dpaa2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/dsw/version.map b/drivers/event/dsw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/dsw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/octeontx/version.map b/drivers/event/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/opdl/version.map b/drivers/event/opdl/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/opdl/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/skeleton/version.map b/drivers/event/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/event/sw/version.map b/drivers/event/sw/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/event/sw/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/gpu/cuda/version.map b/drivers/gpu/cuda/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/gpu/cuda/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/bucket/version.map b/drivers/mempool/bucket/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/bucket/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/cnxk/version.map b/drivers/mempool/cnxk/version.map
deleted file mode 100644
index ee80c51721..0000000000
--- a/drivers/mempool/cnxk/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-INTERNAL {
- local: *;
-};
diff --git a/drivers/mempool/octeontx/version.map b/drivers/mempool/octeontx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/octeontx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/ring/version.map b/drivers/mempool/ring/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/ring/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/mempool/stack/version.map b/drivers/mempool/stack/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/mempool/stack/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_packet/version.map b/drivers/net/af_packet/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_packet/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/af_xdp/version.map b/drivers/net/af_xdp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/af_xdp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ark/version.map b/drivers/net/ark/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ark/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/avp/version.map b/drivers/net/avp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/avp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/axgbe/version.map b/drivers/net/axgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/axgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/bnx2x/version.map b/drivers/net/bnx2x/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/bnx2x/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/cxgbe/version.map b/drivers/net/cxgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/cxgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/e1000/version.map b/drivers/net/e1000/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/e1000/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ena/version.map b/drivers/net/ena/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ena/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetc/version.map b/drivers/net/enetc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enetfec/version.map b/drivers/net/enetfec/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enetfec/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/enic/version.map b/drivers/net/enic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/enic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/failsafe/version.map b/drivers/net/failsafe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/failsafe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/fm10k/version.map b/drivers/net/fm10k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/fm10k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hinic/version.map b/drivers/net/hinic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hinic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/hns3/version.map b/drivers/net/hns3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/hns3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/igc/version.map b/drivers/net/igc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/igc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ionic/version.map b/drivers/net/ionic/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ionic/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/kni/version.map b/drivers/net/kni/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/kni/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/liquidio/version.map b/drivers/net/liquidio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/liquidio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mana/version.map b/drivers/net/mana/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mana/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/memif/version.map b/drivers/net/memif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/memif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mlx4/version.map b/drivers/net/mlx4/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mlx4/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvneta/version.map b/drivers/net/mvneta/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvneta/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/mvpp2/version.map b/drivers/net/mvpp2/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/mvpp2/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/netvsc/version.map b/drivers/net/netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfb/version.map b/drivers/net/nfb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/nfp/version.map b/drivers/net/nfp/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/nfp/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/ngbe/version.map b/drivers/net/ngbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/ngbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/null/version.map b/drivers/net/null/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/null/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/octeon_ep/version.map b/drivers/net/octeon_ep/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/octeon_ep/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pcap/version.map b/drivers/net/pcap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pcap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/pfe/version.map b/drivers/net/pfe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/pfe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/qede/version.map b/drivers/net/qede/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/qede/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/sfc/version.map b/drivers/net/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/tap/version.map b/drivers/net/tap/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/tap/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/thunderx/version.map b/drivers/net/thunderx/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/thunderx/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/txgbe/version.map b/drivers/net/txgbe/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/txgbe/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vdev_netvsc/version.map b/drivers/net/vdev_netvsc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vdev_netvsc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/virtio/version.map b/drivers/net/virtio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/virtio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/net/vmxnet3/version.map b/drivers/net/vmxnet3/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/net/vmxnet3/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_bphy/version.map b/drivers/raw/cnxk_bphy/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_bphy/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/cnxk_gpio/version.map b/drivers/raw/cnxk_gpio/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/cnxk_gpio/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/dpaa2_cmdif/version.map b/drivers/raw/dpaa2_cmdif/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/dpaa2_cmdif/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/ntb/version.map b/drivers/raw/ntb/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/ntb/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/raw/skeleton/version.map b/drivers/raw/skeleton/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/raw/skeleton/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/cn9k/version.map b/drivers/regex/cn9k/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/cn9k/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/regex/mlx5/version.map b/drivers/regex/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/regex/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/ifc/version.map b/drivers/vdpa/ifc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/ifc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/mlx5/version.map b/drivers/vdpa/mlx5/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/mlx5/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
diff --git a/drivers/vdpa/sfc/version.map b/drivers/vdpa/sfc/version.map
deleted file mode 100644
index 78c3585d7c..0000000000
--- a/drivers/vdpa/sfc/version.map
+++ /dev/null
@@ -1,3 +0,0 @@
-DPDK_23 {
- local: *;
-};
--
2.27.0
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v4 1/2] build: make version file optional for drivers
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 2/2] drivers: remove the unnecessary Abdullah Ömer Yamaç
@ 2022-10-12 11:32 ` Ferruh Yigit
2022-11-14 14:19 ` David Marchand
1 sibling, 1 reply; 22+ messages in thread
From: Ferruh Yigit @ 2022-10-12 11:32 UTC (permalink / raw)
To: Abdullah Ömer Yamaç; +Cc: Bruce Richardson, dev
On 10/12/2022 11:42 AM, Abdullah Ömer Yamaç wrote:
> In this patch, we removed the necessity of the version files and
> you don't need to update these files for each release, you can just
> remove them.
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks for the patch.
Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v4 1/2] build: make version file optional for drivers
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
@ 2022-11-14 14:19 ` David Marchand
0 siblings, 0 replies; 22+ messages in thread
From: David Marchand @ 2022-11-14 14:19 UTC (permalink / raw)
To: Abdullah Ömer Yamaç; +Cc: Bruce Richardson, Ferruh Yigit, dev
On Wed, Oct 12, 2022 at 1:33 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 10/12/2022 11:42 AM, Abdullah Ömer Yamaç wrote:
> > In this patch, we removed the necessity of the version files and
> > you don't need to update these files for each release, you can just
> > remove them.
> >
> > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
I rebased this patch and updated newly added drivers, after running
the new check I proposed at:
https://patchwork.dpdk.org/project/dpdk/patch/20221114141651.1255306-1-david.marchand@redhat.com/
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 1/2] build: make version file optional for drivers
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
@ 2022-10-11 12:00 ` Bruce Richardson
1 sibling, 0 replies; 22+ messages in thread
From: Bruce Richardson @ 2022-10-11 12:00 UTC (permalink / raw)
To: Abdullah Ömer Yamaç; +Cc: dev, Ferruh Yigit
On Tue, Oct 11, 2022 at 02:08:49PM +0300, Abdullah Ömer Yamaç wrote:
> In this patch, we removed the necessity of the version files and
> you don't need to update these files for each release, you can just
> remove them.
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> ---
> Depends on: patch-116222 ("build: increase minimum meson version to 0.53")
This patch is merged now, so you no longer need to call it out as
dependency.
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-11-14 14:19 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 6:52 [PATCH] drivers: suggestion on removing empty version.map files Abdullah Ömer Yamaç
2022-10-03 9:19 ` Bruce Richardson
2022-10-03 13:59 ` Omer Yamac
2022-10-03 14:01 ` Bruce Richardson
2022-10-04 6:30 ` Omer Yamac
2022-10-04 8:07 ` Bruce Richardson
2022-10-06 7:19 ` [PATCH 1/2] drivers: suggestion on meson without version file Abdullah Ömer Yamaç
2022-10-06 7:19 ` [PATCH 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-07 10:30 ` [PATCH 1/2] drivers: suggestion on meson without version file Bruce Richardson
2022-10-10 7:41 ` Omer Yamac
2022-10-10 8:34 ` Bruce Richardson
2022-10-11 11:08 ` [PATCH v2 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-11 11:08 ` [PATCH v2 2/2] drivers: remove the unnecessary version.map Abdullah Ömer Yamaç
2022-10-11 13:10 ` David Marchand
2022-10-11 19:21 ` Omer Yamac
2022-10-12 10:29 ` [PATCH v3 1/2] build: make version file optional for drivers Abdullah Ömer Yamaç
2022-10-12 10:29 ` [PATCH v3 2/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 1/2] " Abdullah Ömer Yamaç
2022-10-12 10:42 ` [PATCH v4 2/2] drivers: remove the unnecessary Abdullah Ömer Yamaç
2022-10-12 11:32 ` [PATCH v4 1/2] build: make version file optional for drivers Ferruh Yigit
2022-11-14 14:19 ` David Marchand
2022-10-11 12:00 ` [PATCH v2 " Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).