From: Thomas Monjalon <thomas@monjalon.net>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/af_xdp: fix shared umem fill queue reserve
Date: Mon, 14 Mar 2022 10:49:07 +0100 [thread overview]
Message-ID: <3477234.R56niFO833@thomas> (raw)
In-Reply-To: <20220311134513.25512-1-ciara.loftus@intel.com>
11/03/2022 14:45, Ciara Loftus:
> Commit 81fe6720f84f ("net/af_xdp: reserve fill queue before socket create")
> moves the fill queue reserve logic to before the creation of the socket in
> order to suppress kernel logs like:
>
> XSK buffer pool does not provide enough addresses to fill 2047 buffers on
> Rx ring 0
>
> However, for queues that share umem, the fill queue reserve must occur
> after the socket creation, because the fill queue is not valid until
> that point.
>
> This commit uses the umem refcnt value to determine whether the queue is
> sharing a umem, and performs the fill queue reservation either before or
> after the socket creation, depending on the refcnt value.
>
> The kernel logs will still be seen for the shared umem queues.
>
> Fixes: 81fe6720f84f ("net/af_xdp: reserve fill queue before socket create")
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
Applied, thanks.
prev parent reply other threads:[~2022-03-14 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 13:45 Ciara Loftus
2022-03-14 9:49 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3477234.R56niFO833@thomas \
--to=thomas@monjalon.net \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).