From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1E1DA00BE; Mon, 14 Mar 2022 10:49:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E23340DF4; Mon, 14 Mar 2022 10:49:15 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0F6A340DDD for ; Mon, 14 Mar 2022 10:49:14 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9AC2C5C01F8; Mon, 14 Mar 2022 05:49:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 14 Mar 2022 05:49:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=vQTSsUnQ0/J809 xr0uEFUi5THT/buVXRvvNN5X32MlM=; b=O2pqXiWHDfShivVcAKt4g6O1E/Qq77 Jh3ZTm/bSb0xSW95QYNiR2XXWHveyhfzPV8YKqm7Tata1Q+PkKxWfLiOsAJ8EMw/ ybMJaw35mjxLyzxzgSIVbBg8Nzmou2zYpMNZzTQ5lujQ/wa0IgropvZ2f0wERTTH jEincLJ/Wvlouxr0sKtG0vAmOmeDFDOnnhlAqEZDAJJI911SZOTXtKHWff0rYBvT JWzod12aH1nyV/ZKQmqmpifQhnW8kGQBIyLAsHY04mt6k1pGlTV4ENWrgcSfHkVU DeYC3zXrzNpwVUh3WujO8H525A71c+y80+z3L3Pl2SWR+jAWsOi9ORBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vQTSsUnQ0/J809xr0uEFUi5THT/buVXRvvNN5X32M lM=; b=ev+Guq3u4wTknCIdZUq6RmHy0w/akB5OwNCUPdZ7r3e6W6YSi5yOsUNNh vWCxn3v54T0bg6vEt4gNGCheW4ElcqtjQYAhBP4EuYOHDarM3HM5f0GrWHHrNBgC gThh1vFeaZ4PJ0BcPiDhVIId2zD/EG4WhJzTBO8CIDR7iuQf67AKEnEEifwZvFO3 A2HIEIHP9bj7cu1arNscbrtE3stCdOTW3NEn1EM3etQPVNJiuuPrxrlZZgDtkBvm iR6vg/kLiL1cJL8aYNyUyGY2iXjaPVSVVdpZyIuMpuwKtguyFgxrSd+bwUOykJEm x9kN5sJ341Xy0SpmoMXLPoP6YCiKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvkedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Mar 2022 05:49:10 -0400 (EDT) From: Thomas Monjalon To: Ciara Loftus Cc: dev@dpdk.org Subject: Re: [PATCH] net/af_xdp: fix shared umem fill queue reserve Date: Mon, 14 Mar 2022 10:49:07 +0100 Message-ID: <3477234.R56niFO833@thomas> In-Reply-To: <20220311134513.25512-1-ciara.loftus@intel.com> References: <20220311134513.25512-1-ciara.loftus@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/03/2022 14:45, Ciara Loftus: > Commit 81fe6720f84f ("net/af_xdp: reserve fill queue before socket create") > moves the fill queue reserve logic to before the creation of the socket in > order to suppress kernel logs like: > > XSK buffer pool does not provide enough addresses to fill 2047 buffers on > Rx ring 0 > > However, for queues that share umem, the fill queue reserve must occur > after the socket creation, because the fill queue is not valid until > that point. > > This commit uses the umem refcnt value to determine whether the queue is > sharing a umem, and performs the fill queue reservation either before or > after the socket creation, depending on the refcnt value. > > The kernel logs will still be seen for the shared umem queues. > > Fixes: 81fe6720f84f ("net/af_xdp: reserve fill queue before socket create") > > Signed-off-by: Ciara Loftus Applied, thanks.