From: Jeff Guo <jia.guo@intel.com>
To: "Yan,
Xiaoping (NSB - CN/Hangzhou)" <xiaoping.yan@nokia-sbell.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] incorrect vlan_tci in rte mbuf
Date: Tue, 19 May 2020 15:00:18 +0800 [thread overview]
Message-ID: <34885cc0-edd9-9889-9799-a7c6d6485edd@intel.com> (raw)
In-Reply-To: <30f00b616c0049b9b3f5f26b70b4088f@nokia-sbell.com>
hi, xiaoping
On 5/18/2020 4:31 PM, Yan, Xiaoping (NSB - CN/Hangzhou) wrote:
> Hi Beilei & Jia,
>
> I got your name from the MAINTAINERS for Intel i40e.
> Could you help to have a look at the issue, described in my previous mail?
>
> Thank you.
>
> Best regards
> Yan Xiaoping
>
> -----Original Message-----
> From: Olivier Matz <olivier.matz@6wind.com>
> Sent: 2020年5月18日 15:24
> To: Yan, Xiaoping (NSB - CN/Hangzhou) <xiaoping.yan@nokia-sbell.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] incorrect vlan_tci in rte mbuf
>
> Hi,
>
> On Fri, May 15, 2020 at 11:12:27AM +0000, Yan, Xiaoping (NSB - CN/Hangzhou) wrote:
>> Hi,
>>
>> I'm using i40e vf, dpdk 18.11, x86_64 CPU (rx function in use is
>> i40e_recv_scattered_pkts_vec_avx2)
>> When enable hw vlan strip:
>>
>> * If packet fit in one mbuf segment, the vlan_tci field is correct
>> * If packets are stored in several mbuf segment, the vlan_tci of last segment is correct, vlan_tci of other segments are invalid
>>
>> It seems i40e_recv_scattered_pkts has correctly set the vlan_tci, by
>> calling i40e_rxd_to_vlan_tci(first_seg, &rxd);
>>
>> Is this a bug in i40e_recv_scattered_pkts_vec_avx2?
>> (I didn't find setting vlan_tci for first segment, but it's a bit
>> difficult for me to understand codes in
>> i40e_recv_scattered_pkts_vec_avx2, so I'm not quite sure) I checked
>> the latest dpdk version 20.02
>> http://lxr.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_
>> avx2.c#L791
>> But seems no change for this.
>>
>> Any comment please?
>> [...]
> I don't know about the i40e driver, but I can confirm that the vlan tci flag should be in the first segment, and not in the next ones.
>
> I suggest to CC i40e driver maintainers.
>
> Regards,
> Olivier
On one hand, as Olivier said that vlan tci flag should be in the first
segment, and on the other hands, vlan_tci do process in
"_recv_raw_pkts_vec_avx2" when use 256 instinct
to process the descriptor with mbuf, you could check how to process the
vlan_flags_shuf and blend it into the mbuf.
next prev parent reply other threads:[~2020-05-19 7:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 11:12 Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-18 7:24 ` Olivier Matz
2020-05-18 8:31 ` Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-19 7:00 ` Jeff Guo [this message]
2020-05-19 8:31 ` Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-19 12:27 ` Jeff Guo
2020-05-19 12:41 ` Zhang, Qi Z
2020-05-20 7:42 ` Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-20 7:48 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34885cc0-edd9-9889-9799-a7c6d6485edd@intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=xiaoping.yan@nokia-sbell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).