From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E091928F2 for ; Fri, 4 Mar 2016 19:01:41 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 04 Mar 2016 10:01:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,536,1449561600"; d="scan'208";a="59964848" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga004.fm.intel.com with ESMTP; 04 Mar 2016 10:01:27 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX106.ger.corp.intel.com ([169.254.8.172]) with mapi id 14.03.0248.002; Fri, 4 Mar 2016 18:01:27 +0000 From: "Trahe, Fiona" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes Thread-Index: AQHRdjzwBBIdii5rr0moy923QXb6LZ9JjYewgAABSYCAAAPRAA== Date: Fri, 4 Mar 2016 18:01:26 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43588F89328@IRSMSX101.ger.corp.intel.com> References: <1456764731-27168-1-git-send-email-declan.doherty@intel.com> <2831187.Fjk3A3necn@xps13> <348A99DA5F5B7549AA880327E580B43588F892F0@IRSMSX101.ger.corp.intel.com> <3919673.VtXZRcbfcO@xps13> In-Reply-To: <3919673.VtXZRcbfcO@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGRkMTdjY2UtYzFiNS00YmYwLTk2ZmItODQ0MTZiNWJiNTM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpQQ0Y2WGQzZzY1aGR5eGtyRDRvaWpRMmF5TkhTXC9tUW0zMWxcL0lUdGFrWT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 18:01:42 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, March 04, 2016 5:46 PM > To: Trahe, Fiona > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 0/2] cryptodev API changes >=20 > 2016-03-04 17:43, Trahe, Fiona: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-03-04 17:17, Fiona Trahe: > > > > This patch set separates the symmetric crypto operations from > > > > generic > > > operations and then modifies the cryptodev burst API to accept > > > bursts of rte_crypto_op rather than rte_mbufs. > > > > > > > > V5: > > > > - updates .map file > > > > - removes EXPERIMENTAL label from rte_cryptodev.h > > > > > > Why do you want to remove the experimental label? > > > > Declan had already removed from the MAINTAINERS file and other places i= n > previous patches. > > This one was just forgotten as far as we know, though as Declan is out = we > can't confirm with him. > > Do you think we should keep the label ? >=20 > I cannot really decide because it's hard to understand the improvements i= n a > such big patch. It would be easier if the changes were split in several s= teps. > Maybe the last step (last patch) would be to remove the flag. Having it i= n a > separate patch would give the opportunity to detail the reason of the rem= oval in > the commit message. Fair enough. I'll put the label back in. And we'll handle later with a separate explicit commit to give people a cha= nce to comment.