From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6ED952BC2 for ; Wed, 9 Mar 2016 13:55:41 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 09 Mar 2016 04:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="760910794" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 09 Mar 2016 04:55:39 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX107.ger.corp.intel.com ([169.254.10.137]) with mapi id 14.03.0248.002; Wed, 9 Mar 2016 12:55:38 +0000 From: "Trahe, Fiona" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 2/2] cryptodev: change burst API to be crypto op oriented Thread-Index: AQHReGjMwi8OBkJ99UuV3NVIgINaeJ9Pnb0AgAF3AVA= Date: Wed, 9 Mar 2016 12:55:38 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43588F8D369@IRSMSX101.ger.corp.intel.com> References: <1457116189-10226-1-git-send-email-fiona.trahe@intel.com> <1457351422-7617-3-git-send-email-fiona.trahe@intel.com> <3632610.NvqD1GaQY3@xps13> In-Reply-To: <3632610.NvqD1GaQY3@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWY0NmIwMjktYzg0Yi00ZWUxLTljZGItZTFiZDBjNjJmNWFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvdGxFYTUxS2xiN0xYcFhzNDByYzRlbkhoSDhQdHZ6K21QWDR6bFVmSlVnPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 2/2] cryptodev: change burst API to be crypto op oriented X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 12:55:41 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, March 08, 2016 2:32 PM > To: Trahe, Fiona > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 2/2] cryptodev: change burst API to be = crypto > op oriented >=20 > 2016-03-07 11:50, Fiona Trahe: > > This patch modifies the crypto burst enqueue/dequeue APIs to operate > > on bursts rte_crypto_op's rather than the current implementation which > > operates on rte_mbuf bursts, this simplifies the burst processing in > > the crypto PMDs and the use of crypto operations in general. > > > > The changes also continues the separatation of the symmetric operation > > parameters from the more general operation parameters, this will > > simplify the integration of asymmetric crypto operations in the future. > > > > As well as the changes to the crypto APIs this patch adds functions > > for managing rte_crypto_op pools to the cryptodev API. It modifies the > > existing PMDs, unit tests and sample application to work with the > > modified APIs and finally removes the now unused rte_mbuf_offload libra= ry. >=20 > Why not doing several patches? >=20 > > -Packet buffer offload - EXPERIMENTAL > > -M: Declan Doherty > > -F: lib/librte_mbuf_offload/ >=20 > Removing a library is important. It is not mentioned in the message. > It deserves a separate commit, please. >=20 > > @@ -62,8 +61,7 @@ struct crypto_unittest_params { > > > > struct rte_cryptodev_sym_session *sess; > > > > - struct rte_mbuf_offload *ol; > > - struct rte_crypto_sym_op *op; > > + struct rte_crypto_op *op; >=20 > Isn't it something which was just renamed in the previous patch? >=20 > > -#if HEX_DUMP > > +#ifdef HEX_DUMP > > static void > > hexdump_mbuf_data(FILE *f, const char *title, struct rte_mbuf *m) >=20 > A better clean-up would be to remove this ifdef. > If you need a debug function which is not already in EAL, you can conside= r > adding it. >=20 Hi Thomas, We're working on this. Will spin the patchset as soon as we can. Fiona