From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0A6542BCE for ; Thu, 10 Mar 2016 11:30:02 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 10 Mar 2016 02:30:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,315,1455004800"; d="scan'208";a="666972189" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 10 Mar 2016 02:30:01 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Thu, 10 Mar 2016 10:30:00 +0000 From: "Trahe, Fiona" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions Thread-Index: AQHReGjJgnGeBLTFTkaO9o/Pz5RtUZ9Pl7sAgALmwDA= Date: Thu, 10 Mar 2016 10:30:00 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43588F8E055@IRSMSX101.ger.corp.intel.com> References: <1457116189-10226-1-git-send-email-fiona.trahe@intel.com> <1457351422-7617-2-git-send-email-fiona.trahe@intel.com> <1600295.xLGLO1O6Fu@xps13> In-Reply-To: <1600295.xLGLO1O6Fu@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTc5NTM4ZTItZTE3MC00MWI4LThiZTAtYzhlMmM5MmE3NmZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkYzdzVqeVpFOWJ2S1FXK3JFV3ZXN3BvWU03QzRyRzFzY2grdEF3cXN3YXM9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to support future extensions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 10:30:03 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, March 08, 2016 2:11 PM > To: Trahe, Fiona > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: API tidy and changes to > support future extensions >=20 > Hi, >=20 > 2016-03-07 11:50, Fiona Trahe: > > This patch splits symmetric specific definitions and functions away > > from the common crypto APIs to facilitate the future extension and > > expansion of the cryptodev framework, in order to allow asymmetric > > crypto operations to be introduced at a later date, as well as to > > clean the logical structure of the public includes. The patch also > > introduces the _sym prefix to symmetric specific structure and > > functions to improve clarity in the API. >=20 > It seems you need to update the examples in the same patch, they do not > compile anymore after these changes. Sorry, fixed. > Again, it would be easier to review if you had split the changes to sever= al > patches: one for the sym suffix, others for more tidying. V8 patchset will be sent shortly with more granular split