From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CAEC45A98 for ; Fri, 30 Jun 2017 18:13:29 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2017 09:13:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,287,1496127600"; d="scan'208";a="873530956" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jun 2017 09:13:28 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.242]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Fri, 30 Jun 2017 17:13:27 +0100 From: "Trahe, Fiona" To: "Gonzalez Monroy, Sergio" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk Thread-Index: AQHS8Xc5NB52deMBmEmrzk8gGJY+QaI9lIOw Date: Fri, 30 Jun 2017 16:13:27 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589227DF4@IRSMSX101.ger.corp.intel.com> References: <20170630075658.45786-1-sergio.gonzalez.monroy@intel.com> In-Reply-To: <20170630075658.45786-1-sergio.gonzalez.monroy@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 16:13:31 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez Monr= oy > Sent: Friday, June 30, 2017 8:57 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk >=20 > Use rte_mempool_put_bulk for both latency and throughput tests instead > of rte_crypto_op_free to improve application performance. >=20 > Signed-off-by: Sergio Gonzalez Monroy > --- > app/test-crypto-perf/cperf_test_latency.c | 14 ++++++++------ > app/test-crypto-perf/cperf_test_throughput.c | 8 ++++---- > 2 files changed, 12 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-= perf/cperf_test_latency.c > index 0c85ac8..4fb7a9a 100644 > --- a/app/test-crypto-perf/cperf_test_latency.c > +++ b/app/test-crypto-perf/cperf_test_latency.c > @@ -393,8 +393,10 @@ cperf_latency_test_runner(void *arg) > tsc_end =3D rte_rdtsc_precise(); >=20 > /* Free memory for not enqueued operations */ > - for (i =3D ops_enqd; i < burst_size; i++) > - rte_crypto_op_free(ops[i]); > + if (ops_enqd !=3D burst_size) > + rte_mempool_put_bulk(ctx->crypto_op_pool, > + (void **)&ops_processed[ops_enqd], > + burst_size - ops_enqd); >=20 > for (i =3D 0; i < ops_enqd; i++) { > ctx->res[tsc_idx].tsc_start =3D tsc_start; > @@ -414,9 +416,9 @@ cperf_latency_test_runner(void *arg) > (ops_processed[i]->opaque_data); > pres->status =3D ops_processed[i]->status; > pres->tsc_end =3D tsc_end; > - > - rte_crypto_op_free(ops_processed[i]); > } > + rte_mempool_put_bulk(ctx->crypto_op_pool, > + (void **)ops_processed, ops_deqd); >=20 > deqd_tot +=3D ops_deqd; > deqd_max =3D max(ops_deqd, deqd_max); > @@ -450,9 +452,9 @@ cperf_latency_test_runner(void *arg) > (ops_processed[i]->opaque_data); > pres->status =3D ops_processed[i]->status; > pres->tsc_end =3D tsc_end; > - > - rte_crypto_op_free(ops_processed[i]); > } > + rte_mempool_put_bulk(ctx->crypto_op_pool, > + (void **)ops_processed, ops_deqd); >=20 > deqd_tot +=3D ops_deqd; > deqd_max =3D max(ops_deqd, deqd_max); > diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-cryp= to- > perf/cperf_test_throughput.c > index 053dc66..85947a5 100644 > --- a/app/test-crypto-perf/cperf_test_throughput.c > +++ b/app/test-crypto-perf/cperf_test_throughput.c > @@ -396,8 +396,8 @@ cperf_throughput_test_runner(void *test_ctx) > * the crypto operation will change the data and cause > * failures. > */ > - for (i =3D 0; i < ops_deqd; i++) > - rte_crypto_op_free(ops_processed[i]); > + rte_mempool_put_bulk(ctx->crypto_op_pool, > + (void **)ops_processed, ops_deqd); >=20 > ops_deqd_total +=3D ops_deqd; > } else { > @@ -426,8 +426,8 @@ cperf_throughput_test_runner(void *test_ctx) > if (ops_deqd =3D=3D 0) > ops_deqd_failed++; > else { > - for (i =3D 0; i < ops_deqd; i++) > - rte_crypto_op_free(ops_processed[i]); > + rte_mempool_put_bulk(ctx->crypto_op_pool, > + (void **)ops_processed, ops_deqd); >=20 > ops_deqd_total +=3D ops_deqd; > } > -- > 2.9.3 Acked-by: Fiona Trahe