From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8C06B271 for ; Fri, 14 Jul 2017 18:17:05 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jul 2017 09:17:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,359,1496127600"; d="scan'208";a="127381377" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 14 Jul 2017 09:16:52 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 14 Jul 2017 17:16:51 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.242]) by irsmsx112.ger.corp.intel.com ([169.254.1.42]) with mapi id 14.03.0319.002; Fri, 14 Jul 2017 17:16:51 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "Doherty, Declan" , "Jain, Deepak K" , "Griffin, John" , "Kusztal, ArkadiuszX" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters Thread-Index: AQHS/LLRg/wR4MRad0ylt5TN1Ww8MaJTd1mAgAAHr6A= Date: Fri, 14 Jul 2017 16:16:50 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435892366A4@IRSMSX101.ger.corp.intel.com> References: <20170713074450.63682-1-pablo.de.lara.guarch@intel.com> <20170714070652.54494-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTRmOTViZWQtMWM4YS00NWE3LWFiMGQtMTc2YmRhNjljNjlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InJhNUtDRlJpa2V0cFRseUJyOVloWEYreW43QytvS0NxRVBQS3paSTVqOTA9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: fix KASUMI F9 expected parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 16:17:06 -0000 Hi Pablo, > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, July 14, 2017 4:48 PM > To: De Lara Guarch, Pablo ; Doherty, Decl= an > ; Jain, Deepak K ; Gri= ffin, John > ; Kusztal, ArkadiuszX > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Friday, July 14, 2017 8:07 AM > > To: Doherty, Declan ; Trahe, Fiona ; Jain, Deepak > K > > ; Griffin, John ; Kusz= tal, ArkadiuszX > > > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters > > > > For KASUMI F9 algorithm, COUNT, FRESH and DIRECTION > > input values need to be contiguous with > > the message, as described in the KASUMI and QAT PMD > > documentation. > > > > Before, the COUNT and FRESH values were set > > as part of the AAD (now IV), but always set before > > the beginning of the message. > > Since now the IV is set after the crypto operation, > > it is not possible to have these values in the > > expected location. > > > > Therefore, as these are required to be contiguous, > > cryptodev API will expect these them to be passed > > as a single buffer, already constructed, so > > authentication IV parameters not needed anymore. > > > > Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless algorithms"= ) > > > > Signed-off-by: Pablo de Lara > Acked-by: Fiona Trahe The limitation in QAT documentation stating that Kasumi F9 auth_len and aut= h_offset must be byte-multiples can be removed as this is now a limitation = on the API, not on QAT.=20