From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 26B2B2030 for ; Wed, 19 Jul 2017 16:06:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2017 07:06:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="994728639" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 19 Jul 2017 07:06:06 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.242]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 15:06:05 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "Jain, Deepak K" , "Griffin, John" CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH] crypto/qat: fix session initialization Thread-Index: AQHTAI7Etjn62KHosUa3eywtAybkWaJbLiBg Date: Wed, 19 Jul 2017 14:06:04 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435892389FC@IRSMSX101.ger.corp.intel.com> References: <20170719045902.12110-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20170719045902.12110-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGM1MGM3ZDktZmZlMy00YzE4LWFkNDUtNGJiNjJkZjJjYzBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjB1RTRPcmxOV01nY3o0ZnBvZllubXhNQnhPSkprNmpzblE0TGtaUDRsTjg9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix session initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 14:06:24 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 19, 2017 5:59 AM > To: Trahe, Fiona ; Jain, Deepak K ; Griffin, John > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/qat: fix session initialization >=20 > When creating a session, if there is a failure when > setting some of the parameters, QAT was not propagating > the error to the session initialization function. > Therefore, it was reporting a success, when it should > be report a failure. >=20 > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") >=20 > Signed-off-by: Pablo de Lara In the 3 fn prototypes in qat_crypto.h it would be nice to remove the _priv= ate from=20 struct qat_session *session_private. Apart from that it's fine. Acked-by: Fiona Trahe