From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3A65E1B1BD for ; Mon, 9 Oct 2017 11:57:21 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 09 Oct 2017 02:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,500,1500966000"; d="scan'208";a="1023174901" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 09 Oct 2017 02:57:19 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Mon, 9 Oct 2017 10:57:18 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "Doherty, Declan" , "Jain, Deepak K" , "Griffin, John" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/9] cryptodev: clarify API for AES-CCM Thread-Index: AQHTMx46TSNIJ0vqv0uDiTGGflbdAKLbY5hA Date: Mon, 9 Oct 2017 09:57:18 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435892A580F@IRSMSX101.ger.corp.intel.com> References: <20170818080728.43248-1-pablo.de.lara.guarch@intel.com> <20170921131123.16513-1-pablo.de.lara.guarch@intel.com> <20170921131123.16513-2-pablo.de.lara.guarch@intel.com> In-Reply-To: <20170921131123.16513-2-pablo.de.lara.guarch@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzNiZTIxM2MtMGVjZC00MDAzLTkxZmItYTBhMmNkNDg5ZmQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikl6cFpyZDdOaEx0d2VndWpQTDZBOTF6VzlrXC9WOUpURmtJOWVRdng5M0ZjPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: clarify API for AES-CCM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 09:57:22 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, September 21, 2017 2:11 PM > To: Doherty, Declan ; Trahe, Fiona ; Jain, Deepak K > ; Griffin, John > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 1/9] cryptodev: clarify API for AES-CCM >=20 > AES-CCM algorithm has some restrictions when > handling nonce (IV) and AAD information. >=20 > As the API stated, the nonce needs to be place 1 byte > after the start of the IV field. This field needs > to be 16 bytes long, regardless the length of the nonce, > but it is important to clarify that the first byte > and the padding added after the nonce may be modified > by the PMDs using this algorithm. >=20 > Same happens with the AAD. It needs to be placed 18 bytes > after the start of the AAD field. The field also needs > to be multiple of 16 bytes long and all memory reserved > (the first bytes and the padding (may be modified by the PMDs). >=20 > Lastly, nonce is not needed to be placed in the first 16 bytes > of the AAD, as the API stated, as that depends on the PMD > used, so the comment has been removed. >=20 > Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe