From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 39DFF1B2CC for ; Fri, 19 Jan 2018 13:00:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 04:00:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,381,1511856000"; d="scan'208";a="196898599" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga005.fm.intel.com with ESMTP; 19 Jan 2018 04:00:07 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.46]) by irsmsx105.ger.corp.intel.com ([169.254.7.236]) with mapi id 14.03.0319.002; Fri, 19 Jan 2018 12:00:06 +0000 From: "Trahe, Fiona" To: "Verma, Shally" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Challa, Mahipal" , "Athreya, Narayana Prasad" , "De Lara Guarch, Pablo" , "Gupta, Ashish" , "Sahu, Sunila" , "Jain, Deepak K" , Hemant Agrawal , "Roy Pledge" , Youri Querry , "Ahmed Mansour" , "Trahe, Fiona" Thread-Topic: [RFC v3 1/1] lib: add compressdev API Thread-Index: AQHTdc0UinnGLuzhCUCQkELi5wsFSqN5yzUAgAF6aqA= Date: Fri, 19 Jan 2018 12:00:05 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435892FCF50@IRSMSX101.ger.corp.intel.com> References: <1511542566-10455-1-git-send-email-fiona.trahe@intel.com> <1513360153-15036-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDhkMTg0OWEtNzkyZi00NWQzLThiNzUtN2E0MzFhMmYwYmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJSdGpsV1ZCTVc3V2Y1SVBLZUdidmluNzhjb1BTNzNiRHpkeUZ1am5cL1dFPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 12:00:10 -0000 Hi Shally, > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Thursday, January 18, 2018 12:54 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Challa, Mahipal ; Athreya, Narayana Prasad > ; De Lara Guarch, Pablo ; > Gupta, Ashish ; Sahu, Sunila ; Jain, Deepak K > ; Hemant Agrawal ; Roy P= ledge > ; Youri Querry ; Ahmed Mansou= r > > Subject: RE: [RFC v3 1/1] lib: add compressdev API >=20 > Hi Fiona >=20 > While revisiting this, we identified few questions and additions. Please = see them inline. >=20 >=20 > > -----Original Message----- > > From: Trahe, Fiona [mailto:fiona.trahe@intel.com] > > Sent: 15 December 2017 23:19 > > To: dev@dpdk.org; Verma, Shally > > Cc: Challa, Mahipal ; Athreya, Narayana > > Prasad ; > > pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com > > Subject: [RFC v3 1/1] lib: add compressdev API > > > > Signed-off-by: Trahe, Fiona > > --- >=20 > //snip >=20 > > + > > +int > > +rte_compressdev_queue_pair_setup(uint8_t dev_id, uint16_t > > queue_pair_id, > > + uint32_t max_inflight_ops, int socket_id) >=20 > [Shally] Is max_inflights_ops different from nb_streams_per_qp in struct = rte_compressdev_info? > I assume they both carry same purpose. If yes, then it will be better to = use single naming convention to > avoid confusion. [Fiona] No, I think they have different purposes. max_inflight_ops should be used to configure the qp with the number of ops = the application expects to be able to submit to the qp before it needs to p= oll for a response. It can be configured differently for each qp. In the QA= T case it dictates the depth of the qp created, it may have different impli= cations on other PMDs. nb_sessions_per_qp and nb_streams_per_qp are limitations the devices report= s and are same for all qps on the device. QAT doesn't have those limitation= s and so would report 0, however I assumed they may be necessary for other = devices.=20 This assumption is based on the patch submitted by NXP to cryptodev in Feb = 2017 http://dpdk.org/ml/archives/dev/2017-March/060740.html I also assume these are not necessarily the max number of sessions in ops o= n the qp at a given time, but the total number attached, i.e. if the device= has this limitation then sessions must be attached to qps, and presumably = reserve some resources. Being attached doesn't imply there is an op on the = qp at that time using that session. So it's not to relating to the inflight= op count, but to the number of sessions attached/detached to the qp.=20 Including Akhil on the To list, maybe NXP can confirm if these params are n= eeded. =20 > Also, is it optional API? Like Is this a valid use case?: > dev_configure() --> dev_start() --> qp_start() --> enqueue/dequeue() --> = qp_stop() --> dev_stop() --> > dev_close()? [Fiona] I don't think it should be optional as some PMDs need to allocate r= esources based on the setup data passed in on this API. =20 =20 > //snip >=20 > > + > > +#define RTE_COMPRESSDEV_PMD_NAME_ARG > > ("name") > > +#define RTE_COMPRESSDEV_PMD_MAX_NB_QP_ARG > > ("max_nb_queue_pairs") > > +#define RTE_COMPRESSDEV_PMD_SOCKET_ID_ARG ("socket_id") > > + >=20 > [Shally] Need to define argument macro for max_nb_session_per_qp and max_= nb_streams_per_qp as > well [Fiona] ok > > + > > +static const char * const compressdev_pmd_valid_params[] =3D { > > + RTE_COMPRESSDEV_PMD_NAME_ARG, > > + RTE_COMPRESSDEV_PMD_MAX_NB_QP_ARG, > > + RTE_COMPRESSDEV_PMD_SOCKET_ID_ARG > > +}; >=20 > [Shally] Likewise, array need to be updated with other mentioned two argu= ments Fiona] ok =20 > > + > > +/** > > + * @internal > > + * Initialisation parameters for comp devices > > + */ > > +struct rte_compressdev_pmd_init_params { > > + char name[RTE_COMPRESSDEV_NAME_MAX_LEN]; > > + size_t private_data_size; > > + int socket_id; > > + unsigned int max_nb_queue_pairs; >=20 > [Shally] And this also need to be updated with max_nb_sessions_per_qp and= max_streams_per_qp [Fiona] ok =20 > //snip >=20 > Thanks > Shally