From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <fiona.trahe@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id EA628A493
for <dev@dpdk.org>; Thu, 25 Jan 2018 10:52:29 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Jan 2018 01:52:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,411,1511856000"; d="scan'208";a="198682540"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
by fmsmga006.fm.intel.com with ESMTP; 25 Jan 2018 01:52:28 -0800
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.46]) by
IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002;
Thu, 25 Jan 2018 09:52:27 +0000
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v4] crypto/qat: add null point check and fix mem leak
Thread-Index: AQHTlayR8JiEDR7y+UquheEYQAdas6OEWNxA
Date: Thu, 25 Jan 2018 09:52:27 +0000
Message-ID: <348A99DA5F5B7549AA880327E580B435893008D3@IRSMSX101.ger.corp.intel.com>
References: <1516863184-4713-1-git-send-email-wang.yong19@zte.com.cn>
In-Reply-To: <1516863184-4713-1-git-send-email-wang.yong19@zte.com.cn>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWFiNjBmM2ItODdhZC00OWNlLTg0OTEtYmZmYjE1ZGNkZjlmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9zbGZRckRkRWxpa0lvTjhkZnN4OHJJa3Jab29abkx5UE1QaCtZTUpXZlk9In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4] crypto/qat: add null point check and fix
mem leak
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2018 09:52:30 -0000
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Thursday, January 25, 2018 6:53 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [PATCH v4] crypto/qat: add null point check and fix mem leak
>=20
> There are several func calls to rte_zmalloc() which don't do null
> point check on the return value. And before return, the memory is not
> freed. Fix it by adding null point check and rte_free().
>=20
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
> Fixes: e09231eaa2af ("crypto/qat: add SGL capability")
>=20
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>