From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4174A1B00C for ; Thu, 1 Feb 2018 12:54:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 03:54:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,443,1511856000"; d="scan'208";a="27224569" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2018 03:54:25 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.188]) by IRSMSX106.ger.corp.intel.com ([169.254.8.62]) with mapi id 14.03.0319.002; Thu, 1 Feb 2018 11:54:25 +0000 From: "Trahe, Fiona" To: "Verma, Shally" , Ahmed Mansour , "dev@dpdk.org" CC: "Athreya, Narayana Prasad" , "Gupta, Ashish" , "Sahu, Sunila" , "De Lara Guarch, Pablo" , "Challa, Mahipal" , "Jain, Deepak K" , Hemant Agrawal , Roy Pledge , Youri Querry , "Trahe, Fiona" Thread-Topic: [RFC v2] doc compression API for DPDK Thread-Index: AdOFUW8Wdt99b3u6RKydGSrxJwvtHgVaFBAAABkgmxAADQ9lcA== Date: Thu, 1 Feb 2018 11:54:24 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589315AF3@IRSMSX101.ger.corp.intel.com> References: <348A99DA5F5B7549AA880327E580B435892F589D@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B43589315232@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmQ5MGVmYmYtZTI5NC00YTQxLWFmMTEtODA0M2M1MmI0NDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikp4U2o5NGd0MUlMRm5KVmZMS1JDcmFhMnpNQ3JxVVlSM1dCS3J1UVczc1E9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v2] doc compression API for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 11:54:29 -0000 > >[Fiona] I propose if BFINAL bit is detected before end of input > >the decompression should stop. In this case consumed will be < src.lengt= h. > >produced will be < dst buffer size. Do we need an extra STATUS response? > >STATUS_BFINAL_DETECTED ? > [Shally] @fiona, I assume you mean here decompressor stop after processin= g Final block right? [Fiona] Yes. And if yes, > and if it can process that final block successfully/unsuccessfully, then = status could simply be > SUCCESS/FAILED. > I don't see need of specific return code for this use case. Just to share= , in past, we have practically run into > such cases with boost lib, and decompressor has simply worked this way. [Fiona] I'm ok with this. > >Only thing I don't like this is it can impact on performance, as normall= y > >we can just look for STATUS =3D=3D SUCCESS. Anything else should be an e= xception. > >Now the application would have to check for SUCCESS || BFINAL_DETECTED e= very time. > >Do you have a suggestion on how we should handle this? > >