From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4C44B5F24 for ; Mon, 26 Mar 2018 13:45:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2018 04:45:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,364,1517904000"; d="scan'208";a="42234085" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 26 Mar 2018 04:44:58 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX109.ger.corp.intel.com ([169.254.13.170]) with mapi id 14.03.0319.002; Mon, 26 Mar 2018 12:44:57 +0100 From: "Trahe, Fiona" To: Thomas Monjalon CC: "dev@dpdk.org" , "ahmed.mansour@nxp.com" , "Shally.Verma@cavium.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] compressdev: implement API Thread-Index: AQHTnFNA34V0d0oQkkqZkaaruzarZKOUTyIAgEoWovCAAHkTAIAD2AWQ Date: Mon, 26 Mar 2018 11:44:56 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435893613A1@IRSMSX101.ger.corp.intel.com> References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> <1997769.o2qW9LT7Ur@xps> <348A99DA5F5B7549AA880327E580B43589360349@IRSMSX101.ger.corp.intel.com> <2211509.83yEhUb72U@xps> In-Reply-To: <2211509.83yEhUb72U@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVmMDJiOTItNmEyNC00MTliLTljZDYtMjE5NzA1NWU1ZDg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJmN3k4emx0SkVCbDdFZTNhelNkYm5cL2xwQjNtRnJTcDhVVmtmc2FQbGlnPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 11:45:02 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Saturday, March 24, 2018 1:02 AM > To: Trahe, Fiona > Cc: dev@dpdk.org; ahmed.mansour@nxp.com; Shally.Verma@cavium.com; De Lara= Guarch, Pablo > ; fiona.trahe@gmail.com > Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API >=20 > 23/03/2018 19:08, Trahe, Fiona: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 02/02/2018 19:25, Fiona Trahe: > > > > lib/librte_compressdev/rte_comp.h | 503 +++++++++= +++ > > > > > > Why rte_comp.h instead of the more consistent rte_compress.h? > > [Fiona] I did originally... but ran into difficulty with horribly name= s like > > RTE_COMPRESS_COMPRESS > > RTE_COMPRESS_DECOMPRESS > > rte_compress_compress_xform > > rte_compress_decompress_xform > > So compress is both the module prefix and the name of one of the action= s. > > I could have used compressdev - but names were very long. > > So decided to opt for using > > _compressdev_ in names to do with the device and > > _comp_ in names to do with the compression service > > > > Also I could have used compdev instead of compressdev, > > but I felt compress should be in the lib name >=20 > I understand your concerns. > I don't like "comp" very much because it sounds like "comparison". > However, I don't have a better idea. > Sometimes naming is more difficult than coding :) [Fiona] True :)