From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 73B3D25D9 for ; Fri, 10 Aug 2018 15:14:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 06:14:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,219,1531810800"; d="scan'208";a="82311879" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 10 Aug 2018 06:14:37 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 14:14:36 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.40]) by irsmsx112.ger.corp.intel.com ([169.254.1.35]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 14:14:36 +0100 From: "Trahe, Fiona" To: Thomas Monjalon CC: "dev@dpdk.org" , "De Lara Guarch, Pablo" , "Jozwiak, TomaszX" Thread-Topic: [dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section Thread-Index: AQHUMAEooDgFTwKJlkWYHVgThIQwyqS3wveAgADZqTCAAAPQAIAAVZiQ Date: Fri, 10 Aug 2018 13:14:35 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435896002C9@IRSMSX101.ger.corp.intel.com> References: <1533820674-9507-1-git-send-email-fiona.trahe@intel.com> <3437470.R4aupjBKb7@xps> <348A99DA5F5B7549AA880327E580B4358960000B@IRSMSX101.ger.corp.intel.com> <1556861.lFMShj47WS@xps> In-Reply-To: <1556861.lFMShj47WS@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzFiN2I0NzktMGVlMS00ZDljLWI2MWMtNWJlZmJiMjAyOTAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN2VJeEROc1B2eE1aeDdDRDYzVldPV1A5SFQ1XC9WY3BLaE5PNTJkaFNzNjVsK0V1ZnVsQ0gyNE9OblZXeXZQY2kifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 13:14:54 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, August 10, 2018 10:01 AM > To: Trahe, Fiona > Cc: dev@dpdk.org; De Lara Guarch, Pablo ;= Jozwiak, TomaszX > > Subject: Re: [dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section >=20 > 10/08/2018 09:51, Trahe, Fiona: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 09/08/2018 18:50, Fiona Trahe: > > > > +Quick instructions for QAT compressdev PMD are as follows: > > > > > > > > +.. code-block:: console > > > > + > > > > + cd to the top-level DPDK directory > > > > + make defconfig > > > > + make > > > > > > This code block seems too much obvious. > > Just for completeness and to be helpful - save people wasting time look= ing for > > a non-existent QAT comp config option which they'd probably do if follo= wing the snippet above it > > for QAT crypto where there is a need to change config. >=20 > I don't understand. > There is nothing to change in the config, right? [Fiona] Have a look in the final html - I believe it's clearer with this se= ction in and is more helpful to leave in than to omit. > > > > +.. _qat_kernel: > > > > + > > > > +Dependency on the QAT kernel driver > > > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > The anchor seems useless. > > > > > It's used a few paragraphs above. >=20 > I don't find it in your patches. >=20 It's in this patch about 40 lines above the line you commented on.