From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 401D12BD5 for ; Tue, 20 Nov 2018 17:25:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2018 08:25:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,257,1539673200"; d="scan'208";a="93540378" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga008.jf.intel.com with ESMTP; 20 Nov 2018 08:25:26 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 20 Nov 2018 16:25:25 +0000 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.134]) by irsmsx155.ger.corp.intel.com ([169.254.14.44]) with mapi id 14.03.0415.000; Tue, 20 Nov 2018 16:25:25 +0000 From: "Trahe, Fiona" To: Stephen Hemminger CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Jozwiak, TomaszX" , "shally.verma@caviumnetworks.com" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done Thread-Index: AQHUgHH0iBHC0Frsi0+jiJBhoUExD6VX5t6AgADy5OA= Date: Tue, 20 Nov 2018 16:25:25 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> <20181119175349.2bd2fdd1@xeon-e3> In-Reply-To: <20181119175349.2bd2fdd1@xeon-e3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTdjODZjYTUtMjM2Zi00NTBhLWFjMTctYTllNjUwNTA1ZTU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYk94MUtkaVJlQldpNGpiWmlwUGxjbzR5MzdiRTVlR29QOE4wTWVcLzFzVE0wQXZYbUhjT0hYZXJ1UjBXYjBjbkMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 16:25:29 -0000 Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, November 19, 2018 6:54 PM > To: Trahe, Fiona > Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX ; > shally.verma@caviumnetworks.com; ashish.gupta@caviumnetworks.com; Daly, L= ee > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify = where processing is done >=20 > On Tue, 20 Nov 2018 01:39:48 +0000 > Fiona Trahe wrote: >=20 > > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE > > is added. A PMD which processes operations using a software > > acceleration engine should set this if the bulk of the > > processing is done during the dequeue. It should leave it > > cleared if the bulk of the processing is done during the > > enqueue (default). > > An application may find this useful for tuning. > > > > Signed-off-by: Fiona Trahe >=20 > What application? or is this "if we build it they will come?" [Fiona] Our storage team asked for this, so not quite. Seems like it might by generically useful, so a bit of the latter too :) Would you prefer I removed that line?