From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 848474C8F for ; Tue, 9 Apr 2019 17:17:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 08:17:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="134280470" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga006.jf.intel.com with ESMTP; 09 Apr 2019 08:17:14 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 9 Apr 2019 16:17:13 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by irsmsx155.ger.corp.intel.com ([169.254.14.186]) with mapi id 14.03.0415.000; Tue, 9 Apr 2019 16:17:13 +0100 From: "Trahe, Fiona" To: Ayuj Verma , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" , "De Lara Guarch, Pablo" CC: "shallyv@marvell.com" , "ssahu@marvell.com" , "kkotamarthy@marvell.com" , "adesai@marvell.com" , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Thread-Index: AQHU7sgdjnB7ftUqtUGurkGwlNYoR6Yz7ysw Date: Tue, 9 Apr 2019 15:17:13 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358973CC8B@IRSMSX101.ger.corp.intel.com> References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com> In-Reply-To: <1554809619-21164-2-git-send-email-ayverma@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmFiYjMyZDctYWU1OC00ZTljLWE2MTktZmJlOGMwNTQ3ZjQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWEtrdjRhbHFneGZGMnp4ZFg4QVIrcFBPRTd0OFpNa04xWHpySFZvRVg4SVRKS3VmNWJ1MEVGYjlOejRNaXV2dCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 15:17:18 -0000 Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Tuesday, April 9, 2019 12:34 PM > To: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > ; De Lara Guarch, Pablo > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma > Subject: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP >=20 > Return -ENOTSUP for unsupported tests >=20 > Signed-off-by: Ayuj Verma > Signed-off-by: Shally Verma > --- > app/test/test_cryptodev_asym.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index d2efce9..feed3a8 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -352,7 +352,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } >=20 > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -498,7 +498,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } >=20 > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1261,7 +1261,7 @@ static inline void print_asym_capa( > &modinv_xform.xform_type, "modinv") < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] this looks more like a test code bug rather than an indication that= the device doesn't support modinv. SO should still return -1. Also - while you're updating, can you please fix the typo in the trace - AS= YNC should be ASYMM > } >=20 > cap_idx.type =3D modinv_xform.xform_type; > @@ -1273,7 +1273,7 @@ static inline void print_asym_capa( > modinv_xform.modinv.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] please update the trace to match the return, e.g. something like "m= odulus length %len not supported by this device"=20 > } >=20 > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1380,7 +1380,7 @@ static inline void print_asym_capa( > < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; > } [Fiona] same as above, i.e. code bug. And typo in trace. >=20 > /* check for modlen capability */ > @@ -1391,7 +1391,7 @@ static inline void print_asym_capa( > capability, modex_xform.modex.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] same as above. Fix trace. > } >=20 > /* generate crypto op data structure */ > -- > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F28FDA0096 for ; Tue, 9 Apr 2019 17:17:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 895714D3A; Tue, 9 Apr 2019 17:17:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 848474C8F for ; Tue, 9 Apr 2019 17:17:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 08:17:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="134280470" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga006.jf.intel.com with ESMTP; 09 Apr 2019 08:17:14 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 9 Apr 2019 16:17:13 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by irsmsx155.ger.corp.intel.com ([169.254.14.186]) with mapi id 14.03.0415.000; Tue, 9 Apr 2019 16:17:13 +0100 From: "Trahe, Fiona" To: Ayuj Verma , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" , "De Lara Guarch, Pablo" CC: "shallyv@marvell.com" , "ssahu@marvell.com" , "kkotamarthy@marvell.com" , "adesai@marvell.com" , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Thread-Index: AQHU7sgdjnB7ftUqtUGurkGwlNYoR6Yz7ysw Date: Tue, 9 Apr 2019 15:17:13 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358973CC8B@IRSMSX101.ger.corp.intel.com> References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com> In-Reply-To: <1554809619-21164-2-git-send-email-ayverma@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmFiYjMyZDctYWU1OC00ZTljLWE2MTktZmJlOGMwNTQ3ZjQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWEtrdjRhbHFneGZGMnp4ZFg4QVIrcFBPRTd0OFpNa04xWHpySFZvRVg4SVRKS3VmNWJ1MEVGYjlOejRNaXV2dCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409151713.r4ybWW7rQ-jYBVYs_N_NGDSNqPc5uXNot_jvz7-wKcg@z> Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Tuesday, April 9, 2019 12:34 PM > To: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > ; De Lara Guarch, Pablo > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma > Subject: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP >=20 > Return -ENOTSUP for unsupported tests >=20 > Signed-off-by: Ayuj Verma > Signed-off-by: Shally Verma > --- > app/test/test_cryptodev_asym.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index d2efce9..feed3a8 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -352,7 +352,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } >=20 > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -498,7 +498,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } >=20 > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1261,7 +1261,7 @@ static inline void print_asym_capa( > &modinv_xform.xform_type, "modinv") < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] this looks more like a test code bug rather than an indication that= the device doesn't support modinv. SO should still return -1. Also - while you're updating, can you please fix the typo in the trace - AS= YNC should be ASYMM > } >=20 > cap_idx.type =3D modinv_xform.xform_type; > @@ -1273,7 +1273,7 @@ static inline void print_asym_capa( > modinv_xform.modinv.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] please update the trace to match the return, e.g. something like "m= odulus length %len not supported by this device"=20 > } >=20 > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1380,7 +1380,7 @@ static inline void print_asym_capa( > < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; > } [Fiona] same as above, i.e. code bug. And typo in trace. >=20 > /* check for modlen capability */ > @@ -1391,7 +1391,7 @@ static inline void print_asym_capa( > capability, modex_xform.modex.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] same as above. Fix trace. > } >=20 > /* generate crypto op data structure */ > -- > 1.8.3.1