From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id ACF2B1B1F5 for ; Fri, 12 Apr 2019 17:17:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2019 08:17:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,341,1549958400"; d="scan'208";a="133789952" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga008.jf.intel.com with ESMTP; 12 Apr 2019 08:17:39 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by irsmsx110.ger.corp.intel.com ([169.254.15.173]) with mapi id 14.03.0415.000; Fri, 12 Apr 2019 16:17:38 +0100 From: "Trahe, Fiona" To: Ayuj Verma , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" CC: "shallyv@marvell.com" , "ssahu@marvell.com" , "kkotamarthy@marvell.com" , "adesai@marvell.com" , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AQHU8P34i6obVnARzEmYuWnWlH+ovqY4Wpkg Date: Fri, 12 Apr 2019 15:17:38 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358973F9C4@IRSMSX101.ger.corp.intel.com> References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> In-Reply-To: <1555052602-19155-1-git-send-email-ayverma@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDIwNmU1YzMtYzdkZS00M2IwLTg1YTAtOWY5NjI5MGY5Yjk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWDhxQm1YUmtUalBLOVl0cHlnZnZkR1RqZzF0d0dISlAyUzVpRXJid3FjeFFyaUcyc2d5MGplcWZRNWRTWlwvbEYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 15:17:43 -0000 Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.goyal@nxp.com; Kusztal, ArkadiuszX ; Trahe, Fiona > > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma > Subject: [PATCH v1] fix alphabetical ordering of headers >=20 > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. >=20 > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.= h, it=20 probably shouldn't. What's the dependency and can/should it be moved to rte= _crypto.h? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 210B2A0096 for ; Fri, 12 Apr 2019 17:17:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A3281B1F6; Fri, 12 Apr 2019 17:17:44 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id ACF2B1B1F5 for ; Fri, 12 Apr 2019 17:17:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2019 08:17:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,341,1549958400"; d="scan'208";a="133789952" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga008.jf.intel.com with ESMTP; 12 Apr 2019 08:17:39 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by irsmsx110.ger.corp.intel.com ([169.254.15.173]) with mapi id 14.03.0415.000; Fri, 12 Apr 2019 16:17:38 +0100 From: "Trahe, Fiona" To: Ayuj Verma , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" CC: "shallyv@marvell.com" , "ssahu@marvell.com" , "kkotamarthy@marvell.com" , "adesai@marvell.com" , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AQHU8P34i6obVnARzEmYuWnWlH+ovqY4Wpkg Date: Fri, 12 Apr 2019 15:17:38 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358973F9C4@IRSMSX101.ger.corp.intel.com> References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> In-Reply-To: <1555052602-19155-1-git-send-email-ayverma@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDIwNmU1YzMtYzdkZS00M2IwLTg1YTAtOWY5NjI5MGY5Yjk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWDhxQm1YUmtUalBLOVl0cHlnZnZkR1RqZzF0d0dISlAyUzVpRXJid3FjeFFyaUcyc2d5MGplcWZRNWRTWlwvbEYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412151738.Jy1JLXYVVDFUU8DaKeUJYM6F7j8ejWQlVeag-2GERlM@z> Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.goyal@nxp.com; Kusztal, ArkadiuszX ; Trahe, Fiona > > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma > Subject: [PATCH v1] fix alphabetical ordering of headers >=20 > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. >=20 > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.= h, it=20 probably shouldn't. What's the dependency and can/should it be moved to rte= _crypto.h?